Re: squid3 future directory structure

2008-02-28 Thread Robert Collins
On Tue, 2008-02-26 at 20:37 -0700, Alex Rousskov wrote: On Wed, 2008-02-27 at 11:33 +1100, Robert Collins wrote: On Tue, 2008-02-26 at 16:50 -0700, Alex Rousskov wrote: That #include line would be illegal in cleaned up sources, of course. You are supposed to say include1/Foo.h or

Re: squid3 future directory structure

2008-02-27 Thread Kinkie
On Wed, Feb 27, 2008 at 4:37 AM, Alex Rousskov [EMAIL PROTECTED] wrote: On Wed, 2008-02-27 at 11:33 +1100, Robert Collins wrote: So you would recommend something like http/request_method.cc and acl/request_header_strategy.h I prefer not to use camelcase when it comes to

Re: squid3 future directory structure

2008-02-26 Thread Robert Collins
On Fri, 2008-02-22 at 20:11 +0100, Guido Serassio wrote: Hi Alex, At 19:29 22/02/2008, Alex Rousskov wrote: On Fri, 2008-02-22 at 19:23 +0100, Guido Serassio wrote: Changing the case of files/dir will not be a problem if we will avoid upper/lower case collisions. This only applies

Re: squid3 future directory structure

2008-02-26 Thread Alex Rousskov
On Wed, 2008-02-27 at 07:59 +1100, Robert Collins wrote: On Fri, 2008-02-22 at 20:11 +0100, Guido Serassio wrote: Hi Alex, At 19:29 22/02/2008, Alex Rousskov wrote: On Fri, 2008-02-22 at 19:23 +0100, Guido Serassio wrote: Changing the case of files/dir will not be a problem if we

Re: squid3 future directory structure

2008-02-26 Thread Alex Rousskov
On Wed, 2008-02-27 at 11:33 +1100, Robert Collins wrote: On Tue, 2008-02-26 at 16:50 -0700, Alex Rousskov wrote: That #include line would be illegal in cleaned up sources, of course. You are supposed to say include1/Foo.h or equivalent. That's why duplicating group in file names may

Re: squid3 future directory structure

2008-02-25 Thread Alex Rousskov
On Sat, 2008-02-23 at 14:47 +0100, Henrik Nordström wrote: fre 2008-02-22 klockan 11:29 -0700 skrev Alex Rousskov: On Fri, 2008-02-22 at 19:23 +0100, Guido Serassio wrote: Changing the case of files/dir will not be a problem if we will avoid upper/lower case collisions. This only

Re: squid3 future directory structure

2008-02-23 Thread Henrik Nordström
fre 2008-02-22 klockan 11:29 -0700 skrev Alex Rousskov: On Fri, 2008-02-22 at 19:23 +0100, Guido Serassio wrote: Changing the case of files/dir will not be a problem if we will avoid upper/lower case collisions. This only applies to files in the same directory, right? AFAICT,

Re: squid3 future directory structure

2008-02-22 Thread Guido Serassio
Hi Alex, At 00:25 20/02/2008, Alex Rousskov wrote: We had many problems on Windows in the past during the C++ refactoring. Do you still have those problems (we do use many capitalization styles right now)? Or is mixed case only a problem when we rename/move things and then there is no

Re: squid3 future directory structure

2008-02-22 Thread Alex Rousskov
On Fri, 2008-02-22 at 19:23 +0100, Guido Serassio wrote: Changing the case of files/dir will not be a problem if we will avoid upper/lower case collisions. This only applies to files in the same directory, right? AFAICT, filenames from different directories may still collide and even have

Re: squid3 future directory structure

2008-02-22 Thread Guido Serassio
Hi Alex, At 19:29 22/02/2008, Alex Rousskov wrote: On Fri, 2008-02-22 at 19:23 +0100, Guido Serassio wrote: Changing the case of files/dir will not be a problem if we will avoid upper/lower case collisions. This only applies to files in the same directory, right? Sure. AFAICT,

Re: squid3 future directory structure

2008-02-19 Thread Guido Serassio
Hi, At 04:56 15/02/2008, Robert Collins wrote: Some, but not a lot :-) I'm constantly encountering syntax and typo errors because HTTP is not always spelt upper-case in class names. I'd prefer lowercase always for directories. filenames and CaSe are always headaches on windows :) +1 We

Re: squid3 future directory structure

2008-02-19 Thread Alex Rousskov
On Tue, 2008-02-19 at 22:48 +0100, Guido Serassio wrote: At 04:56 15/02/2008, Robert Collins wrote: Some, but not a lot :-) I'm constantly encountering syntax and typo errors because HTTP is not always spelt upper-case in class names. I'd prefer lowercase always for directories.

Re: squid3 future directory structure

2008-02-14 Thread Alex Rousskov
On Thu, 2008-02-14 at 11:45 +1300, Amos Jeffries wrote: http://wiki.squid-cache.org/Features/SourceLayout Added ICMP to your list of components. It's a clear-cut one now. Thank you. Can you lead this activity? We need somebody who will drive the discussion and oversee actual changes... 1)

Re: squid3 future directory structure

2008-02-14 Thread Amos Jeffries
On Thu, 2008-02-14 at 11:45 +1300, Amos Jeffries wrote: http://wiki.squid-cache.org/Features/SourceLayout Added ICMP to your list of components. It's a clear-cut one now. Thank you. Can you lead this activity? We need somebody who will drive the discussion and oversee actual changes...

Re: squid3 future directory structure

2008-02-14 Thread Robert Collins
On Fri, 2008-02-15 at 12:24 +1300, Amos Jeffries wrote: 6) Should directory names use just_small, CamelCase, or CAPS letters? I Think CamelCase like we do for files and classes, with acroynms being upper case is working. When we can make the converted and re-used legacy files from

Re: squid3 future directory structure

2008-02-13 Thread Alex Rousskov
Hello, I have created the following wiki page to see if we can agree on how to define future subdirectories and what to move there. This can be a Squid 3.2 feature, I think. http://wiki.squid-cache.org/Features/SourceLayout Amos, do you want to lead this activity? I have already covered

Re: squid3 future directory structure

2008-02-13 Thread Alex Rousskov
On Thu, 2008-02-14 at 11:45 +1300, Amos Jeffries wrote: I'd prefer the filenames matching the (single!) class defined inside. Standard C++ practice for some. Sure. That means some need a Foo/FooX others just Foo/XYZ. But we can use namespaces and rename classes as needed to avoid long

Re: squid3 future directory structure

2008-02-13 Thread Amos Jeffries
Hello, I have created the following wiki page to see if we can agree on how to define future subdirectories and what to move there. This can be a Squid 3.2 feature, I think. http://wiki.squid-cache.org/Features/SourceLayout Amos, do you want to lead this activity? I have already

Re: squid3 future directory structure

2008-02-13 Thread Amos Jeffries
On Thu, 2008-02-14 at 11:45 +1300, Amos Jeffries wrote: I'd prefer the filenames matching the (single!) class defined inside. Standard C++ practice for some. Sure. That means some need a Foo/FooX others just Foo/XYZ. But we can use namespaces and rename classes as needed to avoid long

Re: squid3 future directory structure

2008-02-12 Thread Amos Jeffries
Alex Rousskov wrote: On Tue, 2008-02-12 at 11:19 +1300, Amos Jeffries wrote: On Tue, 2008-02-12 at 10:37 +1300, Amos Jeffries wrote: When we get a better VCS, we should discuss moving include/ and lib/ stuff into src/ with the exception of 3rd party code. This would avoid problems created by

Re: squid3 future directory structure

2008-02-12 Thread Alex Rousskov
On Tue, 2008-02-12 at 23:42 +1300, Amos Jeffries wrote: Alex Rousskov wrote: Another big related question is the header path problem: Do we want to have something like squid/src/squid/module/*, which allows you to refer to Squid include files as squid/module/something.h as opposed to

squid3 future directory structure

2008-02-11 Thread Alex Rousskov
On Tue, 2008-02-12 at 11:19 +1300, Amos Jeffries wrote: On Tue, 2008-02-12 at 10:37 +1300, Amos Jeffries wrote: When we get a better VCS, we should discuss moving include/ and lib/ stuff into src/ with the exception of 3rd party code. This would avoid problems created by that artificial