[sr-dev] git:master:f58958e9: modules: readme files regenerated - db_sqlite ... [skip ci]

2017-06-19 Thread Kamailio Dev
Module: kamailio Branch: master Commit: f58958e92dbc263b72a77395e828a38c123766e6 URL: https://github.com/kamailio/kamailio/commit/f58958e92dbc263b72a77395e828a38c123766e6 Author: Kamailio Dev Committer: Kamailio Dev Date: 2017-06-20T08:46:49+02:00 modules: readme files regenerated - db_sqlite

Re: [sr-dev] [kamailio/kamailio] db_sqlite: new param to set database journal mode (#1153)

2017-06-19 Thread Daniel-Constantin Mierla
Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1153#issuecomment-309658271___ Kamailio (SER) - Development Mailing List sr-dev@lis

Re: [sr-dev] [kamailio/kamailio] db_sqlite: new param to set database journal mode (#1153)

2017-06-19 Thread Daniel-Constantin Mierla
Merged #1153. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1153#event-1130382372___ Kamailio (SER) - Development Mailing List sr-dev@lis

[sr-dev] git:master:b35a11f2: db_sqlite: new param to set database journal mode

2017-06-19 Thread Julien Chavanton
Module: kamailio Branch: master Commit: b35a11f24b9e66f967551345b92f3b050b2786bc URL: https://github.com/kamailio/kamailio/commit/b35a11f24b9e66f967551345b92f3b050b2786bc Author: Julien Chavanton Committer: Julien Chavanton Date: 2017-06-19T14:35:49-07:00 db_sqlite: new param to set database j

[sr-dev] git:master:8885a039: Merge pull request #1153 from jchavanton/db_sqlite_journaling

2017-06-19 Thread GitHub
Module: kamailio Branch: master Commit: 8885a0392cf22b2217cbe2b05d8a412d38ba31b7 URL: https://github.com/kamailio/kamailio/commit/8885a0392cf22b2217cbe2b05d8a412d38ba31b7 Author: Daniel-Constantin Mierla Committer: GitHub Date: 2017-06-20T08:34:30+02:00 Merge pull request #1153 from jchavanton

[sr-dev] [kamailio/kamailio] Fix compiler warnings for unused static symbols (#1154)

2017-06-19 Thread Corey Farrell
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1154 -- Commit Summary -- * Fix compiler warnings for unused static symbols -- File Changes -- M src/modules/carrierroute/cr_fifo.c (6) M src/modules/ims_auth/authorize.c (6)

[sr-dev] [kamailio/kamailio] db_sqlite: new param to set database journal mode (#1153)

2017-06-19 Thread Julien Chavanton
Exposing journal mode as a module parameter, one great feature is to be able to use WAL mode and share a database in read / write mode with facing any locking. https://sqlite.org/wal.html You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-19 Thread Alexandr Dubovikov
bingo! :-) now another issue: /usr/sbin/kamailio[1798]: ERROR: topoh [topoh_mod.c:560]: th_execute_event_route(): exit due to 'drop' in event route /usr/sbin/kamailio[1798]: : [core/mem/q_malloc.c:469]: qm_free(): BUG: qm_free: bad pointer 0x7fa3461b9000 (out of memory block!) called from co

Re: [sr-dev] [kamailio/kamailio] htable race condition on expired keys (#1152)

2017-06-19 Thread Daniel-Constantin Mierla
OK, I will dig in more once I get some time. Again, I could not find a reason on a quick check, but no much time right now, have to go for a while. Maybe, if you have some time, you can try to remove the mode and do always locking there. -- You are receiving this because you are subscribed to t

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-19 Thread Daniel-Constantin Mierla
Might have been the execution of clear_branches() inside next faked msg function, which was resetting some global variables. I just pushed a patch in master, can you give it a try again? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

[sr-dev] git:master:68db22bd: core: do not execute clear_branches() on next faked msg

2017-06-19 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 68db22bdfe50ff34df8e33bc06b80b5ad4844d7b URL: https://github.com/kamailio/kamailio/commit/68db22bdfe50ff34df8e33bc06b80b5ad4844d7b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2017-06-19T16:26:00+02:00 core: do not execute c

Re: [sr-dev] [kamailio/kamailio] htable race condition on expired keys (#1152)

2017-06-19 Thread lazedo
yes, https://github.com/2600hz/kazoo-configs-kamailio/blob/master/kamailio/nodes-role.cfg -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1152#issuecomment-309456035__

Re: [sr-dev] [kamailio/kamailio] htable race condition on expired keys (#1152)

2017-06-19 Thread Daniel-Constantin Mierla
Do you have an event_route for expired htable items in your configuration file? I do not see at a very quick check how the removed code is causing an issue, unless there are executions with mode==0 of ht_cell_value_add(), so the lock is not acquired. As a matter of fact, that mode stuff should b

Re: [sr-dev] [kamailio/kamailio] htable race condition on expired keys (#1152)

2017-06-19 Thread lazedo
sorry about that, patch updated ``` diff --git a/src/modules/htable/ht_api.c b/src/modules/htable/ht_api.c index 1bbd079..b5872d0 100644 --- a/src/modules/htable/ht_api.c +++ b/src/modules/htable/ht_api.c @@ -674,6 +674,7 @@ && strncmp(name->s, it->name.s, name->len

Re: [sr-dev] [kamailio/kamailio] htable race condition on expired keys (#1152)

2017-06-19 Thread Daniel-Constantin Mierla
Do not do patches that comment a lot of code because it is hard to detect if all code was commented or some were removed/added/changed. Just remove the code that you think is broken or eventually add it in between `#if 0 ... #endif`. -- You are receiving this because you are subscribed to this

Re: [sr-dev] [kamailio/kamailio] htable race condition on expired keys (#1152)

2017-06-19 Thread lazedo
core dump attached [core-dump.zip](https://github.com/kamailio/kamailio/files/1084801/core-dump.zip) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1152#issuecomment-309420202___

[sr-dev] [kamailio/kamailio] htable race condition on expired keys (#1152)

2017-06-19 Thread lazedo
related to https://github.com/kamailio/kamailio/commit/be46742ebe162a2c48ee5ce27e09497b23b66ea5 the below patch solves it, but i'm not sure of the implications why not let the expire routine do its job instead of checking expiration when adding a value ? also moved the `ht_handle_expired_record`

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-19 Thread Alexandr Dubovikov
no, the fake msg is not null, but once you call the faked_msg_next(), after you will always get "I'm terribly sorry, server error occurred (6/SL)", even if you didn't execute "run_top_route". I will check a bit more, but the issue it can be with pointer for re-transmission. -- You are recei

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-19 Thread Daniel-Constantin Mierla
Indeed, that condition should be with &&. Is the next fake msg null, or what is failing there? Can you see what is the return code for t_relay? I guess the slow error is because of sl_send_error () in kamaulio.cfg. I am traveling, no much testing that I can do. -- You are receiving this becaus

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-19 Thread Alexandr Dubovikov
Thank you @miconda , unfortunately there is bug that I couldnt catch. 6 days ago I have implemented same way in my repository: https://github.com/adubovikov/kamailio/commit/ae15a717e9a5849b4ac295c5864cd6e9b198b6d1 but your and my patches makes same results: /usr/sbin/kamailio[1260]: ERROR: sl [