Re: [sr-dev] [kamailio/kamailio] Segmentation fault when using USRLOC with db_mode=2 (#1231)

2017-09-12 Thread JohnJanke
It may also be worth noting that the same configuration works without issue using MySQL, on db_mode = 2. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Incorrect translation of tel: uri to sip: uri in tel2sip() (#1173)

2017-09-12 Thread Donald Carr
Hey, thank you VERY much Carsten, that is really appreciated. Sorry that I did not have time to take care of it. Don On Tue, Sep 12, 2017 at 9:27 AM, ng-voice GmbH wrote: > Hi, > > i've reviewed the code and made some minor improvements. I will commit a > slightly

Re: [sr-dev] [kamailio/kamailio] Segmentation fault when using USRLOC with db_mode=2 (#1231)

2017-09-12 Thread JohnJanke
So I tried db_mode 3 and it worked the first time. Phones registered and USRLOC wrote to the location table successfully. Stopped the service and then attempted to start again, and the time-out crash occurred. Tried once more, and it still crashed (however, the segfaults are different).

Re: [sr-dev] [kamailio/kamailio] Incorrect translation of tel: uri to sip: uri in tel2sip() (#1173)

2017-09-12 Thread ng-voice GmbH
Hi, i've reviewed the code and made some minor improvements. I will commit a slightly modified version later this week. Thanks, Carsten -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1233)

2017-09-12 Thread hdikme
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1233)

2017-09-12 Thread Lucian Balaceanu
Merged #1233. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1233#event-1245345074___ Kamailio (SER) - Development Mailing List

[sr-dev] git:master:e04716f4: seas: added guards to several include files

2017-09-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: e04716f4f9325fa5290555823132455ea599daac URL: https://github.com/kamailio/kamailio/commit/e04716f4f9325fa5290555823132455ea599daac Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread Daniel-Constantin Mierla
@hdikme - the comment of @lbalaceanu was on the code of the patch and github hides it, you need to press `Show outdated` in the right side of @lbalaceanu's comment above here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

[sr-dev] git:master:81ad6adb: Merge pull request #1233 from hdikme/master

2017-09-12 Thread GitHub
Module: kamailio Branch: master Commit: 81ad6adb6456490bce9dfe019c22857713669a52 URL: https://github.com/kamailio/kamailio/commit/81ad6adb6456490bce9dfe019c22857713669a52 Author: Lucian Balaceanu Committer: GitHub Date: 2017-09-12T17:00:38+03:00

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme
Closed #1232. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1232#event-1245286133___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] Incorrect translation of tel: uri to sip: uri in tel2sip() (#1173)

2017-09-12 Thread Donald Carr
Hey, very sorry, I got assigned another project and have not been able to get back to this. Hopefully I will have some time soon. I think it will be a good update that will avoid future problems. Don. On Sun, Sep 3, 2017 at 3:51 AM, Daniel-Constantin Mierla < notificati...@github.com> wrote: >

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme
Following the commit based on your comment, your comment "Please change query_done to false here and adapt the code accordingly. The name of the variable should reflect the value it holds." disappeared but i have done the requested changes. -- You are receiving this because you are

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme
@hdikme pushed 2 commits. 4aaa0af carrierroute: warning for the same carrier/domain having routes with only 0 probability c275210 Merge branch 'master' of https://github.com/hdikme/kamailio -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread Lucian Balaceanu
lbalaceanu commented on this pull request. > @@ -352,6 +353,7 @@ int load_route_data_db(struct route_data_t * rd) { } } int n = 0; + boolean query_done = true; Please change query_done to false here and adapt the code accordingly. The name of the variable

Re: [sr-dev] [kamailio/kamailio] t_replicate transaction failures keeps transaction in memory forever (#1220)

2017-09-12 Thread Daniel-Constantin Mierla
I couldn't find a reason after looking around, likely something is triggered at some point, in certain conditions. As a workaround, I am considering to add a hard cleanup on timer to the transactions that leave too long after lifetime, with a log message to gather some useful information for

Re: [sr-dev] [kamailio/kamailio] Segmentation fault when using USRLOC with db_mode=2 (#1231)

2017-09-12 Thread Daniel-Constantin Mierla
db_mode=0 makes usrloc to run without connecting to database. Can you try with db_mode=3 to see if there is same crash? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README