Thank you for the contribution. I will also do a quick review of the code today.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1755#issuecomment-444776808___
warning is fixed in PR https://github.com/kamailio/kamailio/pull/1756
```
warning: group kamailio does not exist - using root
warning: group kamailio does not exist - using root
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on Git
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for mo
sergey-safarov commented on this pull request.
> Environment='CFGFILE=/etc/kamailio/kamailio.cfg'
Environment='SHM_MEMORY=64'
Environment='PKG_MEMORY=4'
+RuntimeDirectory=kamailio
+RuntimeDirectoryMode=0755
+PIDFile=/var/run/kamailio/kamailio.pid
Also look
[`https://www.freedesktop.org/soft
I tested on 5.2.0 release and not see any issues with `kamailio:daemon`
permissions.
Please check on your side again.
```
[root@us-west-sw1 ~]# wget
https://download.opensuse.org/repositories/home:/kamailio:/v5.2.x-rpms/CentOS_7/x86_64/kamailio-5.2.0-2.1.x86_64.rpm
--2018-12-05 21:12:36--
https
Please check content of
[`kamailio.tmpfiles`](https://github.com/kamailio/kamailio/blob/master/pkg/kamailio/obs/kamailio.tmpfiles)
this file is defines creation of `/var/run/kamailio` directory with kamailio
permission.
I think you delete this folder in your environment and recreate back before
About your description `When starting Kamailio on Centos 7 with systemctl , it
gives "/var/run/kamailio Permission denied error" to create kamailio.pid file.`
I retest on my side.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitH
sergey-safarov requested changes on this pull request.
> @@ -7,9 +7,13 @@ After=network-online.target
Type=simple
User=kamailio
Group=daemon
+PermissionsStartOnly=true
Why need change `PermissionsStartOnly=true`?
What is error you try fix?
> Environment='CFGFILE=/etc/kamailio/kamailio.cfg'
Module: kamailio
Branch: master
Commit: 8153309c25dd65b8b52a4726f2a60d47b1fe61d3
URL:
https://github.com/kamailio/kamailio/commit/8153309c25dd65b8b52a4726f2a60d47b1fe61d3
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2018-12-05T18:34:01+01:00
dialog: free regex str
PR was merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1681#issuecomment-444556814___
Kamailio (SER) - Development Mailing List
s
Module: kamailio
Branch: master
Commit: 1cfeb19dedee8b1ae3065dad61c33e43727dab32
URL:
https://github.com/kamailio/kamailio/commit/1cfeb19dedee8b1ae3065dad61c33e43727dab32
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2018-12-05T17:45:29+01:00
dialog: docs for rpc c
Closed #1681.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1681#event-2007670557___
Kamailio (SER) - Development Mailing List
sr-dev@l
Closed #1697.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1697#event-2007666854___
Kamailio (SER) - Development Mailing List
sr-dev@l
Module: kamailio
Branch: master
Commit: f1ab32ee4a0bf64017a0b05f2013b81d37d50208
URL:
https://github.com/kamailio/kamailio/commit/f1ab32ee4a0bf64017a0b05f2013b81d37d50208
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2018-12-05T12:40:16+01:00
dialog: store call-id,
Module: kamailio
Branch: master
Commit: 862758b4ee194ff960eb6b8c038be1adfc18ef54
URL:
https://github.com/kamailio/kamailio/commit/862758b4ee194ff960eb6b8c038be1adfc18ef54
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2018-12-05T17:16:43+01:00
dialog: new rpc comman
Thanks for the quick response
- Module has been renamed to secfilter
- Global variables are now declared in the .c files
- All non static variables now have _sec__ prefix
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https
@Pepelux pushed 7 commits.
cb37158884016320912bdcb3b3c9377a1956edde Rename module from security to
secfilter
61cd525dc0355769d6d91e8f1a44d0d1bcaa69d3 Rename module to secfilter (doc files)
417e8d815c154d39a7fee1d428d5e6f02b5e09f8 Rename module to secfilter (schema)
722cebdb11c627fdf726fed1c868
For more info :
[systemd](https://www.freedesktop.org/software/systemd/man/systemd.service.html)
[systemd2
](https://www.freedesktop.org/software/systemd/man/systemd.exec.html#RuntimeDirectory=)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
Thanks for this submission!
Few remarks after a very brief look at the patch:
* global variables must be declared in a .c file and the .h file has to list
them with `external`, otherwise they get defined in each .c file where the .h
file is included
* it is recommended to use a prefix for a
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files
Thank you 👍
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1740#issuecomment-36439___
Kamailio (SER) - Development Mailing List
sr-de
Closed #1740.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1740#event-2006680728___
Kamailio (SER) - Development Mailing List
sr-dev@lis
Pushed it manually, it required to release the dialog. Changed also the name of
the command, dlg at the being redundant (the others have the name from mi time,
when prefix was not used). Returned string is a single world.
--
You are receiving this because you are subscribed to this thread.
Repl
Module: kamailio
Branch: master
Commit: d091de55146e90c2d15e67b746a369976aa7c24a
URL:
https://github.com/kamailio/kamailio/commit/d091de55146e90c2d15e67b746a369976aa7c24a
Author: Surendra Tiwari
Committer: Daniel-Constantin Mierla
Date: 2018-12-05T10:58:18+01:00
dialog: added rpc command dlg.i
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README fil
25 matches
Mail list logo
