[sr-dev] git:master:b85471a7: Makefile.defs: version set to 5.8.0-pre0

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: b85471a7c28324fcb890961a1ad67810bfbb8ac4 URL: https://github.com/kamailio/kamailio/commit/b85471a7c28324fcb890961a1ad67810bfbb8ac4 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-02-02T08:56:52+01:00 Makefile.defs:

[sr-dev] git:master:8c5e9758: Makefile.defs: version set to 5.8.0-dev3

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 8c5e97589fc0fed121ee6e8ca4adbf9ec63ad2eb URL: https://github.com/kamailio/kamailio/commit/8c5e97589fc0fed121ee6e8ca4adbf9ec63ad2eb Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-02-02T08:55:38+01:00 Makefile.defs:

[sr-dev] git:master:03e60c80: Makefile.groups: added file_out to extra group

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 03e60c809a0ac26b402bdf1154d6ec7b0476f26a URL: https://github.com/kamailio/kamailio/commit/03e60c809a0ac26b402bdf1154d6ec7b0476f26a Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-02-02T07:35:48+01:00 Makefile.groups:

[sr-dev] Re: [kamailio/kamailio] [pua] reginfo_increase_version does nothing (Issue #3234)

2024-02-01 Thread github-actions[bot] via sr-dev
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1922685515 You are receiving this because

[sr-dev] [kamailio/kamailio] db_unixodbc: MariaDB partition is a reserved word and not quoted (Issue #3742)

2024-02-01 Thread space88man via sr-dev
### Description partition is now a reserved word in MariaDB 10. the column name is correctly quoted with native libmysqlclient/libmariadb so works the column name is not quoted with unixodbc+(libmyodbc8|libmaodbc) and so fails ### Troubleshooting try unquoted insert -- fails unixodbc+libmaodbc

[sr-dev] git:master:40b73521: rtpengine: optional ping parameter for rpc reload command

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 40b735216c610cae2da5b0758af31b1d3ade4731 URL: https://github.com/kamailio/kamailio/commit/40b735216c610cae2da5b0758af31b1d3ade4731 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-02-01T21:38:25+01:00 rtpengine: optional

[sr-dev] git:master:49bc5b26: rtpengine: new modparam to disable pinging rtpengines at startup

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 49bc5b266dad33e418e8895e9ed7ead46e254016 URL: https://github.com/kamailio/kamailio/commit/49bc5b266dad33e418e8895e9ed7ead46e254016 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-02-01T21:38:25+01:00 rtpengine: new

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Adding a few more details, previous comment was done on mobile, typing there on the web form is not the easiest. I think that log_file would be a candidate for the name of a module that writes all the logs in a file, similar to log_custom that sends all the log to an udp target. Then having a

[sr-dev] git:master:4c144ac1: file_out: small doc adaptions

2024-02-01 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 4c144ac1ad40008b5bd9396aa18d7630145b4c4c URL: https://github.com/kamailio/kamailio/commit/4c144ac1ad40008b5bd9396aa18d7630145b4c4c Author: Henning Westerholt Committer: Henning Westerholt Date: 2024-02-01T19:22:53Z file_out: small doc adaptions ---

[sr-dev] git:master:df3d1e5c: file_out: use name instead of index for file_out function parameter

2024-02-01 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: df3d1e5cb80b7a6ac6ce93b582352aaa8e6fd369 URL: https://github.com/kamailio/kamailio/commit/df3d1e5cb80b7a6ac6ce93b582352aaa8e6fd369 Author: Xenofon Karamanos Committer: Henning Westerholt Date: 2024-02-01T19:41:22Z file_out: use name instead of index for

[sr-dev] git:master:6478ac00: file_out: adjust syntax of examples to standard

2024-02-01 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 6478ac00e9bf1180092010b0df4656630d4550c2 URL: https://github.com/kamailio/kamailio/commit/6478ac00e9bf1180092010b0df4656630d4550c2 Author: Henning Westerholt Committer: Henning Westerholt Date: 2024-02-01T19:33:38Z file_out: adjust syntax of examples to

[sr-dev] git:master:a6892009: file_out: fix error in XML include for README

2024-02-01 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: a6892009361ceff1475b568a2317b5d8a7c889cc URL: https://github.com/kamailio/kamailio/commit/a6892009361ceff1475b568a2317b5d8a7c889cc Author: Henning Westerholt Committer: Henning Westerholt Date: 2024-02-01T19:25:12Z file_out: fix error in XML include for

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Henning Westerholt via sr-dev
Merged it like this for now as the freeze is coming up * smaller refactorings will be done afterwards (use string in function for names with internal matching, make worker sleep also configurable * a round of tests has been done, but it will be certainly tested more in the next days -- Reply

[sr-dev] git:master:dd5c9a52: file_out: Module to log custom strings to files (GH #3741)

2024-02-01 Thread GitHub via sr-dev
Module: kamailio Branch: master Commit: dd5c9a5204eb946e731550a0ee7f3046c7065515 URL: https://github.com/kamailio/kamailio/commit/dd5c9a5204eb946e731550a0ee7f3046c7065515 Author: Xenofon Karamanos Committer: GitHub Date: 2024-02-01T18:15:17+01:00 file_out: Module to log custom strings to

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Henning Westerholt via sr-dev
Merged #3741 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3741#event-11673226574 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Ovidiu Sas via sr-dev
How about `f_print` or `file_print`? In the end, it doesn't really matter, but `file_out` doesn't seem to be very intuitive ... or maybe that's just me :) Thanks for contributing this, it is a nice addition! -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Henning Westerholt via sr-dev
Ok, keep it like this then, no special preference from our side. :-) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921712262 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Ovidiu Sas via sr-dev
If performance is crucial, we can keep the index as a first parameter for the `file_out` function and we can change the definition of the `file_out` modparam: ``` modparam("file_out", "base_filename", "0:accounting") modparam("file_out", "base_filename", "1:missed_calls") ``` Populate slot `0`

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
I would not recommend using the word `log` in the name. It has nothing to do wit the internal logging frawork. The module is purely writings text to a file. The core module has basic similar functionality, those functions are not related to logging and this module should also keep away from

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Henning Westerholt via sr-dev
Thanks for the feedback as well @ovidiusas. The name file_log sounds also good. Regarding the use of an actual file name, its a good idea and can be probably done without performance impact with a fixup function. We will look into that. I would merge the module manually in some hours (to do

[sr-dev] Re: [kamailio/kamailio] TLS Module Regression (ee key too small) (Issue #3737)

2024-02-01 Thread Tyler Moore via sr-dev
Sounds like the code path that is causing the error is not being run. Is that on Debian 12? Try with the following tls.cfg: ``` [server:default] method = TLSv1.2+ verify_certificate = yes require_certificate = yes private_key = /etc/ssl/private/dsiprouter-key.pem certificate =

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Xenofon Karamanos via sr-dev
@miconda Thanks for the feedback, fixed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921623583 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Xenofon Karamanos via sr-dev
@xkaraman pushed 2 commits. ae4752366d5a558c54461ca86cdabbd3c3e13f14 file_out: Add copyright 7d08b018e5e54b998366b704c1d82f6c1ce643e4 file_out: Refactor to mach naming conventions -- View it on GitHub:

[sr-dev] Re: [kamailio/kamailio] TLS Module Regression (ee key too small) (Issue #3737)

2024-02-01 Thread space88man via sr-dev
Hmmm ... not reproducible here kamailio version 5.7.4 (x86_64/linux) kamcmd tls.reload leads to ``` 7(126739) INFO: tls [tls_domain.c:371]: ksr_tls_fill_missing(): TLSc: ca_path='(null)' 7(126739) INFO: tls [tls_domain.c:378]: ksr_tls_fill_missing(): TLSc: crl='(null)' 7(126739) INFO: tls

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Ovidiu Sas via sr-dev
How about `f_log` or `file_log` instead of `file_out`? Also, the first parameter of `file_out` function seems to be an index to the defined filenames. If the order of the `file_out` modparams is changed, then the script has to be updated. It would be more intuitive to use the actual filename

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Henning Westerholt via sr-dev
Thanks for the feedback, the copyright will be added uniformly, and also extend the prefix, sure. Then lets keep the file_out name for now until somebody else has a better idea. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
I have no suggesting about a better name right now, I can think about. Probably `log_` prefix is not suitable, because it does not divert all the log messages like log_custom. Otherwise upon a quick look, some files are missing the copyright at the top. And I would suggest to add prefix

[sr-dev] Re: [kamailio/kamailio] TLS Module Regression (ee key too small) (Issue #3737)

2024-02-01 Thread Tyler Moore via sr-dev
@space88man I shared a link below with an example key/cert pair from an ephemeral VM. I can provide access to that VM for testing if needed as well. https://drive.google.com/drive/folders/1255E1iSUKaKbElwDsC8o3qsh6YTN5jrJ?usp=drive_link -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] 5.7 db modules: init libssl in a thread (PR #3740)

2024-02-01 Thread space88man via sr-dev
> I of course also appreciate the work @space88man put here into that. Maybe I > am wrong, but right now the db_* modules in stable branches are not using the > pthread approach. My question was about if its really necessary to apply this > pthread logic to the DB modules. If the db_* modules

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Henning Westerholt via sr-dev
@miconda any suggestions regarding the name? Maybe going for the existing "log_" prefix, like log_file, log_file_out or similar? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921450975 You are receiving this because you are

[sr-dev] [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

2024-02-01 Thread Xenofon Karamanos via sr-dev
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] [kamailio/kamailio] db modules: init libssl in a thread (PR #3739)

2024-02-01 Thread space88man via sr-dev
Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing

[sr-dev] Build failed in Jenkins: kamailiodev-nightly-binaries ยป amd64,xenial #2588

2024-02-01 Thread kamailio--- via sr-dev
See Changes: -- [...truncated 1.44 MB...] Makefile.defs defs skipped Makefile.defs defs skipped gcc -fPIC -DPIC -funroll-loops

[sr-dev] git:master:ff94b5a6: influxdbc: added functions to push string and double values

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: ff94b5a691c525ed5687ad76bbf5436a8d877768 URL: https://github.com/kamailio/kamailio/commit/ff94b5a691c525ed5687ad76bbf5436a8d877768 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-02-01T13:49:17+01:00 influxdbc: added

[sr-dev] git:master:f0ef9d29: Makefile.groups: added influxdbc module to extra group

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: f0ef9d29e8736e7eb7e7e2c62485704d3506fbdd URL: https://github.com/kamailio/kamailio/commit/f0ef9d29e8736e7eb7e7e2c62485704d3506fbdd Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-02-01T13:49:17+01:00 Makefile.groups:

[sr-dev] Re: Freezing development for 5.8.x series

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Hello, short reply to refresh on freezing plan and bump the message at the top for everyone. Cheers, Daniel On 30.01.24 08:16, Daniel-Constantin Mierla wrote: > Hello, > > I propose to aim freezing the development for 5.8.x series at the end of > the 1st of February 2024 (Thursday). > > New

[sr-dev] git:master:4efd1fc3: p_usrloc: Add new modparam 'preload'

2024-02-01 Thread Stefan-Cristian Mititelu via sr-dev
Module: kamailio Branch: master Commit: 4efd1fc33ceb5dc33b01020968b0d7281e902d1f URL: https://github.com/kamailio/kamailio/commit/4efd1fc33ceb5dc33b01020968b0d7281e902d1f Author: Stefan-Cristian Mititelu Committer: Stefan-Cristian Mititelu Date: 2024-02-01T14:00:17+02:00 p_usrloc: Add new

[sr-dev] Re: [kamailio/kamailio] 5.7 db modules: init libssl in a thread (PR #3740)

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Well, that's the problem actually, because the db module can use tls if, for example, connection to MySQL/MariaDB is done over TLS. That was reported for db_unixodbc when connecting to Microsoft SQL Server via TLS. Any other module that eventually ends up using libssl3 though chain of

[sr-dev] Re: [kamailio/kamailio] 5.7 db modules: init libssl in a thread (PR #3740)

2024-02-01 Thread Henning Westerholt via sr-dev
I of course also appreciate the work @space88man put here into that. Maybe I am wrong, but right now the db_* modules in stable branches are not using the pthread approach. My question was about if its really necessary to apply this pthread logic to the DB modules. If the db_* modules are not

[sr-dev] Re: [kamailio/kamailio] 5.7 db modules: init libssl in a thread (PR #3740)

2024-02-01 Thread Daniel-Constantin Mierla via sr-dev
Unfortunately adapting to work properly with changes brought by libssl3+ was not easy, but it might not be a simpler way for avoiding those random crashes. I really appreciate the time and effort @space88man spent on it. This backported PR is not doing any fundamental change, it just makes