This issue is stale because it has been open 6 weeks with no activity. Remove
stale label or comment or this will be closed in 2 weeks.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3752#issuecomment-2019278765
You are receiving this because
@ovidiusas pushed 1 commit.
5d14ddd277394b4d7fad6fc5bdc284bb4bfa68bf xhttp_prom: rename module parameter
to xhttp_prom_pkg_stats
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3793/files/07c82c46ff0900ba5fe57fb79e79408925b340d6..5d14ddd277394b4d7fad6fc5bdc284bb4bfa68bf
You
@ovidiusas pushed 2 commits.
5c66426a1380fbba7181956c43b341c96701d3b7 kex: clang format
07c82c46ff0900ba5fe57fb79e79408925b340d6 xhttp_prom: clang format
--
View it on GitHub:
Module: kamailio
Branch: master
Commit: 14dc277e29a170b9ac51e7dda07fa25cbd9be048
URL:
https://github.com/kamailio/kamailio/commit/14dc277e29a170b9ac51e7dda07fa25cbd9be048
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-03-25T23:25:19+01:00
db_mysql: right
Module: kamailio
Branch: master
Commit: da3d6e9a74b63fdb7b1c4063d6be017f1ce42bea
URL:
https://github.com/kamailio/kamailio/commit/da3d6e9a74b63fdb7b1c4063d6be017f1ce42bea
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-03-25T23:07:55+01:00
db_mysql:
I haven't looked at code, but if `xhttp_prom_stats` cannot be easily reused,
then at least a shorter name for modparam has to be found,
`xhttp_prom_pkgmem_stats_enabled` is really long and looking rather odd.
Usually private memory is referred simply as `pkg`, not `pkgmem`, also
`enabled`
Another reason for implementing the pkg mem via a new parameter was related to
the fact the pkg mem stats are not available via the `get_statistics` mi
command. The idea was to mirror the mi layout over the xhttp_prometheus control.
--
Reply to this email directly or view it on GitHub:
I think it's better to control the pkg mem statistics via a parameter.
If the admin want's the pkg mem stats to be available but the kex module is
loaded after the xhttp_prom, the pkg mem stats won't be available which will
lead to confusion. Also, this will keep the existing behavior untouched.
Thanks for the PR. Two comments:
- the code format checker seems to fail, could you please check with
clang-format and update if necessary?
- you introduced a new parameter "xhttp_prom_pkgmem_stats_enabled", what about
just checking during startup if the kex module is available, if yes enable
Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
Checklist:
- [ ] PR should be backported to stable branches
Module: kamailio
Branch: master
Commit: dd221a6e5162838b979fd38ffdfb750663aef869
URL:
https://github.com/kamailio/kamailio/commit/dd221a6e5162838b979fd38ffdfb750663aef869
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-03-25T09:38:02+01:00
keepalive: reformat
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
12 matches
Mail list logo
