[sr-dev] git:master:18e4d38e: auth: export auth_algorithm(...) to kemi

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 18e4d38e4d57ce88cbe16eec4cfb2a5a1b5554a4 URL: https://github.com/kamailio/kamailio/commit/18e4d38e4d57ce88cbe16eec4cfb2a5a1b5554a4 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-14T18:13:04+02:00 auth: export

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
Closed #3849. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#event-12804750240 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
Merged manually! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110591764 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:3763e9c8: auth: new function auth_algorithm(...) to dynamically override algorithm

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 3763e9c826640402c798d4581d0b2f1b13e4519b URL: https://github.com/kamailio/kamailio/commit/3763e9c826640402c798d4581d0b2f1b13e4519b Author: Juha Heinanen Committer: Daniel-Constantin Mierla Date: 2024-05-14T17:52:29+02:00 auth: new function

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
If you want to test README generation locally, then you are missing some dockbook-relate packages, likely `docbook-xsl`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110568295 You are receiving this because you are subscribed

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
The README must not be regenerated locally and part of the commit, it is going to be generated on server and pushed to git repository by a cron job. One can generate readme locally only for checking it if it is correct, but then reverted before committing. Of course, if one pushed a

[sr-dev] Re: TLS.reload and memory usage of SSL_CTX structs

2024-05-14 Thread Daniel-Constantin Mierla via sr-dev
issues/3823> > Description We are using Kamailio 5.7.4 on Debian 12 (from > http://deb.kamailio.org/kamailio57) with rtpengine as an Edgeproxy for > our clients. The instance terminates SIP/TLS (with Cliencertificate... > github.com > > > > ___

[sr-dev] Re: [kamailio/kamailio] p_usrloc: use a global all_columns variable in db_load* functions (PR #3845)

2024-05-10 Thread Daniel-Constantin Mierla via sr-dev
If the array is used only in that file, I would suggest to make it static and maybe it would be also good rename it to p_usrloc_columns (or similar) to have the module prefix in the name, being a global variable. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] possible memory corruption in sipcapture module (Issue #3835)

2024-05-10 Thread Daniel-Constantin Mierla via sr-dev
Can you try with master branch or the patch from the commit references above? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3835#issuecomment-2104391186 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] git:master:d1f377ff: sipcapture: use local static buffers for ip address and port

2024-05-10 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: d1f377ff23f491bfd5162cb7bf510759440dd8e5 URL: https://github.com/kamailio/kamailio/commit/d1f377ff23f491bfd5162cb7bf510759440dd8e5 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-10T12:45:25+02:00 sipcapture: use local

[sr-dev] git:master:9b087fd6: tcpops: reformat exported structures

2024-05-10 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 9b087fd618ab6c5cbd6a29c352b09c7198f1b594 URL: https://github.com/kamailio/kamailio/commit/9b087fd618ab6c5cbd6a29c352b09c7198f1b594 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-10T08:17:17+02:00 tcpops: reformat

[sr-dev] Proposing 6.0.x for next stable release series

2024-05-08 Thread Daniel-Constantin Mierla via sr-dev
to listen on large number on consecutive ports. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com ___ Kamailio (SER) - Development

[sr-dev] Kamailio v5.7.5 Released

2024-05-08 Thread Daniel-Constantin Mierla via sr-dev
, Debian/Ubuntu packages will be available soon as well. Note that 5.7.x is currently the previous stable release series, the latest is 5.8.x and v5.8.1 was released on April 3, 2024. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com

[sr-dev] git:5.7:58499a33: ChangeLog: content updated for v5.7.5

2024-05-08 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: 58499a330510d157d59a9103576021fd7407e860 URL: https://github.com/kamailio/kamailio/commit/58499a330510d157d59a9103576021fd7407e860 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-08T09:08:04+02:00 ChangeLog: content

[sr-dev] git:5.7:b0caec01: Makefile.defs: version set to 5.7.5

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: b0caec0143187f487b24d37376e93b05340db1ad URL: https://github.com/kamailio/kamailio/commit/b0caec0143187f487b24d37376e93b05340db1ad Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-08T07:58:49+02:00 Makefile.defs: version

[sr-dev] git:5.7:7590ff14: pkg: deb specs updated for v5.7.4

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: 7590ff14e0c9bcab17a298f806f4da8a564c83a8 URL: https://github.com/kamailio/kamailio/commit/7590ff14e0c9bcab17a298f806f4da8a564c83a8 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-08T07:57:26+02:00 pkg: deb specs updated

[sr-dev] git:5.7:aab0f988: pkg: version set to 5.7.5 for rpms and alpine specs

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: aab0f988b6c69266b54dc2d92c6c9f739ef6805e URL: https://github.com/kamailio/kamailio/commit/aab0f988b6c69266b54dc2d92c6c9f739ef6805e Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-08T07:56:41+02:00 pkg: version set

[sr-dev] Re: Releasing v5.7.5

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
. Cheers, Daniel On 03.05.24 09:28, Daniel-Constantin Mierla wrote: > Hello, > > I am considering to release Kamailio v5.7.5 (out of branch 5.7) on > Wednesday, May 8, 2024. If anyone is aware of issues not yet on the bug > tracker, report them there asap in order to have

[sr-dev] git:5.7:d88542f2: etc/kamailio.cfg: remove executable flag

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: d88542f235af01d63c555673bebbc0c64ea825e2 URL: https://github.com/kamailio/kamailio/commit/d88542f235af01d63c555673bebbc0c64ea825e2 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-08T06:59:08+02:00 etc/kamailio.cfg: remove

[sr-dev] git:5.8:ba7a4901: etc/kamailio.cfg: remove executable flag

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.8 Commit: ba7a4901268493f5432d5efd59d6dbd7b422742f URL: https://github.com/kamailio/kamailio/commit/ba7a4901268493f5432d5efd59d6dbd7b422742f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-08T06:59:31+02:00 etc/kamailio.cfg: remove

[sr-dev] git:master:1535031a: etc/kamailio.cfg: remove executable flag

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 1535031a6c992c23270050793b23d290a631b684 URL: https://github.com/kamailio/kamailio/commit/1535031a6c992c23270050793b23d290a631b684 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-08T06:59:23+02:00 etc/kamailio.cfg

[sr-dev] git:5.8:383a81bb: tcpops: note about execution of event routes by TCP main process

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.8 Commit: 383a81bb9d81e06ab9da99cdaa3def3b63028040 URL: https://github.com/kamailio/kamailio/commit/383a81bb9d81e06ab9da99cdaa3def3b63028040 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-07T19:34:35+02:00 tcpops: note about

[sr-dev] git:master:be9af338: tcpops: note about execution of event routes by TCP main process

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: be9af338e3afdab1045cdd7c30a72a9ecddcb680 URL: https://github.com/kamailio/kamailio/commit/be9af338e3afdab1045cdd7c30a72a9ecddcb680 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-07T19:32:39+02:00 tcpops: note about

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Indeed `sql_query_async(...)` makes db connection checks, failing in this case. The db_mysql API function for async query would need only DB URL as a string. I will try to see what alternative can be done for sqlops. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Looking at the code, `sql_query_async(...)` should work, do you get exactly the same error message as with `sql_query()`? As for the use of async module, can you use the `async_task_data()` or `async_task_group_data()` functions? The other ones are intended for processing of SIP requests

[sr-dev] git:5.7:5566647a: ctl: info log on ECONNRESET (connection reset by peer)

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: 5566647a85f23e753774fa4c87e213c2fbb7b317 URL: https://github.com/kamailio/kamailio/commit/5566647a85f23e753774fa4c87e213c2fbb7b317 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-07T17:31:41+02:00 ctl: info log

[sr-dev] git:5.7:64421e2d: core: parse/contact: jump to error on too many contacts

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: 64421e2d4ed48e4a77cd997e389ae4a5225b40ab URL: https://github.com/kamailio/kamailio/commit/64421e2d4ed48e4a77cd997e389ae4a5225b40ab Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-07T17:31:27+02:00 core: parse/contact

[sr-dev] git:5.7:ff5d1e73: core: spelling fix in comment and log message

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: ff5d1e73cd04ca84e423cd9efbec4014e9dbc2e4 URL: https://github.com/kamailio/kamailio/commit/ff5d1e73cd04ca84e423cd9efbec4014e9dbc2e4 Author: Henning Westerholt Committer: Daniel-Constantin Mierla Date: 2024-05-07T17:30:08+02:00 core: spelling fix in comment

[sr-dev] git:5.7:49135f37: core: parser/contact - add limit for max number of contacts

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: 49135f37d94aaf49a1c6b6a47bdc5a80bd3e5028 URL: https://github.com/kamailio/kamailio/commit/49135f37d94aaf49a1c6b6a47bdc5a80bd3e5028 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-07T17:31:14+02:00 core: parser/contact

[sr-dev] git:5.7:65c8761d: sipcapture: docs - fix default value for parameter

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: 65c8761d9b04d01d0609b09c7ed75c9518f72d77 URL: https://github.com/kamailio/kamailio/commit/65c8761d9b04d01d0609b09c7ed75c9518f72d77 Author: Jannik <40364587+volkl...@users.noreply.github.com> Committer: Daniel-Constantin Mierla Date: 2024-05-07T17:30:50

[sr-dev] git:5.7:d9e63ac9: ctl: removed level and function names from log messages

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: d9e63ac912c1f0b3ec71611516ea3e52206b6edf URL: https://github.com/kamailio/kamailio/commit/d9e63ac912c1f0b3ec71611516ea3e52206b6edf Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-07T17:31:35+02:00 ctl: removed level

[sr-dev] git:5.7:ac56db7f: uid_auth_db: spelling fix in documentation

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: ac56db7fab9d1157e89a6daf81915e3058f7178c URL: https://github.com/kamailio/kamailio/commit/ac56db7fab9d1157e89a6daf81915e3058f7178c Author: Henning Westerholt Committer: Daniel-Constantin Mierla Date: 2024-05-07T17:30:16+02:00 uid_auth_db: spelling fix

[sr-dev] git:5.7:45fd99f5: core: parser/contact - basic validation tests for contact uri

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.7 Commit: 45fd99f53643b56bce65eb9d603a5b81059aa21d URL: https://github.com/kamailio/kamailio/commit/45fd99f53643b56bce65eb9d603a5b81059aa21d Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-07T17:31:21+02:00 core: parser/contact

[sr-dev] git: new commits in branch 5.8

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
/1dd7c4038eb9a0c7eec506994a58a56d04e6cee5 Author: Daniel-Constantin Mierla Date: 2024-05-07T17:06:14+02:00 ims_usrloc_scscf: reformat exported structures (cherry picked from commit 15d859e1e96552fca2708cf56047021beae29711) - URL: https://github.com/kamailio/kamailio/commit

[sr-dev] git:master:65bafaff: ctl: removed level and function names from log messages

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 65bafaffd6bcfebc508b774cfbb78120e68bb3f0 URL: https://github.com/kamailio/kamailio/commit/65bafaffd6bcfebc508b774cfbb78120e68bb3f0 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-07T16:49:49+02:00 ctl: removed level

[sr-dev] git:master:446c75e0: ctl: info log on ECONNRESET (connection reset by peer)

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 446c75e0e2194b6e42d768d2e3c79b5f0222905f URL: https://github.com/kamailio/kamailio/commit/446c75e0e2194b6e42d768d2e3c79b5f0222905f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-07T16:55:24+02:00 ctl: info log

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Connection close event is executed from TCP main process, which likely has no SQL connection open. Till some point in the past, connection close event was triggered from a few places (from tcp worker processes), but actually it was not done for all cases when the connections were closed, some

[sr-dev] Re: [kamailio/kamailio] Memory usage increases everytime tls.reload is executed (Issue #3823)

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Probably this part has to be reviewed ... first the tls reload was initially designed to be done rather rarely, when the certificates expires. The CRL feature was also not much in use, at least in what I could experience so far, most of the deployments are with server-side only certificates.

[sr-dev] git:master:6cb26e9e: core: cfg socket struct - option to bind to a range of sockets

2024-05-07 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 6cb26e9e7045eeec9c08867fe264c71c697bb9d8 URL: https://github.com/kamailio/kamailio/commit/6cb26e9e7045eeec9c08867fe264c71c697bb9d8 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-06T18:40:41+02:00 core: cfg socket

[sr-dev] Re: [kamailio/kamailio] possible memory corruption in sipcapture module (Issue #3835)

2024-05-06 Thread Daniel-Constantin Mierla via sr-dev
@adubovikov: as I see it right now, by replicating at SIP level (e.g., via sip dump) to another system, the original source ip/destination IP are lost in the receiving system. They can eventually be added as custom headers. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: git:master:61660322: core: new udp receiver mode - one multi-threaded process

2024-05-06 Thread Daniel-Constantin Mierla via sr-dev
On 05.05.24 11:30, Olle E. Johansson wrote: > > >> On 4 May 2024, at 20:19, Daniel-Constantin Mierla via sr-dev >> wrote: >> >> core: new udp receiver mode - one multi-threaded  process >> >> - activated with udp_receiver_mode=1 >> - one process is

[sr-dev] git:master:2503a6fa: core: udp server - lookup async task group for multi thread receiver

2024-05-06 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 2503a6fa6d45bb44ae390819636ad96269029b75 URL: https://github.com/kamailio/kamailio/commit/2503a6fa6d45bb44ae390819636ad96269029b75 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-06T07:56:28+02:00 core: udp server

[sr-dev] git:master:f8b08d01: core: async task - functions to find group and send tasks

2024-05-05 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: f8b08d01a98be3e5c823af769e20f0ccee1af629 URL: https://github.com/kamailio/kamailio/commit/f8b08d01a98be3e5c823af769e20f0ccee1af629 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-05T19:53:14+02:00 core: async task

[sr-dev] git:master:f69b22d4: core: parse/contact: jump to error on too many contacts

2024-05-04 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: f69b22d44cb5abc803c2b58790dd33f2310c1c59 URL: https://github.com/kamailio/kamailio/commit/f69b22d44cb5abc803c2b58790dd33f2310c1c59 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-04T20:18:51+02:00 core: parse/contact

[sr-dev] git:master:61660322: core: new udp receiver mode - one multi-threaded process

2024-05-04 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 61660322ad07be24cdc98c0debb01119960124ea URL: https://github.com/kamailio/kamailio/commit/61660322ad07be24cdc98c0debb01119960124ea Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-04T20:18:51+02:00 core: new udp

[sr-dev] git:master:d6b0beb5: core: parser/contact - add limit for max number of contacts

2024-05-03 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: d6b0beb5a219ae57a62e9e7201a6ec1fe66e5a96 URL: https://github.com/kamailio/kamailio/commit/d6b0beb5a219ae57a62e9e7201a6ec1fe66e5a96 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-03T14:36:29+02:00 core: parser/contact

[sr-dev] git:master:fc52a543: core: parser/contact - basic validation tests for contact uri

2024-05-03 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: fc52a54370c085d6fa951da876eee99580677922 URL: https://github.com/kamailio/kamailio/commit/fc52a54370c085d6fa951da876eee99580677922 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-03T14:57:47+02:00 core: parser/contact

[sr-dev] Releasing v5.7.5

2024-05-03 Thread Daniel-Constantin Mierla via sr-dev
Hello, I am considering to release Kamailio v5.7.5 (out of branch 5.7) on Wednesday, May 8, 2024. If anyone is aware of issues not yet on the bug tracker, report them there asap in order to have a better chance to be fixed. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com

[sr-dev] git:master:53e1a29c: pua: check if local requests are dropped and free the param

2024-05-02 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 53e1a29c265df1489c9bd91deddc0719f8ca2092 URL: https://github.com/kamailio/kamailio/commit/53e1a29c265df1489c9bd91deddc0719f8ca2092 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-02T09:27:41+02:00 pua: check if local

[sr-dev] git:master:f1baf7dd: nghttp2: set the data field for event route

2024-05-02 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: f1baf7dd48c4ccb8d2d0ab0b24547f2793bb8588 URL: https://github.com/kamailio/kamailio/commit/f1baf7dd48c4ccb8d2d0ab0b24547f2793bb8588 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-02T10:15:48+02:00 nghttp2: set the data

[sr-dev] git:master:ebd1c6c7: tm: cb_flags made unsigned for uac_req

2024-05-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: ebd1c6c75a1b832ce85d576aad134b99d47b5738 URL: https://github.com/kamailio/kamailio/commit/ebd1c6c75a1b832ce85d576aad134b99d47b5738 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-01T06:07:26+02:00 tm: cb_flags made

[sr-dev] git:master:68624c2d: pv_headers: print also the new TMCB_LOCAL_REQUEST_DROP in debug function

2024-05-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 68624c2da093ab789d4e8d35df65ef1bce024bca URL: https://github.com/kamailio/kamailio/commit/68624c2da093ab789d4e8d35df65ef1bce024bca Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-01T06:08:28+02:00 pv_headers: print

[sr-dev] git:master:ee06666c: tm: free new buffer on drop for local requests

2024-05-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: ee0c43d96029315dae7618e10d381265a85a URL: https://github.com/kamailio/kamailio/commit/ee0c43d96029315dae7618e10d381265a85a Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-01T05:28:18+02:00 tm: free new buffer

[sr-dev] git:master:00aac8d4: uac: check if local requests are dropped and free the param

2024-05-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 00aac8d48370fac356eecff535835d918c631cc5 URL: https://github.com/kamailio/kamailio/commit/00aac8d48370fac356eecff535835d918c631cc5 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-01T07:00:58+02:00 uac: check if local

[sr-dev] git:master:f5da773c: tm: cb flag to mark local uac on request drop

2024-05-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: f5da773c5fa29edbf9d0e65a83a62f495928ddec URL: https://github.com/kamailio/kamailio/commit/f5da773c5fa29edbf9d0e65a83a62f495928ddec Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-01T05:57:46+02:00 tm: cb flag to mark

[sr-dev] git:master:d12fc310: presence: check if the local notify was dropped in event route

2024-05-01 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: d12fc31056cb37aac347ec05f9ada7bafa5f52de URL: https://github.com/kamailio/kamailio/commit/d12fc31056cb37aac347ec05f9ada7bafa5f52de Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-05-01T06:20:43+02:00 presence: check

[sr-dev] Re: Enquiry about N5 interface implementation

2024-05-01 Thread Daniel-Constantin Mierla via sr-dev
an conduct our testing as well. > > Hoping for a timely response and update, > Thanks and regards, > Vaibhav. > > ___ > Kamailio (SER) - Development Mailing List > To unsubscribe send an email to sr-dev-le...@lists.kamailio.or

[sr-dev] git:master:60d2ab64: ims_ipsec_pcscf: cascade on options to get the uri for fill_contact()

2024-04-30 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 60d2ab6464657abf38136a771c297c6f5536e27a URL: https://github.com/kamailio/kamailio/commit/60d2ab6464657abf38136a771c297c6f5536e27a Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-30T10:19:35+02:00 ims_ipsec_pcscf

[sr-dev] Re: [kamailio/kamailio] usrloc: delete location_attrs in db_only mode on delete_urecord (PR #3827)

2024-04-29 Thread Daniel-Constantin Mierla via sr-dev
Thanks, looks ok imo. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3827#issuecomment-2083301903 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: fix uninitialized access of memory, minor refactors (PR #3787)

2024-04-29 Thread Daniel-Constantin Mierla via sr-dev
Looks ok for merging, imo. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3787#issuecomment-2082732228 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:48dab490: ims_ipsec_pcscf: handle tls for replies

2024-04-29 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 48dab490965fa7f2f7200d95edd7dbb1407b2536 URL: https://github.com/kamailio/kamailio/commit/48dab490965fa7f2f7200d95edd7dbb1407b2536 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-29T10:08:29+02:00 ims_ipsec_pcscf

[sr-dev] git:master:575b17d2: ims_ipsec_pcscf: docs updated for ipsec_forward() flags

2024-04-29 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 575b17d23cd5fa060f775bc56b42c735048bc849 URL: https://github.com/kamailio/kamailio/commit/575b17d23cd5fa060f775bc56b42c735048bc849 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-29T06:46:56+02:00 ims_ipsec_pcscf: docs

[sr-dev] git:master:ab261540: ims_ipsec_pcscf: decouple IPSEC_FORWARD_USEVIA and IPSEC_TCPPORT_UEC for requests

2024-04-29 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: ab261540d656ed456bac8876f77f940457a9baf6 URL: https://github.com/kamailio/kamailio/commit/ab261540d656ed456bac8876f77f940457a9baf6 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-29T06:32:07+02:00 ims_ipsec_pcscf

[sr-dev] git:master:f7f93828: ims_ipsec_pcscf: updated comments for ipsec_forward() flags

2024-04-29 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: f7f93828993b5975dfe5f26ad63ba6c489aa69f7 URL: https://github.com/kamailio/kamailio/commit/f7f93828993b5975dfe5f26ad63ba6c489aa69f7 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-29T06:49:47+02:00 ims_ipsec_pcscf

[sr-dev] git: new commits in branch 5.7

2024-04-28 Thread Daniel-Constantin Mierla via sr-dev
- URL: https://github.com/kamailio/kamailio/commit/fb685a8bd5d5e34edde44614f313cbb5c27b3c25 Author: Daniel-Constantin Mierla Date: 2024-04-29T05:02:09+02:00 jansson: declare variables at the beginning of blocks (cherry picked from commit a2bff77c3f7bfee8dae90c3ef20522d480f2e14d) - URL

[sr-dev] git:master:85589470: ims_registrar_scscf: init variable to fix analyzer warning

2024-04-28 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 8558947034f16b162c15eda39d18f5f5df4ef562 URL: https://github.com/kamailio/kamailio/commit/8558947034f16b162c15eda39d18f5f5df4ef562 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-28T23:29:22+02:00 ims_registrar_scscf

[sr-dev] Re: [kamailio/kamailio] utils/kamctl: make root host/port configurable (PR #3830)

2024-04-28 Thread Daniel-Constantin Mierla via sr-dev
Merged #3830 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3830#event-12635894468 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] modules/statsd: ensure statsd failures do not stop execution (PR #3819)

2024-04-28 Thread Daniel-Constantin Mierla via sr-dev
Merged #3819 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3819#event-12635898062 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:de23dc10: utils/kamctl: make root host/port configurable

2024-04-28 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: de23dc1035e4b885f45bc4150d282c26b294db64 URL: https://github.com/kamailio/kamailio/commit/de23dc1035e4b885f45bc4150d282c26b294db64 Author: Tyler Moore Committer: Daniel-Constantin Mierla Date: 2024-04-28T23:14:16+02:00 utils/kamctl: make root host/port

[sr-dev] Re: [kamailio/kamailio] utils/kamctl: make root host/port configurable (PR #3830)

2024-04-28 Thread Daniel-Constantin Mierla via sr-dev
Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3830#issuecomment-2081658460 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] modules/statsd: ensure statsd failures do not stop execution (PR #3819)

2024-04-28 Thread Daniel-Constantin Mierla via sr-dev
Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3819#issuecomment-2081658720 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:f0caa96e: phonenum: clang format cpp file

2024-04-27 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: f0caa96e7622c40200d22d730ca904f27e5fe752 URL: https://github.com/kamailio/kamailio/commit/f0caa96e7622c40200d22d730ca904f27e5fe752 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-27T08:46:17+02:00 phonenum: clang

[sr-dev] Re: [kamailio/kamailio] phonenum: add national number (PR #3820)

2024-04-27 Thread Daniel-Constantin Mierla via sr-dev
Merged #3820 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3820#event-12630642727 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:efffd1db: phonenum: add national number

2024-04-27 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: efffd1db25f2da411f53fdab4954c60c16c021ae URL: https://github.com/kamailio/kamailio/commit/efffd1db25f2da411f53fdab4954c60c16c021ae Author: Daniel Donoghue Committer: Daniel-Constantin Mierla Date: 2024-04-27T08:44:10+02:00 phonenum: add national number

[sr-dev] git:master:8506a6fe: ims_usrloc_scscf: enclose examples in dotted lines for better visibility

2024-04-26 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 8506a6fe781e6e0b0b1418f4087db50480db6b57 URL: https://github.com/kamailio/kamailio/commit/8506a6fe781e6e0b0b1418f4087db50480db6b57 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-26T14:35:22+02:00 ims_usrloc_scscf

[sr-dev] git:master:15d859e1: ims_usrloc_scscf: reformat exported structures

2024-04-26 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 15d859e1e96552fca2708cf56047021beae29711 URL: https://github.com/kamailio/kamailio/commit/15d859e1e96552fca2708cf56047021beae29711 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-26T14:24:16+02:00 ims_usrloc_scscf

[sr-dev] Re: [kamailio/kamailio] free_fixup functions in cmd_export_t are not called (Issue #3814)

2024-04-26 Thread Daniel-Constantin Mierla via sr-dev
What do you mean by both cases? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3814#issuecomment-2079404313 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio

[sr-dev] Re: [kamailio/kamailio] modules/statsd: ensure statsd failures do not stop execution (PR #3819)

2024-04-25 Thread Daniel-Constantin Mierla via sr-dev
@miconda commented on this pull request. > } static int ki_statsd_decr_with_labels(sip_msg_t *msg, str *key, str *labels) { - return statsd_count(key->s, "-1", labels->s); + return convert_result(statsd_count(key->s, "-1", labels->s)); +} + +static int convert_result(bool

[sr-dev] Re: [kamailio/kamailio] ERROR: [core/ppcfg.c:275]: pp_ifdef_level_error(): different number of preprocessor directives: 1 more #!if[n]def as #!endif (Issue #3826)

2024-04-25 Thread Daniel-Constantin Mierla via sr-dev
This tracker is used for reporting bugs in the C code. For asking questions about using Kamailio and its configuration file, use sr-us...@lists.kamailio.org mailing list. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] ERROR: [core/ppcfg.c:275]: pp_ifdef_level_error(): different number of preprocessor directives: 1 more #!if[n]def as #!endif (Issue #3826)

2024-04-25 Thread Daniel-Constantin Mierla via sr-dev
Closed #3826 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3826#event-12608573144 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] git:master:c0d80f9e: htable: added in operator for rm functions

2024-04-25 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: c0d80f9eb42b025802c4680f19d788d01497301a URL: https://github.com/kamailio/kamailio/commit/c0d80f9eb42b025802c4680f19d788d01497301a Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-25T13:53:31+02:00 htable: added

[sr-dev] git:master:39a2679f: htable: docs for in operator for remove functions

2024-04-25 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 39a2679fe165e34a225615ec32c58692fdcaf6a8 URL: https://github.com/kamailio/kamailio/commit/39a2679fe165e34a225615ec32c58692fdcaf6a8 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-25T14:00:40+02:00 htable: docs

[sr-dev] git:master:fe8f052c: tcpops: removed unused variable introduced recently

2024-04-25 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: fe8f052c29528b656062927626f9784b32b7c8f6 URL: https://github.com/kamailio/kamailio/commit/fe8f052c29528b656062927626f9784b32b7c8f6 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-25T13:49:58+02:00 tcpops: removed

[sr-dev] git:5.8:e76d755d: tcpops: removed unused variable introduced recently

2024-04-25 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: 5.8 Commit: e76d755de6482e51c9ddac5bba3834cb58ad79b2 URL: https://github.com/kamailio/kamailio/commit/e76d755de6482e51c9ddac5bba3834cb58ad79b2 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-25T13:50:44+02:00 tcpops: removed unused

[sr-dev] git: new commits in branch 5.8

2024-04-25 Thread Daniel-Constantin Mierla via sr-dev
s/management/security/encryption/#client-certificate-authentication (cherry picked from commit 6faa180661e799187eff3a498f8b13e96719fa92) - URL: https://github.com/kamailio/kamailio/commit/855c76780c4399d6d9881ce3c525a7df56e111c4 Author: Daniel-Constantin Mierla Date: 2024-04-25T13:31:5

[sr-dev] git:master:0ebfddd2: regex: reformat exported structures

2024-04-24 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 0ebfddd20b43396d602b4c68a88f7c2bc58ed211 URL: https://github.com/kamailio/kamailio/commit/0ebfddd20b43396d602b4c68a88f7c2bc58ed211 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-24T21:34:28+02:00 regex: reformat

[sr-dev] Re: [kamailio/kamailio] phonenum: add national number (PR #3820)

2024-04-24 Thread Daniel-Constantin Mierla via sr-dev
Thanks! I will merge once the CI/CD actions complete ok. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3820#issuecomment-2074301284 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] Kamailio 5.8 core dumps with regex module (Issue #3812)

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
Looked a bot over it and the `pcres` global was not allocated, by an assign to `*pcres` was done. On the other hand, I am not sure if it is enough, I guess the compiled regex has to be stored in shared memory and I cannot say it is done. Maybe @linuxmaniac can have more insights on it. With

[sr-dev] git:master:84517c14: regex: init globals for safer shutdown on failure

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 84517c14ca38a8371c67b858077a42019c2217a8 URL: https://github.com/kamailio/kamailio/commit/84517c14ca38a8371c67b858077a42019c2217a8 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-23T11:49:23+02:00 regex: init globals

[sr-dev] git:master:2cc62133: regex: allocate pcres array

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 2cc62133db4f6875f55e73e044f37dafbb2274c2 URL: https://github.com/kamailio/kamailio/commit/2cc62133db4f6875f55e73e044f37dafbb2274c2 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-23T12:08:30+02:00 regex: allocate pcres

[sr-dev] Re: [kamailio/kamailio] free_fixup functions in cmd_export_t are not called (Issue #3814)

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
I am not sure if they are executed at shut down, it was one of the purposes for fixup-free function, cleaning up at shut down, but this one was not pursued and it is rather tricky because it can be done mainly only for the main process, which is not doing anything at runtime. Also, it can slow

[sr-dev] Re: [kamailio/kamailio] Misleading source IP of 1.0.0.127 in event routes (Issue #3817)

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
Closed #3817 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3817#event-12572365377 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] Misleading source IP of 1.0.0.127 in event routes (Issue #3817)

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
This should be fixed by parsing the loopback ip instead of direct filling of ip addr fields. It will be backported. Reopen if still an issue. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3817#issuecomment-2071833806 You are receiving this

[sr-dev] git:master:66b3c04a: core: fmsg - parse loopback ip when initializing faked msg structure

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 66b3c04a9653425b1602c82dd2456a7eb7cf59d1 URL: https://github.com/kamailio/kamailio/commit/66b3c04a9653425b1602c82dd2456a7eb7cf59d1 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-23T11:19:30+02:00 core: fmsg - parse

[sr-dev] Re: [kamailio/kamailio] tcpops module event_route[tcp:closed] route block $conid is null (Issue #3767)

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
@liangbaolin: I pushed a few commits to address this one, last being f5c05a68ae72881ab0691bb8488112356fc67c79 Can you try with git master branch and see if ok? If yes, patches will be backported. -- Reply to this email directly or view it on GitHub:

[sr-dev] git:master:27e3b7f3: tcpops: reworked some debug messages

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 27e3b7f3f82957c6dc80f2ff89c40bdd87cecb81 URL: https://github.com/kamailio/kamailio/commit/27e3b7f3f82957c6dc80f2ff89c40bdd87cecb81 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-23T10:21:20+02:00 tcpops: reworked some

[sr-dev] git:master:f5c05a68: pv: use global tcp connection callback for event route on $conid

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: f5c05a68ae72881ab0691bb8488112356fc67c79 URL: https://github.com/kamailio/kamailio/commit/f5c05a68ae72881ab0691bb8488112356fc67c79 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-23T10:42:02+02:00 pv: use global tcp

[sr-dev] git:master:d114d117: core: tcp - set a global shortcut to tcp connection for event route

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: d114d11724dc4157e7e5809504531d26da6bcc57 URL: https://github.com/kamailio/kamailio/commit/d114d11724dc4157e7e5809504531d26da6bcc57 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-23T10:36:35+02:00 core: tcp - set

[sr-dev] git:master:11e7d71e: core: tcp - keep connection id on event route cb structure

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 11e7d71e5c2ee9428298658ed3b9a0f625d40f00 URL: https://github.com/kamailio/kamailio/commit/11e7d71e5c2ee9428298658ed3b9a0f625d40f00 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-04-23T10:19:29+02:00 core: tcp - keep

[sr-dev] Re: [kamailio/kamailio] Kamailio 5.6 (and 5.7) core dumps with uac_req_send() from uac module (Issue #3725)

2024-04-23 Thread Daniel-Constantin Mierla via sr-dev
Reopened #3725. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3725#event-12570750057 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

<    1   2   3   4   5   6   7   8   9   10   >