[sr-dev] [kamailio/kamailio] Siptrace: setting send_sock_name/send_sock_address is ineffective for tcp based transports (PR #3837)

2024-05-02 Thread Dennis via sr-dev
For tcp based transports it is need to set SND_F_FORCE_SOCKET flag before msg_send_buffer call, or duplicate will send from wrong addr/port. !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read:

[sr-dev] [kamailio/kamailio] dispatcher: refine documentation (PR #3783)

2024-03-11 Thread Dennis via sr-dev
- more clear documentation for the new ds_is_from_list flags !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-03-11 Thread Dennis via sr-dev
Hi, @miconda ! About the docs changes above, do i need to make a new PR, this one is closed ? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3699#issuecomment-1988089752 You are receiving this because you are subscribed to this thread. Message

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-02-26 Thread Dennis via sr-dev
Thansk for merging @miconda ! I wanted to offer a version of the documentation for flag 16 to make it more clear: If bit five is set, then try to find the most closest target from all dispatcher targets with the mandatory ip and combination of local socket, protocol, port. The weighted search

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-02-21 Thread Dennis via sr-dev
Hi ! Yes, i need to refine the docs, will try to do at this weekends. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3699#issuecomment-1957261250 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-31 Thread Dennis via sr-dev
> Your last comment does not clarify if a destination record matching (ip, > socket) has to be selected over one that matches (ip, port, proto). Can you > present the order of selection based on matching the values for ip, port, > proto or socket? The strictness are defined by the flags

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-26 Thread Dennis via sr-dev
Hi! Sorry, I was sick last week... > because of the flag for socket matching, record matching (ip, socket) is > selected. Is this the desired behavior. Yes, this is the desired behavior, because we can only have a target with an ip and socket like this (it seems to be a valid configuration):

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-12 Thread Dennis via sr-dev
> I meant for the case/flag DS_MATCH_FULLADDRSOCK: a destination record that > matches **only** the socket is selected against one that matches > address+port+proto. Using DS_MATCH_TRY_FULL ADDR SOCK, at least an ip must also be matched, and in this mode we do not interrupt the serach cycle,

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-12 Thread Dennis via sr-dev
> If I understand the code correctly, a destination record that matches only > the socket is selected against one that matches address/port/proto? Is it > like that and if yes, is it the expected result? Yes, it is a separate flag - DS_MATCH_SOCKET (8), it work like ds_is_from_list(-1,0), but

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-10 Thread Dennis via sr-dev
I have changed the flag name and added docs to xml. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3699#issuecomment-1884558285 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-10 Thread Dennis via sr-dev
@Den4t pushed 1 commit. 53ae14294f021ae615c0fae6ec9b48758d9a051e dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching -- View it on GitHub:

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-05 Thread Dennis via sr-dev
> I've not done any testing myself, but by my understanding the > DS_MATCH_STRICTEST flag is basically a flag to indicate it should not return > on the first match but scan through all. Then sort and return the one that is > matching one most criterias? Right, but not exactly, there is no

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-05 Thread Dennis via sr-dev
> Maybe DS_MATCH_FULLADDRSOCK. OK, i will change the flag name, need some time to think about adequate name, writing docs hope can help with this. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3699#issuecomment-1879191053 You are receiving

[sr-dev] [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-04 Thread Dennis via sr-dev
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a

[sr-dev] Re: [kamailio/kamailio] Fixed saving dialogs on shutdown that are already loaded at startup in db_mode 3 (PR #3688)

2023-12-26 Thread Dennis via sr-dev
Done -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3688#issuecomment-1869732914 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] Fixed saving dialogs on shutdown that are already loaded at startup in db_mode 3 (PR #3688)

2023-12-22 Thread Dennis via sr-dev
Some incorrect identation was found after initial commit, fixed in additional commits. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3688#issuecomment-1867912566 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] Fixed saving dialogs on shutdown that are already loaded at startup in db_mode 3 (PR #3688)

2023-12-22 Thread Dennis via sr-dev
@Den4t pushed 1 commit. 0c36a852d0b2300040ea32c32888d354a54dddec Update dlg_db_handler.c -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3688/files/78e270b3a8db48705d349771b7d155f237a04ca5..0c36a852d0b2300040ea32c32888d354a54dddec You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] Fixed saving dialogs on shutdown that are already loaded at startup in db_mode 3 (PR #3688)

2023-12-22 Thread Dennis via sr-dev
@Den4t pushed 1 commit. 78e270b3a8db48705d349771b7d155f237a04ca5 Update dlg_db_handler.c -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3688/files/d1699ab62ebc0aa62c4acb87bf496e64b16f67e4..78e270b3a8db48705d349771b7d155f237a04ca5 You are receiving this because you are

[sr-dev] [kamailio/kamailio] Fixed saving dialogs on shutdown that are already loaded at startup in db_mode 3 (PR #3688)

2023-12-22 Thread Dennis via sr-dev
…tartup when using db_mode 3 - The dialogs that loaded at startup are not saved in DB on shutdown, and so not loaded at restart, fixes issue #3669 !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read:

[sr-dev] Re: [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-21 Thread Dennis via sr-dev
I have tested all 3 DB modes with my latest modifications, the results look correct: ``` === Test mode 1 === modparam("dialog", "db_url", "sqlite:///etc/kamailio/sqlite.db") modparam("dialog", "db_mode", 1) # systemctl start kamailio # echo 'select "dlgs: "||count(*) from dialog'|sqlite3

[sr-dev] Re: [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-21 Thread Dennis via sr-dev
I have tested all 3 DB modes with my latest modifications, the results look correct: ``` === Test mode 1 === modparam("dialog", "db_url", "sqlite:///etc/kamailio/sqlite.db") modparam("dialog", "db_mode", 1) # systemctl start kamailio # echo 'select "dlgs: "||count(*) from dialog'|sqlite3

[sr-dev] Re: [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-21 Thread Dennis via sr-dev
> You should probably only do this if: > if(dlg_db_mode == DB_MODE_SHUTDOWN) { Yes, i missed it, will test all the db modes. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3669#issuecomment-1866163424 You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-20 Thread Dennis via sr-dev
I have fixed dialog saving with folowing change: https://github.com/Den4t/kamailio/commit/0ff12a0a0ab62123c7a37acb1c8f2f81d63751b5 Look like work as expected. I haven't tested DMQ, but having studied the code in detail, i don't think this change will affect it in any way. So, if the authors

[sr-dev] Re: [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-17 Thread Dennis via sr-dev
>>I did not investigate myself, but based on his descriptions dialogs that are >>created before the first restart is not kept >>during the second restart >>since they're no longer marked as "changed" or "new". Exactly ! -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-11 Thread Dennis via sr-dev
Hi ! Yes, you are right, not modified, but as i said above - "when in some resonable short time kamailio shutdowned again with active dialogs loaded at startup", this can happend for example if i whant to modify scenario when do some mistake, or pod in cloud is migrated for some reason (stop

[sr-dev] [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-09 Thread Dennis via sr-dev
Hi ! ### Description I have а scenario where dialogs are saved at kamailio shutdown and loaded at startup, the dialog module related configuration: modparam("dialog", "db_url", DBURL) modparam("dialog", "db_mode", 3) When kamailio shut down first time all dialogs a saved in DB, upon startup

[sr-dev] Re: [kamailio/kamailio] TOPOS callid masking (Issue #3606)

2023-10-26 Thread Dennis via sr-dev
Hi ! Thanks for the fix. Can't check this right now. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3606#issuecomment-1780921759 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] [kamailio/kamailio] TOPOS callid masking (Issue #3606)

2023-10-18 Thread Dennis via sr-dev
### Description PKG memory errors when configured mask_callid in TOPOS. ### Troubleshooting The poblem in detail desribed in mailing lists: https://www.mail-archive.com/sr-users@lists.kamailio.org/msg19997.html ### Possible Solutions Right way to configure topos for callid masking is: