[sr-dev] Re: [kamailio/kamailio] pua_json module not compatible with library libjson-c-dev 0.15.2 (Issue #3376)

2023-11-13 Thread Emmanuel Schmidbauer via sr-dev
ok, i will compile 5.6.3 on bookworm and test it out! give me some time to work on it -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3376#issuecomment-1808249729 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] pua_json module not compatible with library libjson-c-dev 0.15.2 (Issue #3376)

2023-11-13 Thread Emmanuel Schmidbauer via sr-dev
Hi @henningw can you give me more details on how to reproduce the crash? e.g. install from source, packages. I would be happy to take a look and fix it if I can reproduce the issue locally -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] jwt: build jwt module for debian distributions (PR #3556)

2023-09-04 Thread Emmanuel Schmidbauer
Closed #3556. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3556#event-10275642204 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] jwt: build jwt module for debian distributions (PR #3556)

2023-09-04 Thread Emmanuel Schmidbauer
> Hopefully Debain 12 has the required version, iirc Debian 11 has libjwt > 1.10.0, which is too old, the module needs 1.12.0. looks like libjwt-dev is still packaged with version1.10.2 on debian bookworm :( closing this PR -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] jwt: build jwt module for debian distributions (PR #3556)

2023-09-04 Thread Emmanuel Schmidbauer
@linuxmaniac >From the build pipeline: ![image](https://github.com/kamailio/kamailio/assets/7139998/37d1b3b8-d657-4a3e-9c90-23b6b5fb4689) Can we update the docker container to include `libjwt-dev` ? -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] jwt: build jwt module for debian distributions (PR #3556)

2023-09-04 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. 4f3f176075b29544a2e8b8832a942abd09f2aed8 jwt: build jwt module for debian distributions -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3556/files/329a9a0a30cd933ff1a6dd63895d22a5fd648658..4f3f176075b29544a2e8b8832a942abd09f2aed8 You are

[sr-dev] Re: [kamailio/kamailio] jwt: build jwt module for debian distributions (PR #3556)

2023-09-04 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. f85ede1ba910f7605a113a11ed784cf5932924ef jwt: build jwt module for debian distributions -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3556/files/6b67df00c9cd11a57f30230c2b72cdbb88a69158..f85ede1ba910f7605a113a11ed784cf5932924ef You are

[sr-dev] [kamailio/kamailio] jwt: build jwt module for debian distributions (PR #3556)

2023-09-04 Thread Emmanuel Schmidbauer
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for

[sr-dev] Re: [kamailio/kamailio] NATS Module not working (Issue #3253)

2023-07-10 Thread Emmanuel Schmidbauer
Closed #3253 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253#event-9776121455 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] NATS Module not working (Issue #3253)

2023-07-10 Thread Emmanuel Schmidbauer
ok - closing this issue since i cannot reproduce it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253#issuecomment-1629152477 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] NATS Module not working (Issue #3253)

2023-07-07 Thread Emmanuel Schmidbauer
is this problem still persisting? Reviewing this again, it looks like it's an issue in libuv. Could you try uninstalling/installing libuv? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253#issuecomment-1625504995 You are receiving this

[sr-dev] Re: [kamailio/kamailio] nats: nats_publish set reply parameter to be optional (PR #3507)

2023-07-07 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. 471208cf07b1b5b477ea859447f4dc5a9966ea05 nats: nats_publish set reply parameter to be optional -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3507/files/92ffc4b4f17c894d21e6e665cd93059a7299ca78..471208cf07b1b5b477ea859447f4dc5a9966ea05 You are

[sr-dev] [kamailio/kamailio] nats: nats_publish set reply parameter to be optional (PR #3507)

2023-07-07 Thread Emmanuel Schmidbauer
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for

[sr-dev] Re: [kamailio/kamailio] nats: add a reply param to nats_publish and expose as nats_publish_request in KEMI (PR #3397)

2023-03-25 Thread Emmanuel Schmidbauer
@eschmidbauer approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3397#pullrequestreview-1357826482 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] nats: add a reply param to nats_publish and expose as nats_publish_request in KEMI (PR #3397)

2023-03-24 Thread Emmanuel Schmidbauer
looks good to me. can you update the documentation to reflect the new parameter? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3397#issuecomment-1482663017 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] nats: add a reply param to nats_publish and expose as nats_publish_request in KEMI (PR #3397)

2023-03-23 Thread Emmanuel Schmidbauer
does this change require a 3rd parameter to `nats_publish()` ? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3397#issuecomment-1481115529 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] nats: add a reply param to nats_publish and expose as nats_publish_request in KEMI (PR #3397)

2023-03-22 Thread Emmanuel Schmidbauer
@eschmidbauer commented on this pull request. > @@ -60,6 +60,8 @@ static param_export_t params[] = { static cmd_export_t cmds[] = { {"nats_publish", (cmd_function)w_nats_publish_f, 2, fixup_publish_get_value, fixup_publish_get_value_free, ANY_ROUTE}, are these two

[sr-dev] Re: [kamailio/kamailio] core: fix a seg while t_continue with nats module (PR #3396)

2023-03-21 Thread Emmanuel Schmidbauer
This fix looks okay to me but it's beyond the scope of the NATs module. And I'm wondering if this can be fixed in the NATS module instead of the core. The change you made here is probably called from nats in `cfg_update`. I wonder if @miconda has any insight -- Reply to this email directly

[sr-dev] Re: [kamailio/kamailio] pua_json module not compatible with library libjson-c-dev 0.15.2 (Issue #3376)

2023-02-17 Thread Emmanuel Schmidbauer
What version of kamailio are you running? I run 5.5.2 on bullseye with no issues. Just trying to reproduce this -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3376#issuecomment-1434560788 You are receiving this because you are subscribed to

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-11-28 Thread Emmanuel Schmidbauer
Hi, that last error appears to be related to libnats `could not create nats options [System Error]` Can you confirm the Nats server is available? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253#issuecomment-1329423422 You are receiving

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread Emmanuel Schmidbauer
Could you try the changes @linuxmaniac proposed -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253#issuecomment-1260872121 You are receiving this because you are subscribed to this thread. Message ID:

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread Emmanuel Schmidbauer
I believe you need to use the correct format like `modparam("nats", "subject_queue_group", "Kamailio-World:2020")` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253#issuecomment-1260834997 You are receiving this because you are subscribed to

Re: [sr-dev] [kamailio/kamailio] NATS Module not working (Issue #3253)

2022-09-28 Thread Emmanuel Schmidbauer
Hi- I think the module requires you to subscribe to a channel. The module was originally built only as a consumer but now since the module can publish, that is no longer the case. Please confirm my suspicion and I will try to work on a fix to disable subscribe if only needed it for publish --

[sr-dev] git:master:ce21bd8a: NATS: add new function `nats_publish()`

2022-01-07 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: ce21bd8a0cd4c74227bc43bef2bdd8f4a8006171 URL: https://github.com/kamailio/kamailio/commit/ce21bd8a0cd4c74227bc43bef2bdd8f4a8006171 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2021-12-30T10:37:27-05:00 NATS: add new function

[sr-dev] git:master:ff852c46: nats: move nats connection handling into a struct in order to extend features

2021-11-23 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: ff852c46b3b8bee94f63a30974c0742b5829204d URL: https://github.com/kamailio/kamailio/commit/ff852c46b3b8bee94f63a30974c0742b5829204d Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2021-11-19T07:24:29-05:00 nats: move nats connection

Re: [sr-dev] [kamailio/kamailio] nats: make sure pkg & shm memory is allocated; check pointers before freeing memory (#2792)

2021-06-30 Thread Emmanuel Schmidbauer
Merged #2792 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2792#event-4958674713___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:b95b2448: nats: make sure pkg & shm memory is allocated; check pointers before freeing memory

2021-06-30 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: b95b2448d7e968c2bff59e1d820764defee104aa URL: https://github.com/kamailio/kamailio/commit/b95b2448d7e968c2bff59e1d820764defee104aa Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2021-06-28T07:30:40-04:00 nats: make sure pkg &

Re: [sr-dev] [kamailio/kamailio] nats: make sure pkg & shm memory is allocated; check pointers before freeing memory (#2792)

2021-06-28 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. b95b2448d7e968c2bff59e1d820764defee104aa nats: make sure pkg & shm memory is allocated; check pointers before freeing memory -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[sr-dev] [kamailio/kamailio] nats: make sure pkg & shm memory is allocated; check pointers before freeing memory (#2792)

2021-06-28 Thread Emmanuel Schmidbauer
…freeing memory !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master

Re: [sr-dev] [kamailio/kamailio] nats: new nats message consumer module (#2790)

2021-06-28 Thread Emmanuel Schmidbauer
Merged #2790 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2790#event-4946634762___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:6078dbf6: nats: new nats message consumer module

2021-06-28 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: 6078dbf6a7aa8eac8c3c4a57d939716f232799f5 URL: https://github.com/kamailio/kamailio/commit/6078dbf6a7aa8eac8c3c4a57d939716f232799f5 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2021-06-27T07:58:58-04:00 nats: new nats message

Re: [sr-dev] [kamailio/kamailio] nats: new nats message consumer module (#2790)

2021-06-27 Thread Emmanuel Schmidbauer
> Thanks for the pull request. The kamailio-dev is a bot account, so i removed > the review request. > Just one quick question, in your code you state the copyright holder is > "Weave Communication" but the module README (xml) states two other companies. > Not sure if this is done intentional.

Re: [sr-dev] [kamailio/kamailio] nats: new nats message consumer module (#2790)

2021-06-27 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. 6078dbf6a7aa8eac8c3c4a57d939716f232799f5 nats: new nats message consumer module -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[sr-dev] [kamailio/kamailio] nats: new nats message consumer module (#2790)

2021-06-27 Thread Emmanuel Schmidbauer
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] [kamailio/kamailio] nsq: remove unused defs.h file (#2508)

2020-10-16 Thread Emmanuel Schmidbauer
Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing

[sr-dev] git:master:3c02c11d: nathelper: add optional set_contact_alias([trim]) parameter

2020-07-08 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: 3c02c11d66c95102698ee52187952bd98a51510c URL: https://github.com/kamailio/kamailio/commit/3c02c11d66c95102698ee52187952bd98a51510c Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2020-07-03T14:00:57-04:00 nathelper: add optional

[sr-dev] git:master:bfdcef8e: core: add function uri_trim_rcv_alias() to trim alias uri param from header

2020-07-08 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: bfdcef8ef550b74fecc38b1bdb8fcb20ccb279b7 URL: https://github.com/kamailio/kamailio/commit/bfdcef8ef550b74fecc38b1bdb8fcb20ccb279b7 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2020-07-03T13:33:08-04:00 core: add function

Re: [sr-dev] [kamailio/kamailio] Revert "nathelper: add optional set_contact_alias([trim]) parameter" (#2389)

2020-07-04 Thread Emmanuel Schmidbauer
> @eschmidbauer For a revert you can simply use "git revert" on command line or > git client, not necessary to create a pull request for this. thanks! i will remember that going forward -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2390)

2020-07-03 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. 3c02c11d66c95102698ee52187952bd98a51510c nathelper: add optional set_contact_alias([trim]) parameter -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2390)

2020-07-03 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. adc58d15186c8ac1fd71f85b9844f72914946246 nathelper: add optional set_contact_alias([trim]) parameter -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2390)

2020-07-03 Thread Emmanuel Schmidbauer
> Not really fixing it, because now set_contact_alias() from kemi require a > parameter always, so existing kemi deployement will be broken on upgrade. A > new function can be exported to kemi (e.g., set_contact_alias_trim()) and the > old one should stay the same. So practically a new wrapper

Re: [sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2390)

2020-07-03 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. 95b7786489648e1b4690b823e0c1e52196d31a57 nathelper: add optional set_contact_alias([trim]) parameter -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2390)

2020-07-03 Thread Emmanuel Schmidbauer
@eschmidbauer commented on this pull request. > @@ -704,10 +707,12 @@ static int fix_nated_contact_f(struct sip_msg *msg, > char *str1, char *str2) * Replaces ip:port pair in the Contact: field with the source address * of the packet. */ -static int set_contact_alias(struct sip_msg *msg)

Re: [sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2390)

2020-07-03 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. 988a666e85b01f52966e6cb28932efea1578e0cc nathelper: add optional set_contact_alias([trim]) parameter -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2388)

2020-07-03 Thread Emmanuel Schmidbauer
ive updated the new PR with 2 separate commits, one for core and one for the module -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2388)

2020-07-03 Thread Emmanuel Schmidbauer
reverted and resubmitted PR (https://github.com/kamailio/kamailio/pull/2390) with update to address the LGTM scanner issue -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Revert "nathelper: add optional set_contact_alias([trim]) parameter" (#2389)

2020-07-03 Thread Emmanuel Schmidbauer
Merged #2389 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2389#event-3511678932___ Kamailio (SER) - Development Mailing

[sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2390)

2020-07-03 Thread Emmanuel Schmidbauer
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for

[sr-dev] [kamailio/kamailio] Revert "nathelper: add optional set_contact_alias([trim]) parameter" (#2389)

2020-07-03 Thread Emmanuel Schmidbauer
Reverts kamailio/kamailio#2388 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2389 -- Commit Summary -- * Revert nathelper: add optional set_contact_alias([trim]) parameter -- File Changes -- M src/core/dset.c (85) M

Re: [sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2388)

2020-07-03 Thread Emmanuel Schmidbauer
Apologies, I misunderstood. I can revert the commit -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2388#issuecomment-653627967___

Re: [sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2388)

2020-07-03 Thread Emmanuel Schmidbauer
Merged #2388 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2388#event-3511266194___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:f2544789: nathelper: add optional set_contact_alias([trim]) parameter

2020-07-03 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: f2544789283d7ffbeda019c8a3d96e833bf34cc9 URL: https://github.com/kamailio/kamailio/commit/f2544789283d7ffbeda019c8a3d96e833bf34cc9 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2020-07-02T11:43:45-04:00 nathelper: add optional

[sr-dev] [kamailio/kamailio] nathelper: add optional set_contact_alias([trim]) parameter (#2388)

2020-07-02 Thread Emmanuel Schmidbauer
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for

Re: [sr-dev] [kamailio/kamailio] set_contact_alias() issue with clients adding it to their Contact (#2308)

2020-07-02 Thread Emmanuel Schmidbauer
https://github.com/kamailio/kamailio/compare/nathelper-set_contact_alias-trim?expand=1 @mtryfoss i've added support for trimming an already existing alias. I've tested it locally and it works- but can you please test it in your setup? just call the function with "1" param like so

Re: [sr-dev] [kamailio/kamailio] set_contact_alias() issue with clients adding it to their Contact (#2308)

2020-07-02 Thread Emmanuel Schmidbauer
ohhh i understand now. I believe `set_contact_alias()` should _overwrite_ any previous contact alias on the request. have you tried on 5.3 latest? perhaps this should be a setting in nathelper as it would make sense to overwrite it in some cases like this -- You are receiving this because

Re: [sr-dev] [kamailio/kamailio] set_contact_alias() issue with clients adding it to their Contact (#2308)

2020-07-01 Thread Emmanuel Schmidbauer
curious on this topic- we use `set_contact_alias()`on our SIP REGISTERs/INVITEs because we can't use the received parameter. we can't use the received parameter because our registrars are setup to accept traffic from two sets of edge proxies. one set of proxies supports the received param, the

[sr-dev] git:master:c4684574: dialog: improve warning message to help better identify lookup failures

2020-06-25 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: c4684574e0e0e1cca4c1489a16513182f821a643 URL: https://github.com/kamailio/kamailio/commit/c4684574e0e0e1cca4c1489a16513182f821a643 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2020-06-19T16:54:40-04:00 dialog: improve warning

Re: [sr-dev] [kamailio/kamailio] MOHQUEUE: Crash on procesing ACK (#2370)

2020-06-24 Thread Emmanuel Schmidbauer
Closed #2370. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2370#event-3478885973___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] mohqueue: use t_newtran() if transaction does not exist (#2373)

2020-06-24 Thread Emmanuel Schmidbauer
> Thanks! You can merge and close the related issue. > > As a side note, @kamailio-dev is a bot account, usually no human behind it to > do a review, so I removed the review request for it. oops didn't know that! should there be a "dev group" we can assign reviews to? -- You are receiving

Re: [sr-dev] [kamailio/kamailio] mohqueue: use t_newtran() if transaction does not exist (#2373)

2020-06-24 Thread Emmanuel Schmidbauer
Merged #2373 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2373#event-3478884924___ Kamailio (SER) - Development Mailing

[sr-dev] [kamailio/kamailio] mohqueue: use t_newtran() if transaction does not exist (#2373)

2020-06-24 Thread Emmanuel Schmidbauer
Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating

Re: [sr-dev] [kamailio/kamailio] dialog: improve warning message to help better identify dialog lookup failures (#2367)

2020-06-19 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. c4684574e0e0e1cca4c1489a16513182f821a643 dialog: improve warning message to help better identify lookup failures -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[sr-dev] [kamailio/kamailio] dialog: improve warning message to help better identify dialog lookup failures (#2367)

2020-06-19 Thread Emmanuel Schmidbauer
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for

[sr-dev] git:master:a935d8d4: dmq_usrloc: add new parameter `usrloc_delete` to disable synchronizing delete actions

2020-06-17 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: a935d8d414d665ea89859449e622435bc7106f64 URL: https://github.com/kamailio/kamailio/commit/a935d8d414d665ea89859449e622435bc7106f64 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2020-06-12T16:02:19-04:00 dmq_usrloc: add new parameter

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: add new parameter `usrloc_delete` to disable synchronizing delete actions (#2358)

2020-06-12 Thread Emmanuel Schmidbauer
Yes, exactly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2358#issuecomment-643501106___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: add new parameter `usrloc_delete` to disable synchronizing delete actions (#2358)

2020-06-12 Thread Emmanuel Schmidbauer
Yes, each kamailio server will remove contact records as they expire. In our use case, they expire within 60s on each kamailio server. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio/kamailio] dmq_usrloc: add new parameter `usrloc_delete` to disable synchronizing delete actions (#2358)

2020-06-12 Thread Emmanuel Schmidbauer
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] presence module with in-memory presentity records (#2294)

2020-04-22 Thread Emmanuel Schmidbauer
more coredumps. is it okay to email the bt to you as they may contain sensitive data at this point? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] presence module with in-memory presentity records (#2294)

2020-04-22 Thread Emmanuel Schmidbauer
trying again on latest master branch. i'll post results. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2294#issuecomment-617707414___

Re: [sr-dev] [kamailio/kamailio] presence module with in-memory presentity records (#2294)

2020-04-21 Thread Emmanuel Schmidbauer
``` Program terminated with signal SIGSEGV, Segmentation fault. #0 0x7f12607da547 in atomic_cmpxchg_int (var=0x8, old=0, new_v=1) at ../../core/mem/../atomic/atomic_x86.h:224 224 ATOMIC_FUNC_CMPXCHG(cmpxchg, "cmpxchgl %2, %1", int , int) (gdb) frame 2 #2 0x7f12607fe0d0 in

Re: [sr-dev] [kamailio/kamailio] presence module with in-memory presentity records (#2294)

2020-04-21 Thread Emmanuel Schmidbauer
segfault when `modparam("presence", "subs_db_mode", 0)` ``` (gdb) (gdb) bt full #0 0x7f12607da547 in atomic_cmpxchg_int (var=0x8, old=0, new_v=1) at ../../core/mem/../atomic/atomic_x86.h:224 ret = 32530 #1 0x7f12607da57b in futex_get (lock=0x8) at

Re: [sr-dev] [kamailio/kamailio] presence: functions to keep presentity records in memory (f917318)

2020-04-21 Thread Emmanuel Schmidbauer
update, if i set `modparam("presence", "subs_db_mode", 3)` there is no segfault -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] presence: functions to keep presentity records in memory (f917318)

2020-04-21 Thread Emmanuel Schmidbauer
here is a trace from the coredump: ``` Program terminated with signal SIGSEGV, Segmentation fault. #0 0x7f12607da547 in atomic_cmpxchg_int (var=0x8, old=0, new_v=1) at ../../core/mem/../atomic/atomic_x86.h:224 224 ATOMIC_FUNC_CMPXCHG(cmpxchg, "cmpxchgl %2, %1", int , int) (gdb) up #1

Re: [sr-dev] [kamailio/kamailio] presence: functions to keep presentity records in memory (f917318)

2020-04-21 Thread Emmanuel Schmidbauer
getting coredump and seeing this in log: ``` 3(5514) DEBUG: presence [subscribe.c:711]: msg_watchers_clean(): cleaning pending subscriptions 0(5505) ALERT: [main.c:775]: handle_sigs(): child process 5514 exited by a signal 11 0(5505) ALERT: [main.c:778]: handle_sigs(): core was generated

Re: [sr-dev] [kamailio/kamailio] presence: functions to keep presentity records in memory (f917318)

2020-04-21 Thread Emmanuel Schmidbauer
> @eschmidbauer - can you help testing somehow? Not having the possibility to > test properly here, working mainly from home these days I can't use many > devices. First would be to make sure existing your existing config is still > working fine. I tried to be very non-intrusive as much as

Re: [sr-dev] [kamailio/kamailio] presence: functions to keep presentity records in memory (f917318)

2020-04-17 Thread Emmanuel Schmidbauer
This is cool! much needed improvement. As always, great work @miconda ! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] tm: t_continue() - do not print error and return error code (#2212)

2020-02-04 Thread Emmanuel Schmidbauer
agreed. updated PR to use WARN level -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2212#issuecomment-581937884___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] tm: t_continue() - do not print error and return error code (#2212)

2020-02-04 Thread Emmanuel Schmidbauer
@eschmidbauer pushed 1 commit. 848a58234909b65b9f86ec32e494b243f75b4d08 tm: t_continue - do not print error and return error code -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] tm: t_continue() - do not print error and return error code (#2212)

2020-02-04 Thread Emmanuel Schmidbauer
`tm_continue()` is an API endpoint inside `tm` so other modules such as `tmx` call it. if you look at `t_continue()` in `tmx` module, it checks return code and prints it's own log message: ` if(_tmx_tmb.t_continue(tindex, tlabel, act)<0)` i think the API func should only print an error

[sr-dev] [kamailio/kamailio] tm: t_continue() - do not print error and return error code (#2212)

2020-02-04 Thread Emmanuel Schmidbauer
- t_continue() - do not print error and return error code. - change func to log INFO so errors are not printed twice (once by tm and once by func call) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2212 -- Commit Summary -- * tm:

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: use DEBUG loglevel for message (#2189)

2020-01-03 Thread Emmanuel Schmidbauer
Merged #2189 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2189#event-2920226335___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:21358270: dmq_usrloc: use DEBUG loglevel for message

2020-01-03 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: 21358270e49855f668dd01f3e4d9a00dc4c356a7 URL: https://github.com/kamailio/kamailio/commit/21358270e49855f668dd01f3e4d9a00dc4c356a7 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2020-01-02T10:58:35-05:00 dmq_usrloc: use DEBUG

[sr-dev] [kamailio/kamailio] dmq_usrloc: use DEBUG loglevel for message (#2189)

2020-01-02 Thread Emmanuel Schmidbauer
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2189 -- Commit Summary -- * dmq_usrloc: use DEBUG loglevel for message -- File Changes -- M src/modules/dmq_usrloc/usrloc_sync.c (2) -- Patch Links --

Re: [sr-dev] [kamailio/kamailio] [Feature Request]: Add **connection** IP and Port vars (specifically for tcp_accept_haproxy=yes) (#2103)

2019-10-18 Thread Emmanuel Schmidbauer
i've noticed the proxy-proto feature breaks kamailio as a registrar. when `tcp_accept_haproxy=yes` and a REGISTER is received from the loadbalancer, IP and Port variables are changed to the UAC's IP and Port. the location data that is saved is then inaccurate. when user location lookup is

[sr-dev] git:master:63f95447: dmq_usrloc: output AoR on warning message

2019-04-18 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: 63f95447c40739be91203739cfca4bc5523226fa URL: https://github.com/kamailio/kamailio/commit/63f95447c40739be91203739cfca4bc5523226fa Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2019-04-18T07:26:08-04:00 dmq_usrloc: output AoR

[sr-dev] [kamailio/kamailio] dmq_usrloc: output AoR on warning message (#1929)

2019-04-18 Thread Emmanuel Schmidbauer
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1929 -- Commit Summary -- * dmq_usrloc: output AoR on warning message -- File Changes -- M src/modules/dmq_usrloc/usrloc_sync.c (2) -- Patch Links --

[sr-dev] git:master:a4669173: presence: switch warning to debug

2019-01-24 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: a466917378d516025062f7c1d5cf2958c70aa0b9 URL: https://github.com/kamailio/kamailio/commit/a466917378d516025062f7c1d5cf2958c70aa0b9 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2019-01-23T08:39:27-05:00 presence: switch warning

[sr-dev] [kamailio/kamailio] presence: switch warning to debug (#1820)

2019-01-23 Thread Emmanuel Schmidbauer
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1820 -- Commit Summary -- * switch warning to debug -- File Changes -- M src/modules/presence/presentity.c (2) -- Patch Links --

Re: [sr-dev] [kamailio/kamailio] janssonrpcc: add new parameter "keep_alive" (#1808)

2019-01-13 Thread Emmanuel Schmidbauer
Merged #1808 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1808#event-2070500780___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:786b2645: janssonrpcc: add new parameter "keep_alive"

2019-01-13 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: 786b2645d38386a9a1771f7fbd6a151af22b5c64 URL: https://github.com/kamailio/kamailio/commit/786b2645d38386a9a1771f7fbd6a151af22b5c64 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2019-01-11T12:47:07-05:00 janssonrpcc: add new

Re: [sr-dev] [kamailio/kamailio] janssonrpcc: add new parameter "keep_alive" (#1808)

2019-01-11 Thread Emmanuel Schmidbauer
eschmidbauer commented on this pull request. > @@ -79,6 +82,11 @@ void force_disconnect(jsonrpc_server_t* server) server->buffer = NULL; server->status = JSONRPC_SERVER_DISCONNECTED; + if (server->keep_alive_socket_fd) { + INFO("closing socket"); +

[sr-dev] [kamailio/kamailio] janssonrpcc: add new parameter "keep_alive" (#1808)

2019-01-11 Thread Emmanuel Schmidbauer
- send periodic tcp keepalive packets to server in order to prevent connection from closing You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1808 -- Commit Summary -- * janssonrpcc: add new parameter "keep_alive" -- File Changes --

Re: [sr-dev] [kamailio/kamailio] nsq: deprecate json and pua funcs for json api and pua_json modules (#1685)

2018-10-27 Thread Emmanuel Schmidbauer
Merged #1685 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1685#event-1930317889___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:1f09a389: nsq: deprecate json and pua funcs for json api and pua_json modules

2018-10-27 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: 1f09a38982a64e0d6031d9e55e27e81e5f934c24 URL: https://github.com/kamailio/kamailio/commit/1f09a38982a64e0d6031d9e55e27e81e5f934c24 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2018-10-24T11:20:19-04:00 nsq: deprecate json and pua

[sr-dev] [kamailio/kamailio] nsq: deprecate json and pua funcs for json api and pua_json modules (#1685)

2018-10-24 Thread Emmanuel Schmidbauer
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1685 -- Commit Summary -- * nsq: deprecate json and pua funcs for json api and pua_json modules -- File Changes -- M src/modules/nsq/Makefile (3) M

Re: [sr-dev] [kamailio/kamailio] dmq: add optional parameter to dmq_handle_message() (bce0890)

2018-09-02 Thread Emmanuel Schmidbauer
@miconda any chance this can get tagged for next release? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:bce08905: dmq: add optional parameter to dmq_handle_message()

2018-08-31 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: bce08905dc0bea2f9bce44460dcaee4e786b9bd2 URL: https://github.com/kamailio/kamailio/commit/bce08905dc0bea2f9bce44460dcaee4e786b9bd2 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2018-08-31T14:17:26-04:00 dmq: add optional parameter

Re: [sr-dev] [kamailio/kamailio] dmq: add optional parameter to dmq_handle_message() (#1626)

2018-08-31 Thread Emmanuel Schmidbauer
@charlesrchance thanks for your input, and nice catch. I updated the PR to rename the param `continue` and only pass `1` (if it's set to 1 or greater) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dmq: add optional parameter to dmq_handle_message() (#1626)

2018-08-31 Thread Emmanuel Schmidbauer
some context for this PR... we are testing using the `tsilo` module for mobile push notifications while maintaining multiple registrars with `dmq_usrloc` if an `INVITE` goes to a registrar "A" and then the UA registers to registrar "B", the dmq message is sent to registrar "A" with UA location

[sr-dev] [kamailio/kamailio] dmq: add optional parameter to dmq_handle_message() (#1626)

2018-08-30 Thread Emmanuel Schmidbauer
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1626 -- Commit Summary -- * dmq: add optional parameter to dmq_handle_message() -- File Changes -- M src/modules/dmq/dmq.c (4) M src/modules/dmq/doc/dmq_admin.xml (12) M

  1   2   >