[sr-dev] git:5.7:d411c6ea: dialog: don't send the BYE if dialog is in deleted state (#3714)

2024-01-16 Thread Federico Cabiddu via sr-dev
Module: kamailio Branch: 5.7 Commit: d411c6ea4358e6d9dd367349e877ed5f5bf4bb2f URL: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5f5bf4bb2f Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2024-01-16T09:51:14+01:00 dialog: don't send the BYE if dialog

[sr-dev] Re: [kamailio/kamailio] dialog: don't send the BYE if dialog is in deleted state (PR #3714)

2024-01-16 Thread Federico Cabiddu via sr-dev
Merged #3714 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3714#event-11495736901 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] [kamailio/kamailio] dialog: don't send the BYE if dialog is in deleted state (PR #3714)

2024-01-15 Thread Federico Cabiddu via sr-dev
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] [kamailio/kamailio] http_async_client: exit mod_init if tm is not loaded (PR #3706)

2024-01-09 Thread Federico Cabiddu via sr-dev
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] [kamailio/kamailio] Makefile.groups: add dlgs and sworker to extra modules (PR #3684)

2023-12-20 Thread Federico Cabiddu via sr-dev
Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for

[sr-dev] git:master:ef2ea73f: tsilo: add new return code to ts_append and document it

2022-10-13 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: ef2ea73f044a1421b25734d4773bd2dacaab1165 URL: https://github.com/kamailio/kamailio/commit/ef2ea73f044a1421b25734d4773bd2dacaab1165 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2022-10-13T15:42:56+02:00 tsilo: add new return code

Re: [sr-dev] Info: sipexer v1.0.0 - sip cli tool

2022-02-16 Thread Federico Cabiddu
Very cool Daniel, thank you! Federico On Mon, Feb 14, 2022 at 3:02 PM Daniel-Constantin Mierla wrote: > Hello, > > I want to announce the availability of sipexer v1.0.0 - a sip cli tool > that can facilitate testing and monitoring of SIP signalling systems. It > tries to have a modern

[sr-dev] git:5.4:c09e6453: core: tcp - add alias for cinfo dst IP

2021-10-24 Thread Federico Cabiddu
Module: kamailio Branch: 5.4 Commit: c09e6453db91cc71b1d853b05601a53869718550 URL: https://github.com/kamailio/kamailio/commit/c09e6453db91cc71b1d853b05601a53869718550 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2021-10-24T11:12:17+02:00 core: tcp - add alias for cinfo dst IP

[sr-dev] git:5.5:e43ea4b3: core: tcp - add alias for cinfo dst IP

2021-10-24 Thread Federico Cabiddu
Module: kamailio Branch: 5.5 Commit: e43ea4b3e011e410ec36bb470889170f836e93b5 URL: https://github.com/kamailio/kamailio/commit/e43ea4b3e011e410ec36bb470889170f836e93b5 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2021-10-24T11:12:03+02:00 core: tcp - add alias for cinfo dst IP

Re: [sr-dev] [kamailio/kamailio] core: tcp - add alias for cinfo dst IP (PR #2888)

2021-10-22 Thread Federico Cabiddu
Thanks for merging Henning. Should we backport it also to stable branches? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] core: tcp - add alias for cinfo dst IP (PR #2888)

2021-10-20 Thread Federico Cabiddu
Right, I've added a comment and force pushed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2888#issuecomment-947476905___ Kamailio

Re: [sr-dev] [kamailio/kamailio] core: tcp - add alias for cinfo dst IP (PR #2888)

2021-10-20 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 86d897534d5c814de1f87744f8d5d6ca6a35f384 core: tcp - add alias for cinfo dst IP -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] core: tcp - add alias for cinfo dst IP (PR #2888)

2021-10-20 Thread Federico Cabiddu
Hi Henning, that's a good question. Currently the cinfo struct of the tcp connection is only filled by the proxy protocol parsing (oterwise is init to null) so the check when adding the alias gives the same results (we also chek that the dst IP there is different from the one stored in rcv, to

Re: [sr-dev] TLS connection issue

2021-10-20 Thread Federico Cabiddu
Hi Lorenzo, the question might be stupid, but do you have in your configuration a listen directive (https://www.kamailio.org/wiki/cookbooks/5.5.x/core#listen) on port 5061? Cheers, Federico On Wed, Oct 20, 2021 at 8:03 AM Lorenzo Campo wrote: > Hi guys, > > We are quite newby about Kamailio

[sr-dev] [kamailio/kamailio] core: tcp - add alias for cinfo dst IP (PR #2888)

2021-10-19 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] Proxy protocol issue

2021-10-18 Thread Federico Cabiddu
advertise" keyword. >> >> You anyway need another socket. >> Any socket that you want. >> >> Maybe you need anycast Kamailio installation? >> >> Sergey >> >> On Fri, Oct 15, 2021 at 2:27 PM Federico Cabiddu < >> federico.cabi...@gmai

Re: [sr-dev] Proxy protocol issue

2021-10-15 Thread Federico Cabiddu
ere is already > opened TCP connection with the same tuple (ie. between LB and Kamailio > host) > So the way to use proxy protocol in Kamailio is DSR (direct server return) > scenarios. > > here you can find related conversation: > https://github.com/kamailio/kamailio/issues/2

[sr-dev] Proxy protocol issue

2021-10-15 Thread Federico Cabiddu
, unless I'm missing something. Hopefully I've been clear enough explaining the issue :) If you agree with the analysis I can prepare a PR for it. Have you all a great weekend, Federico Cabiddu ___ Kamailio (SER) - Development Mailing List sr-dev@list

[sr-dev] git:master:91c73d62: http_async_client: configure curl redirect per query

2021-03-31 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 91c73d62bcb5e635aae4462393e3fe71b64657f1 URL: https://github.com/kamailio/kamailio/commit/91c73d62bcb5e635aae4462393e3fe71b64657f1 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2021-03-31T11:50:29+02:00 http_async_client: configure curl

Re: [sr-dev] [kamailio/kamailio] http_async_client: add curl_follow_redirect parameter (#2694)

2021-03-30 Thread Federico Cabiddu
Merged #2694 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2694#event-4527130108___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] http_async_client: add curl_follow_redirect parameter (#2694)

2021-03-30 Thread Federico Cabiddu
I've started working on the per query implementation. Merging this for now, before the code freeze. Thanks again! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] http_async_client: add curl_follow_redirect parameter (#2694)

2021-03-28 Thread Federico Cabiddu
Thank you! PR looks fine, documetation included. I was thinking that it would be nice to specify the parameter per query like it's done for other parameters. Could be done in this pull request or we can do it after. -- You are receiving this because you are subscribed to this thread. Reply to

Re: [sr-dev] git:master:e85a5a6a: http_async_client: disable HTTP/2 multiplexing

2021-03-23 Thread Federico Cabiddu
Just seen that you already did it, sorry! On Tue, Mar 23, 2021 at 12:17 PM Federico Cabiddu < federico.cabi...@gmail.com> wrote: > Ops, I'll fix it! > > On Tue, Mar 23, 2021 at 11:16 AM Victor Seva < > linuxman...@torreviejawireless.org> wrote: > >> Hi F

Re: [sr-dev] git:master:e85a5a6a: http_async_client: disable HTTP/2 multiplexing

2021-03-23 Thread Federico Cabiddu
Ops, I'll fix it! On Tue, Mar 23, 2021 at 11:16 AM Victor Seva < linuxman...@torreviejawireless.org> wrote: > Hi Federico! > > On 3/22/21 8:09 PM, Federico Cabiddu wrote: > > Module: kamailio > > Branch: master > > Commit: e85a5a6ae2ae01159ef4aeffd9f51f58c7bc8

Re: [sr-dev] [kamailio/kamailio] Core dumps possibly related to #2616 or http_async_query (#2632)

2021-03-22 Thread Federico Cabiddu
If there is agreement I'll merge this one and backport it to stable branches. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Core dumps possibly related to #2616 or http_async_query (#2632)

2021-03-22 Thread Federico Cabiddu
@miconda: not sure that http_client is affected too, being the problem in http_async_client the fact tha a socket is bound to a specific easy handler and an event is attached to it via libevent. But I think @oej is better qualified to answer :) -- You are receiving this because you are

[sr-dev] git:5.3:9d24f18f: http_async_client: disable HTTP/2 multiplexing

2021-03-22 Thread Federico Cabiddu
Module: kamailio Branch: 5.3 Commit: 9d24f18fd529152d0a5ef4d0aed27bc488928be9 URL: https://github.com/kamailio/kamailio/commit/9d24f18fd529152d0a5ef4d0aed27bc488928be9 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2021-03-22T20:09:58+01:00 http_async_client: disable HTTP/2

[sr-dev] git:5.4:3ee9eb67: http_async_client: disable HTTP/2 multiplexing

2021-03-22 Thread Federico Cabiddu
Module: kamailio Branch: 5.4 Commit: 3ee9eb6700ae61c0449b2c9568e67712b0e82f8f URL: https://github.com/kamailio/kamailio/commit/3ee9eb6700ae61c0449b2c9568e67712b0e82f8f Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2021-03-22T20:09:37+01:00 http_async_client: disable HTTP/2

[sr-dev] git:master:e85a5a6a: http_async_client: disable HTTP/2 multiplexing

2021-03-22 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b URL: https://github.com/kamailio/kamailio/commit/e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2021-03-22T20:09:12+01:00 http_async_client: disable HTTP/2

Re: [sr-dev] [kamailio/kamailio] Core dumps possibly related to #2616 or http_async_query (#2632)

2021-03-22 Thread Federico Cabiddu
@miconda: in this case we should also disable NPN negotiation: https://curl.se/libcurl/c/CURLOPT_SSL_ENABLE_NPN.html, or even disabling HTTP/2 completely setting CURLOPT_HTTP_VERSION (current curl default value is CURLOPT_HTTP_VERSION_2TLS). I didn't want to be so extreme :) @bjokax, thanks for

Re: [sr-dev] [kamailio/kamailio] Core dumps possibly related to #2616 or http_async_query (#2632)

2021-03-21 Thread Federico Cabiddu
Hi, althought I have not been able to reproduce the crash, I think that the problem, as highlighted by @bjokax, is the not correct handling of HTTP/2 multiplexing. The module was written before HTTP/2 was out so it has never been considered. Support for it would require some important

Re: [sr-dev] [kamailio/kamailio] Core dumps possibly related to #2616 or http_async_query (#2632)

2021-03-19 Thread Federico Cabiddu
Thank you for the report. I'll try to have a look on it in the next couple of days. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] [Feature] RFC 8898 support (#2669)

2021-03-12 Thread Federico Cabiddu
Hi, actually you can implement RFC 8898 in kamailio routing script, all the pieces are already there. For the challenge you can easily reply 401/407 adding a "forged" WWW-Authenticate header with Bearer schema and authz-server. For the token validation: - if it's a structured token you can

Re: [sr-dev] [kamailio/kamailio] usrloc Stats are not compatible with Prometheus (xhttp_prom module) (#2644)

2021-02-22 Thread Federico Cabiddu
This has been fixed with PR https://github.com/kamailio/kamailio/pull/2304/. It's included in 5.4 but not in 5.3, but could be easily cherry-picked. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] Merry Christmas and Happy Holidays!

2020-12-25 Thread Federico Cabiddu
Merry Christmas to all this beautiful community. And best wishes for 2021! Federico On Thu, 24 Dec 2020, 19:09 Daniel-Constantin Mierla, wrote: > A year that was very tough for the entire world is getting close to its > end, no doubt that was the most challenging in our life so far for many >

Re: [sr-dev] [kamailio/kamailio] Dispatcher SNI support (#2591)

2020-12-17 Thread Federico Cabiddu
Did you check 'ping_from' (http://www.kamailio.org/docs/modules/devel/modules/dispatcher.html#dispatcher.ex.attributes)? Could it cover your needs? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] nat_traversal: TCP transport support (#2564)

2020-11-28 Thread Federico Cabiddu
You can use tcpops tcp_enable_keepalive ( http://www.kamailio.org/docs/modules/devel/modules/tcpops.html#tcpops.f.tcp_keepalive_enable) to enable tcp keepalive per connection. On Sat, 28 Nov 2020, 16:47 sergey-safarov, wrote: > If the client does not send TCP keep-alive SIP message or TCP

[sr-dev] git:master:8ab72a37: http_async_client: add http_time pseudovariable

2020-11-19 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 8ab72a37565bbec503d825f48774a0627014f665 URL: https://github.com/kamailio/kamailio/commit/8ab72a37565bbec503d825f48774a0627014f665 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-11-19T10:34:13+01:00 http_async_client: add http_time

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-09 Thread Federico Cabiddu
Closed #2466. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2466#event-3745219476___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] git:5.3:794861c8: httpa_asyc_client: set curl memory callbacks in module initialization

2020-09-09 Thread Federico Cabiddu
Module: kamailio Branch: 5.3 Commit: 794861c8db50846599118fe7583f522200195d8d URL: https://github.com/kamailio/kamailio/commit/794861c8db50846599118fe7583f522200195d8d Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-09-09T12:49:03+02:00 httpa_asyc_client: set curl memory

[sr-dev] git:5.4:4e0f9f88: httpa_asyc_client: set curl memory callbacks in module initialization

2020-09-09 Thread Federico Cabiddu
Module: kamailio Branch: 5.4 Commit: 4e0f9f8869aaf364011413417ff6c95c032af16d URL: https://github.com/kamailio/kamailio/commit/4e0f9f8869aaf364011413417ff6c95c032af16d Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-09-09T12:48:43+02:00 httpa_asyc_client: set curl memory

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-09 Thread Federico Cabiddu
Thanks for testing Joey, the branch is now merged in master. I'll also backport it to stable branches. On Wed, Sep 9, 2020 at 11:57 AM Henning Westerholt wrote: > Reopened #2466 . > > — > You are receiving this because you are subscribed to this

[sr-dev] git:master:66fea7c6: httpa_asyc_client: set curl memory callbacks in module initialization

2020-09-09 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 66fea7c615e01b200b334d5255c90911cfb360fe URL: https://github.com/kamailio/kamailio/commit/66fea7c615e01b200b334d5255c90911cfb360fe Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-09-08T15:05:37+02:00 httpa_asyc_client: set curl memory

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-08 Thread Federico Cabiddu
Hi Joey, I've tried to investigate the issue with http_async_client initialization, but I've not been able to reproduce it in buster. Anyway looking at the logs I've found something that might be not good, the place(s) where curl memory callbacks are set. I've created a branch with a change on

Re: [sr-dev] [kamailio/kamailio] [db_text] In a case of using dispatcher from db_text, only first entry in table is processed (#2465)

2020-09-02 Thread Federico Cabiddu
Which mode are you using for db_test? http://www.kamailio.org/docs/modules/devel/modules/db_text.html#idm136 If you're using the default 0 then the tables are only read once at startup so a dispatcher.reload would not have any effect. -- You are receiving this because you are subscribed to

[sr-dev] git:5.4:bf38c7b0: async: fix async_ms_route and export it to kemi

2020-08-20 Thread Federico Cabiddu
Module: kamailio Branch: 5.4 Commit: bf38c7b04171e6f410ff885f10abe0f815d27de9 URL: https://github.com/kamailio/kamailio/commit/bf38c7b04171e6f410ff885f10abe0f815d27de9 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-08-20T15:35:04+02:00 async: fix async_ms_route and export

[sr-dev] git:5.3:3af15354: async: fix async_ms_route and export it to kemi

2020-08-20 Thread Federico Cabiddu
Module: kamailio Branch: 5.3 Commit: 3af15354836f69ec2cbd6f107f860cfc1ffc334e URL: https://github.com/kamailio/kamailio/commit/3af15354836f69ec2cbd6f107f860cfc1ffc334e Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-08-20T15:35:31+02:00 async: fix async_ms_route and export

Re: [sr-dev] [kamailio/kamailio] async: fix async_ms_route and export it to kemi (#2450)

2020-08-20 Thread Federico Cabiddu
Merged #2450 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2450#event-3675287863___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:b7876278: async: fix async_ms_route and export it to kemi

2020-08-20 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: b787627819fc93dcc8c68a4950c9760d298ce555 URL: https://github.com/kamailio/kamailio/commit/b787627819fc93dcc8c68a4950c9760d298ce555 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-08-20T11:06:56+02:00 async: fix async_ms_route and export

Re: [sr-dev] [kamailio/kamailio] async: fix async_ms_route and export it to kemi (#2450)

2020-08-20 Thread Federico Cabiddu
Thanks Daniel, I'm going to merge and backport this one and I'll do a separate PR for the other exports. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio/kamailio] async: fix async_ms_route and export it to kemi (#2450)

2020-08-20 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] Default config and options for Kamailio 5.4.0 (#2381)

2020-07-03 Thread Federico Cabiddu
Given that Prometheus is becoming quite common as a timeseries backend, what do you think about conditionally (#!ifdef) loading xhttp_prom module? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dispatcher: keep current destinations' load when adding/removing (#2353)

2020-06-11 Thread Federico Cabiddu
Merged #2353 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2353#event-343725___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:8d9e6578: dispatcher: keep current destinations' load when adding/removing

2020-06-11 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 8d9e65789fe2f6da2648449639620899b1d1b2c3 URL: https://github.com/kamailio/kamailio/commit/8d9e65789fe2f6da2648449639620899b1d1b2c3 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-06-10T07:17:13+02:00 dispatcher: keep current destinations

[sr-dev] [kamailio/kamailio] dispatcher: keep current destinations' load when adding/removing (#2353)

2020-06-09 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] dispatcher: don't reset load table when adding/removing a destination… (#2342)

2020-06-05 Thread Federico Cabiddu
Merged #2342 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2342#event-3410895434___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] dispatcher: don't reset load table when adding/removing a destination… (#2342)

2020-06-05 Thread Federico Cabiddu
Thank you Daniel, going to merge. I also think it should be backported, adapted because there is no rpc add/remove command, to stable branches. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:4099a6ca: dispatcher: don't reset load table when adding/removing a destination or reloading the list

2020-06-05 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 4099a6caf856c9af4d7d89aec73db143efbcd40b URL: https://github.com/kamailio/kamailio/commit/4099a6caf856c9af4d7d89aec73db143efbcd40b Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-06-01T07:30:14+02:00 dispatcher: don't reset load table

[sr-dev] [kamailio/kamailio] dispatcher: don't reset load table when adding/removing a destination… (#2342)

2020-06-01 Thread Federico Cabiddu
… or reloading the list !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from

Re: [sr-dev] [kamailio/kamailio] dispatcher: rework attrs parameter in rpc 'add' command (#2339)

2020-05-28 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 583b63e23f48b9bde84c6a86940ae09ff54bc252 dispatcher: rework attrs parameter in rpc 'add' command -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dispatcher: rework attrs parameter in rpc 'add' command (#2339)

2020-05-28 Thread Federico Cabiddu
@grumvalski commented on this pull request. > rpc->fault(ctx, 500, "Invalid Parameters"); return; + } else if (nparams < 4) { right, fixed and force pushed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly

[sr-dev] [kamailio/kamailio] dispatcher: rework attrs parameter in rpc 'add' command (#2339)

2020-05-28 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] dispatcher: add attrs param to rpc 'add' call (#2336)

2020-05-28 Thread Federico Cabiddu
@grumvalski commented on this pull request. > flags = 0; - if(rpc->scan(ctx, "dS*d", , , ) < 2) { + if(rpc->scan(ctx, "dS*d", , , , ) < 3) { Right, I'm going to fix. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [sr-dev] [kamailio/kamailio] dispatcher: add attrs param to rpc 'add' call (#2336)

2020-05-27 Thread Federico Cabiddu
Merged #2336 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2336#event-3381099203___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] dispatcher: add attrs param to rpc 'add' call (#2336)

2020-05-27 Thread Federico Cabiddu
Thanks Henning. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2336#issuecomment-635106745___ Kamailio (SER) - Development Mailing List

[sr-dev] git:master:2e842e9c: dispatcher: add attrs param to rpc 'add' call

2020-05-27 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 2e842e9c11b136270b56b2b48a0364a94749c4ed URL: https://github.com/kamailio/kamailio/commit/2e842e9c11b136270b56b2b48a0364a94749c4ed Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-05-26T10:24:58+02:00 dispatcher: add attrs param to rpc

[sr-dev] [kamailio/kamailio] dispatcher: add attrs param to rpc 'add' call (#2336)

2020-05-26 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-02 Thread Federico Cabiddu
Merged #2304 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2304#event-3296066480___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-02 Thread Federico Cabiddu
Thanks Daniel, documentation added to the wiki. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2304#issuecomment-622961098___ Kamailio

[sr-dev] git:master:3203a657: core: new core parameter stats_name_separator

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 3203a6572b874d191c3be61519853005bd5ab056 URL: https://github.com/kamailio/kamailio/commit/3203a6572b874d191c3be61519853005bd5ab056 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-05-01T13:02:39+02:00 core: new core parameter

[sr-dev] git:master:9948696f: core: remove stats_name_separator from cfg_group_core

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 9948696fd84605919e6ce6a7106099f1cdd0de98 URL: https://github.com/kamailio/kamailio/commit/9948696fd84605919e6ce6a7106099f1cdd0de98 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-05-02T10:14:23+02:00 core: remove stats_name_separator

[sr-dev] git:master:0595795c: ims_usrloc_pcscf, p_usrloc, usrloc: use KSR_STATS_NAMESEP for stats names

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 0595795c659f6af586e63837efe56b45808cd735 URL: https://github.com/kamailio/kamailio/commit/0595795c659f6af586e63837efe56b45808cd735 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-28T16:24:24+02:00 ims_usrloc_pcscf, p_usrloc, usrloc

[sr-dev] git:master:ddd27713: usrloc: change "-" for "_" in stats name to be prometheus compliant

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: ddd277139165f39406832ddd557c2b56b75a7100 URL: https://github.com/kamailio/kamailio/commit/ddd277139165f39406832ddd557c2b56b75a7100 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-28T10:24:04+02:00 usrloc: change "-" for &q

[sr-dev] git:master:4357b5e6: core: define KSR_STATS_NAMESEP for stats name separator

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 4357b5e6be2a71a401e9d53c43e787b9bfcc8ed0 URL: https://github.com/kamailio/kamailio/commit/4357b5e6be2a71a401e9d53c43e787b9bfcc8ed0 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-28T16:22:40+02:00 core: define KSR_STATS_NAMESEP

[sr-dev] git:master:2fe0378c: p_usrloc, ims_usrloc_pcscf: change "-" for "_" in stats name to be prometheus compliant

2020-05-02 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 2fe0378c3d0596e30d8ec9ea4cb7d828321d2030 URL: https://github.com/kamailio/kamailio/commit/2fe0378c3d0596e30d8ec9ea4cb7d828321d2030 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-28T14:48:59+02:00 p_usrloc, ims_usrloc_pcscf: change

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-02 Thread Federico Cabiddu
Right, I realized after doing it. I've pushed the new suggest implementation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-02 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 9948696fd84605919e6ce6a7106099f1cdd0de98 core: remove stats_name_separator from cfg_group_core -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-05-01 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 3203a6572b874d191c3be61519853005bd5ab056 core: new core parameter stats_name_separator -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-04-30 Thread Federico Cabiddu
I can find some time in the next days to implement the global param. I'd also go for prometheus format by default. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-04-28 Thread Federico Cabiddu
@grumvalski pushed 2 commits. 4357b5e6be2a71a401e9d53c43e787b9bfcc8ed0 core: define KSR_STATS_NAMESEP for stats name separator 0595795c659f6af586e63837efe56b45808cd735 ims_usrloc_pcscf, p_usrloc, usrloc: use KSR_STATS_NAMESEP for stats names -- You are receiving this because you are

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-04-28 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 2fe0378c3d0596e30d8ec9ea4cb7d828321d2030 p_usrloc, ims_usrloc_pcscf: change "-" for "_" in stats name to be prometheus compliant -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-04-28 Thread Federico Cabiddu
I've spot the same usage in p_usrloc and ims_usrloc_pcscf modules (they both derived from usrloc). I didn't notice any other module building "derivate" stats (as those), so I'm not sure that implementing a global param is worth in this case. -- You are receiving this because you are subscribed

[sr-dev] [kamailio/kamailio] usrloc: change "-" for "_" in stats name to be prometheus compliant (#2304)

2020-04-28 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] git:5.3:3333d76e: siptrace: siptrace: fix memory leak in fake replies tracing

2020-04-22 Thread Federico Cabiddu
Module: kamailio Branch: 5.3 Commit: d76e57c637b6d6dd7617ba4a51892a836d04 URL: https://github.com/kamailio/kamailio/commit/d76e57c637b6d6dd7617ba4a51892a836d04 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-22T14:17:14+02:00 siptrace: siptrace: fix memory leak

Re: [sr-dev] [kamailio/kamailio] siptrace: siptrace: fix memory leak in fake replies tracing (#2295)

2020-04-22 Thread Federico Cabiddu
Merged #2295 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2295#event-3260265282___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:0f461ee2: siptrace: free parsed from in case of errors

2020-04-22 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 0f461ee26fa72d1d2f4f6777f3e0d233619dc3fb URL: https://github.com/kamailio/kamailio/commit/0f461ee26fa72d1d2f4f6777f3e0d233619dc3fb Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-22T12:17:18+02:00 siptrace: free parsed from in case

[sr-dev] git:master:ee7496f1: siptrace: siptrace: fix memory leak in fake replies tracing

2020-04-22 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: ee7496f18b626a6c5dff10753db5b546759f6f7b URL: https://github.com/kamailio/kamailio/commit/ee7496f18b626a6c5dff10753db5b546759f6f7b Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-22T10:54:29+02:00 siptrace: siptrace: fix memory leak

Re: [sr-dev] [kamailio/kamailio] siptrace: siptrace: fix memory leak in fake replies tracing (#2295)

2020-04-22 Thread Federico Cabiddu
@grumvalski commented on this pull request. > @@ -1383,7 +1383,7 @@ static void trace_onreq_out(struct cell *t, int type, > struct tmcb_params *ps) } if(sip_trace_msg_attrs(msg, ) < 0) { - return; + goto end; } sorry, definitely not my

Re: [sr-dev] [kamailio/kamailio] siptrace: siptrace: fix memory leak in fake replies tracing (#2295)

2020-04-22 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 0f461ee26fa72d1d2f4f6777f3e0d233619dc3fb siptrace: free parsed from in case of errors -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] siptrace: siptrace: fix memory leak in fake replies tracing (#2295)

2020-04-22 Thread Federico Cabiddu
@grumvalski pushed 1 commit. f2e675876980c5c066a837fbd25c20594cfc64ea siptrace: free parsed from in case of errors -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] siptrace: siptrace: fix memory leak in fake replies tracing (#2295)

2020-04-22 Thread Federico Cabiddu
Thank you Daniel and, again, you are right, I was working on 5.3 branch and didn't realize the new sip_trace_msg_attrs function. I'm pushing a fix. This also means that the patch cannot be backported to 5.3 as it is. -- You are receiving this because you are subscribed to this thread. Reply

Re: [sr-dev] [kamailio/kamailio] siptrace: siptrace: fix memory leak in fake replies tracing (#2295)

2020-04-22 Thread Federico Cabiddu
@grumvalski pushed 1 commit. ee7496f18b626a6c5dff10753db5b546759f6f7b siptrace: siptrace: fix memory leak in fake replies tracing -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] siptrace: siptrace: fix memory leak in fake replies tracing (#2295)

2020-04-22 Thread Federico Cabiddu
@grumvalski commented on this pull request. > @@ -1607,6 +1608,11 @@ static void trace_onreply_out(struct cell *t, int > type, struct tmcb_params *ps) if(msg == NULL || msg == FAKED_REPLY) { msg = t->uas.request; faked = 1; + /* check if

[sr-dev] [kamailio/kamailio] siptrace: siptrace: fix memory leak in fake replies tracing (#2295)

2020-04-22 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] git:5.2:b6f40ec3: http_async_client: do not set global avp lists from t on async callback

2020-04-20 Thread Federico Cabiddu
Module: kamailio Branch: 5.2 Commit: b6f40ec3016961d9e2f97b40bc6a05c752780b4f URL: https://github.com/kamailio/kamailio/commit/b6f40ec3016961d9e2f97b40bc6a05c752780b4f Author: Daniel-Constantin Mierla Committer: Federico Cabiddu Date: 2020-04-20T09:51:59+02:00 http_async_client: do not set

[sr-dev] git:5.3:ff48cc53: http_async_client: do not set global avp lists from t on async callback

2020-04-20 Thread Federico Cabiddu
Module: kamailio Branch: 5.3 Commit: ff48cc5311d55176118ad57cf2d4417a2d229766 URL: https://github.com/kamailio/kamailio/commit/ff48cc5311d55176118ad57cf2d4417a2d229766 Author: Daniel-Constantin Mierla Committer: Federico Cabiddu Date: 2020-04-20T09:51:42+02:00 http_async_client: do not set

Re: [sr-dev] [kamailio/kamailio] async_http_client crash (#2286)

2020-04-18 Thread Federico Cabiddu
Sorry the mail was sent before ending by accident. Thanks for looking into it and fixing it Daniel. For sure it should be backported. Cheers, Federico On Sat, Apr 18, 2020 at 9:23 AM Federico Cabiddu wrote: > Hi Daniel, > you are absolutely right and that part of code is for sure

Re: [sr-dev] [kamailio/kamailio] async_http_client crash (#2286)

2020-04-18 Thread Federico Cabiddu
Hi Daniel, you are absolutely right and that part of code is for sure wrong. Those lines have been there since the beginning and for sure due to my lack of understanding of transactions's internals and avps (don't remember why sincerely). For the records, I've been using mixed suspended/not

Re: [sr-dev] [kamailio/kamailio] async_http_client crash (#2286)

2020-04-15 Thread Federico Cabiddu
Hi Alex, yes, avp should be persistent. I've never seen a crash like this in 5.2.x (the release I'm using in prod) and I'm using avp in resume routes, even suspending/resuming twice a single transaction (I have a scenario where two http queries are run). Have anything changed in your system

Re: [sr-dev] git:master:430e00a2: modules: readme files regenerated - dialog ... [skip ci]

2020-04-09 Thread Federico Cabiddu
Nice! Thank you Daniel! On Thu, 9 Apr 2020, 09:46 Kamailio Dev, wrote: > Module: kamailio > Branch: master > Commit: 430e00a208c9ae4c2cdc39d628fc0a1d23f30f81 > URL: > https://github.com/kamailio/kamailio/commit/430e00a208c9ae4c2cdc39d628fc0a1d23f30f81 > > Author: Kamailio Dev > Committer:

  1   2   3   >