Re: [sr-dev] [kamailio/kamailio] dialog: add dialog init, start end end timestamps to the output of dl… (#2279)

2020-04-08 Thread Federico Cabiddu
Merged #2279 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2279#event-3216591710___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] dialog: add dialog init, start end end timestamps to the output of dl… (#2279)

2020-04-08 Thread Federico Cabiddu
Nice idea, if I have time the next days I can start looking at it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:0eb265e6: dialog: add dialog init, start and end timestamps to the output of dlg.briefing

2020-04-08 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 0eb265e6c6ee78ab3f8735ddc44fc8616ae41066 URL: https://github.com/kamailio/kamailio/commit/0eb265e6c6ee78ab3f8735ddc44fc8616ae41066 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-08T16:05:37+02:00 dialog: add dialog init, start

Re: [sr-dev] [kamailio/kamailio] Grumvalski/ds outbound proxy (#2275)

2020-04-08 Thread Federico Cabiddu
Merged #2275 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2275#event-3216588701___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:8fa5e4f5: dispatcher: docs for obproxy attr

2020-04-08 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 8fa5e4f572a1ffe7efeb88cf8b80c1337f74741f URL: https://github.com/kamailio/kamailio/commit/8fa5e4f572a1ffe7efeb88cf8b80c1337f74741f Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-07T15:18:34+02:00 dispatcher: docs for obproxy attr

[sr-dev] git:master:74ef108f: dispatcher: add new gateway attr "obproxy"

2020-04-08 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 74ef108fe0371bd261acc42291d7adbba357f769 URL: https://github.com/kamailio/kamailio/commit/74ef108fe0371bd261acc42291d7adbba357f769 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-07T15:07:44+02:00 dispatcher: add new gateway attr

Re: [sr-dev] [kamailio/kamailio] siptrace: safety check for transaction when checking ACK (#2278)

2020-04-08 Thread Federico Cabiddu
Merged #2278 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2278#event-3216585996___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:0c142be9: siptrace: safety check for transaction when checking ACK

2020-04-08 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 0c142be9e300e2883437c4aa46e68cc3bb3f5e4c URL: https://github.com/kamailio/kamailio/commit/0c142be9e300e2883437c4aa46e68cc3bb3f5e4c Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-08T14:40:17+02:00 siptrace: safety check

[sr-dev] [kamailio/kamailio] dialog: add dialog init, start end end timestamps to the output of dl… (#2279)

2020-04-08 Thread Federico Cabiddu
…g.briefing !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch

[sr-dev] [kamailio/kamailio] siptrace: safety check for transaction when checking ACK (#2278)

2020-04-08 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] [kamailio/kamailio] Grumvalski/ds outbound proxy (#2275)

2020-04-07 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] siptrace flag fixes (#2273)

2020-04-06 Thread Federico Cabiddu
Merged #2273 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2273#event-3205599272___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:2ad78641: siptrace: skip sip_trace for ACK for negative replies if the original transaction is already being traced

2020-04-06 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 2ad786413199b487a65258c8bd33703b5ccbf04d URL: https://github.com/kamailio/kamailio/commit/2ad786413199b487a65258c8bd33703b5ccbf04d Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-05T17:20:48+02:00 siptrace: skip sip_trace for ACK

[sr-dev] git:master:080c6e07: siptrace: don't trace CANCEL if the cancelled transaction is already being traced

2020-04-06 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 080c6e07708f1964498a43e70c9b6240b5bdebcd URL: https://github.com/kamailio/kamailio/commit/080c6e07708f1964498a43e70c9b6240b5bdebcd Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-03T13:03:56+02:00 siptrace: don't trace CANCEL

[sr-dev] git:master:e28f4644: siptrace: trace incoming CANCEL into a dedicated callback

2020-04-06 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: e28f464457eea47cc606c73cbfe4b30fcc8b542a URL: https://github.com/kamailio/kamailio/commit/e28f464457eea47cc606c73cbfe4b30fcc8b542a Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-03T11:59:50+02:00 siptrace: trace incoming CANCEL

[sr-dev] git:master:b64b3f03: siptrace: don't check if trace is off in ack for negative replies callback

2020-04-06 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: b64b3f03a9c6b69587ca360465f091f873f7274b URL: https://github.com/kamailio/kamailio/commit/b64b3f03a9c6b69587ca360465f091f873f7274b Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2020-04-03T10:00:53+02:00 siptrace: don't check if trace is off

Re: [sr-dev] [kamailio/kamailio] siptrace flag fixes (#2273)

2020-04-06 Thread Federico Cabiddu
Agree that such functions could be very useful in cases like this one. Should I backport to 5.3? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio/kamailio] Grumvalski/siptrace flag fixes (#2273)

2020-04-05 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] siptrace inconsistency

2020-04-05 Thread Federico Cabiddu
garding the negative ACK, maybe getting the invite transaction and > seeing if it is a failed transaction is an option. Or simply adding in tm > module a callback for negative ACK. > > Cheers, > Daniel > On 03.04.20 13:48, Federico Cabiddu wrote: > > Hi all, > foll

Re: [sr-dev] siptrace inconsistency

2020-04-03 Thread Federico Cabiddu
generated CANCEL (timeout) All looks good (except for the ACK issue) in both modes. I would like to have the developers' feedback before opening a PR, there could be other scenarios/use cases I'm not considering here. Thank you all. Cheers, Federico On Wed, Apr 1, 2020 at 2:45 PM Federico Cabi

Re: [sr-dev] [kamailio/kamailio] Kamailio ignore 404 as part of transaction during REGISTER (#2271)

2020-04-02 Thread Federico Cabiddu
As Daniel already replied you, SIP replies are handled in reply routes based on Via. You are posting a request route snippet which doesn't handle at all replies. Please do what has been asked to you, write on the users mailing list and there people will tell you if it is a bug or not. On Thu,

Re: [sr-dev] siptrace inconsistency

2020-04-01 Thread Federico Cabiddu
Hi, > OK, indeed, the previous behavior should be preserved in this case. Is > sip_trace() without params now doing transaction mode capturing? > Yes and no. Transaction mode is activated but actual behavior is not exactly the same (see case 3) vs case 1)). Cheers, Federico

Re: [sr-dev] siptrace inconsistency

2020-04-01 Thread Federico Cabiddu
hat's it for > the transaction. > > Feel free to clarify (or propose) the wanted behaviour and then we can > work together to have it as expected. I used sip trace lately for tracing > all traffic (trace_mode=1), no longer doing any filtering for > transactions/dialogs. > > Chee

[sr-dev] siptrace inconsistency

2020-03-31 Thread Federico Cabiddu
Hi all, I've been recently testing 5.3.x/master siptrace module, in particular the new trace mode "t" vs the legacy flag + sip_trace() mode and I've found some issues with the handling of CANCEL. Specifically, I've tested the following scenarios: 1) sip_trace_mode("t") on the initial INVITE only:

[sr-dev] git:master:2ad60234: tm: initialize the context before running event route

2019-11-25 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 2ad6023432ae37b1709638ead2c77e1e4130678a URL: https://github.com/kamailio/kamailio/commit/2ad6023432ae37b1709638ead2c77e1e4130678a Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-11-25T09:14:40+01:00 tm: initialize the context before

Re: [sr-dev] [kamailio/kamailio] tm: add support for dropping messages in local-request event route (#2147)

2019-11-25 Thread Federico Cabiddu
Merged #2147 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2147#event-2829172430___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:00f4147a: tm: add support for dropping messages in local-request event route

2019-11-25 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 00f4147a410990d3ebeeef8825329bbdff728d1a URL: https://github.com/kamailio/kamailio/commit/00f4147a410990d3ebeeef8825329bbdff728d1a Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-11-25T08:51:30+01:00 tm: add support for dropping messages

Re: [sr-dev] [kamailio/kamailio] tm: add support for dropping messages in local-request event route (#2147)

2019-11-25 Thread Federico Cabiddu
I did put it in the core to avoid conflicts with other returned codes and for beeing used in the future (in case). I'll leave it in the core. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] tm: add support for dropping messages in local-request event route (#2147)

2019-11-25 Thread Federico Cabiddu
I haven't spotted any other usage for the moment. I could rename it like E_LOCAL_DROP. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] tm: add support for dropping messages in local-request event route (#2147)

2019-11-25 Thread Federico Cabiddu
right, added now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2147#issuecomment-558041500___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] tm: add support for dropping messages in local-request event route (#2147)

2019-11-25 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 2ad6023432ae37b1709638ead2c77e1e4130678a tm: initialize the context before running event route -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] tm: add support for dropping messages in local-request event route (#2147)

2019-11-25 Thread Federico Cabiddu
@grumvalski pushed 1 commit. b58bfec2413a09568343fa1e2b2e199cfaa2e1fa tm: initialize the context before running event route -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[sr-dev] [kamailio/kamailio] tm: add support for dropping messages in local-request event route (#2147)

2019-11-25 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-21 Thread Federico Cabiddu
The patches applied cleanly on both branches, I needed a couple of days to test. I've cherry-picked the commit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:5.3:c3392b75: core: add support for parsing http/2 replies parsing

2019-11-21 Thread Federico Cabiddu
Module: kamailio Branch: 5.3 Commit: c3392b750ebe70db7aee8928fd40b704af23a5d9 URL: https://github.com/kamailio/kamailio/commit/c3392b750ebe70db7aee8928fd40b704af23a5d9 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-11-21T11:27:35+01:00 core: add support for parsing http/2

[sr-dev] git:5.2:18444d61: core: add support for parsing http/2 replies parsing

2019-11-21 Thread Federico Cabiddu
Module: kamailio Branch: 5.2 Commit: 18444d619b87c3734f3078f09c50a4fef1f8a259 URL: https://github.com/kamailio/kamailio/commit/18444d619b87c3734f3078f09c50a4fef1f8a259 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-11-21T11:26:53+01:00 core: add support for parsing http/2

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-18 Thread Federico Cabiddu
Merged #2132 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2132#event-2807447284___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:17be3610: core: add support for parsing http/2 replies parsing

2019-11-18 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 17be36102e3a1c286c69a5da193dd8405000ab62 URL: https://github.com/kamailio/kamailio/commit/17be36102e3a1c286c69a5da193dd8405000ab62 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-11-16T16:33:04+01:00 core: add support for parsing http/2

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-18 Thread Federico Cabiddu
I agree that the usage of http/2 will become more and more common. If you agree, I'll also backport it to 5.2.x since this is still a supported version. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-16 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 17be36102e3a1c286c69a5da193dd8405000ab62 core: add support for parsing http/2 replies parsing -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-15 Thread Federico Cabiddu
grumvalski commented on this pull request. > @@ -47,7 +47,10 @@ #define SIP_VERSION_LEN 7 #define HTTP_VERSION "HTTP/1." -#define HTTP_VERSION_LEN (sizeof(HTTP_VERSION)-1) +#define HTTP_VERSION_LEN (sizeof(HTTP2_VERSION)-1) Yes, it was not done intentionally. I'll fix and force push if you

[sr-dev] [kamailio/kamailio] core: add support for parsing http/2 replies parsing (#2132)

2019-11-15 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] q_malloc crash on Kamailio 5.2.3 with http_async_query function (#2091)

2019-10-08 Thread Federico Cabiddu
Thank you for looking at it Daniel! Sincerely I don't understand how this issue is only appearing now, since the code hasn't changed since the very beginning. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] q_malloc crash on Kamailio 5.2.3 with http_async_query function (#2091)

2019-10-06 Thread Federico Cabiddu
Hi, I tested your scenario (calling http_async_query from diaog:end event route) but I haven't been able to reproduce the crash so far, neither with 5.2.3 nor with master. Is the crash systematic for you? Is there any other operation you are doing in your script before calling the http_async?

[sr-dev] git:5.2:e8c6a8fb: dialog: run DLGCB_LOADED callbacks when loading dialog from db

2019-09-17 Thread Federico Cabiddu
Module: kamailio Branch: 5.2 Commit: e8c6a8fbd1b16ddd1b8c9180aaf27dcd5cc9e05c URL: https://github.com/kamailio/kamailio/commit/e8c6a8fbd1b16ddd1b8c9180aaf27dcd5cc9e05c Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-09-17T14:35:53+02:00 dialog: run DLGCB_LOADED callbacks when

Re: [sr-dev] [kamailio/kamailio] dialog: run DLGCB_LOADED callbacks when loading dialog from db (#2066)

2019-09-17 Thread Federico Cabiddu
Merged #2066 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2066#event-2639721028___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:10037f65: dialog: run DLGCB_LOADED callbacks when loading dialog from db

2019-09-17 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 10037f658cd1657275f383314b6960715c17ea39 URL: https://github.com/kamailio/kamailio/commit/10037f658cd1657275f383314b6960715c17ea39 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-09-17T07:52:29+02:00 dialog: run DLGCB_LOADED callbacks

Re: [sr-dev] [kamailio/kamailio] dialog: run DLGCB_LOADED callbacks when loading dialog from db (#2066)

2019-09-17 Thread Federico Cabiddu
Thanks. I'm going to merge and backport to 5.2 (where the new functions have been introduced). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dialog: run DLGCB_LOADED callbacks when loading dialog from db (#2066)

2019-09-16 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 10037f658cd1657275f383314b6960715c17ea39 dialog: run DLGCB_LOADED callbacks when loading dialog from db -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dialog: run DLGCB_LOADED callbacks when loading dialog from db (#2066)

2019-09-14 Thread Federico Cabiddu
Thans for looking Henning, I fixed the indentation (automatic editor settings) and push a new commit. I can rebase/squash before merging. Yes, the fix should also work for dlg_db_load_extra (mode 2 for the function). -- You are receiving this because you are subscribed to this thread. Reply to

Re: [sr-dev] [kamailio/kamailio] dialog: run DLGCB_LOADED callbacks when loading dialog from db (#2066)

2019-09-14 Thread Federico Cabiddu
@grumvalski pushed 1 commit. 1d6a06c5cdef9665ec473817235856c22a79949f dialog: fix indentation -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[sr-dev] [kamailio/kamailio] dialog: run DLGCB_LOADED callbacks when loading dialog from db (#2066)

2019-09-14 Thread Federico Cabiddu
When a specific dialog is loaded from db via dlg_db_load_callid, the load callbacks are not executed so, for example, a CDR is not generated. No sure if this should considered a new feature or a bug (and so eventually be backported). You can view, comment on, or merge this pull request online

Re: [sr-dev] [kamailio/kamailio] db_redis: add examples about usage with dialog module (#2059)

2019-09-08 Thread Federico Cabiddu
Merged #2059 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2059#event-2616626216___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:86990ab5: db_redis: add examples about usage with dialog module

2019-09-08 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 86990ab53c4b5e5ede49b95e17b02f96ae00a01c URL: https://github.com/kamailio/kamailio/commit/86990ab53c4b5e5ede49b95e17b02f96ae00a01c Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-09-08T09:56:43+02:00 db_redis: add examples about usage

[sr-dev] git:5.2:761758b1: dialog: check xdata length when loading profile from db

2019-09-08 Thread Federico Cabiddu
Module: kamailio Branch: 5.2 Commit: 761758b1d8a7ebdb72caf8d5442a38988cf2e951 URL: https://github.com/kamailio/kamailio/commit/761758b1d8a7ebdb72caf8d5442a38988cf2e951 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-09-08T10:20:56+02:00 dialog: check xdata length when loading

[sr-dev] git:5.1:75dc482c: dialog: check xdata length when loading profile from db

2019-09-08 Thread Federico Cabiddu
Module: kamailio Branch: 5.1 Commit: 75dc482cf327e3a707281f903c7e75d3b28cf52c URL: https://github.com/kamailio/kamailio/commit/75dc482cf327e3a707281f903c7e75d3b28cf52c Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-09-08T10:20:36+02:00 dialog: check xdata length when loading

Re: [sr-dev] [kamailio/kamailio] dialog: check xdata length when loading profile from db (#2058)

2019-09-08 Thread Federico Cabiddu
Merged #2058 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2058#event-2616624497___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:d05dfc20: dialog: check xdata length when loading profile from db

2019-09-08 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: d05dfc20632fde1d65017ff5d7f41713a9c79825 URL: https://github.com/kamailio/kamailio/commit/d05dfc20632fde1d65017ff5d7f41713a9c79825 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-09-08T09:01:10+02:00 dialog: check xdata length when

[sr-dev] [kamailio/kamailio] db_redis: add examples about usage with dialog module (#2059)

2019-09-08 Thread Federico Cabiddu
Small contribution to db_redis module documentation. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2059 -- Commit Summary -- * db_redis: add examples about usage with dialog module -- File Changes -- M

[sr-dev] [kamailio/kamailio] dialog: check xdata length when loading profile from db (#2058)

2019-09-08 Thread Federico Cabiddu
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [SR-Users] RFC: about sl and tm local-response event routes

2019-08-27 Thread Federico Cabiddu
-response to local-response-sent (I don't > remember any discussion about people using it, I checked the commit log and > was added by Peter Dunkley several years ago, I never used it so far). > > Cheers, > Daniel > On 27.08.19 16:04, Federico Cabiddu wrote: > > Hi Daniel, > per

Re: [sr-dev] [SR-Users] RFC: about sl and tm local-response event routes

2019-08-27 Thread Federico Cabiddu
Hi Daniel, personally I have just one case of local-request, so it wouldn't hurt too much this change that brings consistency. Cheers, Federico On Tue, Aug 27, 2019 at 1:37 PM Daniel-Constantin Mierla wrote: > Hello, > > just discovered what I consider to be an inconsistency in naming and >

[sr-dev] git:5.1:a792b1cf: siptrace: check if trace_to_database is set before checking the db connection

2019-08-27 Thread Federico Cabiddu
Module: kamailio Branch: 5.1 Commit: a792b1cfd927e1c29385a229d82b96c91b86b9ab URL: https://github.com/kamailio/kamailio/commit/a792b1cfd927e1c29385a229d82b96c91b86b9ab Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-08-27T09:28:12+02:00 siptrace: check if trace_to_database

[sr-dev] git:5.2:94b60464: siptrace: check if trace_to_database is set before checking the db connection

2019-08-27 Thread Federico Cabiddu
Module: kamailio Branch: 5.2 Commit: 94b60464c9ccac49ebae238aa42ae16fb2c5f9ec URL: https://github.com/kamailio/kamailio/commit/94b60464c9ccac49ebae238aa42ae16fb2c5f9ec Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-08-27T09:27:54+02:00 siptrace: check if trace_to_database

Re: [sr-dev] [kamailio/kamailio] siptrace: check if trace_to_database is set before checking the db co… (#2047)

2019-08-27 Thread Federico Cabiddu
Merged #2047 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2047#event-2586033125___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:afd0c929: siptrace: check if trace_to_database is set before checking the db connection

2019-08-27 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: afd0c929dc72a975e2ca3c88f307fd8c140a4fda URL: https://github.com/kamailio/kamailio/commit/afd0c929dc72a975e2ca3c88f307fd8c140a4fda Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-08-26T20:21:13+02:00 siptrace: check if trace_to_database

[sr-dev] [kamailio/kamailio] siptrace: check if trace_to_database is set before checking the db co… (#2047)

2019-08-27 Thread Federico Cabiddu
…nnection !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch

Re: [sr-dev] [kamailio/kamailio] TCP ACK is going to different IP then original invite sent (#1998)

2019-07-02 Thread Federico Cabiddu
that's already the case if you use IP addresses in 200 OK => ACK. The parameter you are speaking can not be implemented in core modules like tm, because that would mean implementing a tracking between transactions which is totally out of scope for those modules. Again, mechanisms external

Re: [sr-dev] [kamailio/kamailio] TCP ACK is going to different IP then original invite sent (#1998)

2019-07-02 Thread Federico Cabiddu
I'm afraid that this is perfectly legitimate proxy behavior as per RFC. If your 200 OK contact contains a FQDN as domain part, the ACK will have it in the R-URI and Kamailio will forcefully have to resolve it before relaying and there is no guarantee that the result will be the same. Also don't

Re: [sr-dev] Additional headers on a dispatcher options ping

2019-05-31 Thread Federico Cabiddu
> Does that actually work? I thought this route provides a hook to catch > the request, but does not necessarily apply any lump changes to the > outgoing message? > > On Fri, May 31, 2019 at 07:27:34AM +0200, Federico Cabiddu wrote: > > > Hi, > > to add headers to

Re: [sr-dev] Additional headers on a dispatcher options ping

2019-05-30 Thread Federico Cabiddu
Hi, to add headers to locally generated requests, as it's the case for dispatcher's OPTIONS, you could use tm's module "local-request" event route to catch the outgoing OPTIONS and append a header before it's relayed. Something like this: event_route[tm:local-request] { # Handle locally generated

Re: [sr-dev] [kamailio/kamailio] Siptrace (#1912)

2019-04-02 Thread Federico Cabiddu
grumvalski commented on this pull request. Thanks! Looks fine, just a small comment on the doc. > @@ -656,6 +654,11 @@ hlog("$hdr(P-MyID)", "Another one with a custom > correlation ID"); Stateless forwarded messages (forward()) are not logged if you set the flag, use

Re: [sr-dev] [kamailio/kamailio] Small notes on $http_req(timeout) usage. (#1913)

2019-03-29 Thread Federico Cabiddu
You're right, I missed it sorry. Federico On Fri, Mar 29, 2019 at 9:36 AM Daniel-Constantin Mierla < notificati...@github.com> wrote: > @samael33 , @grumvalski > -- the commit messages on this pull are > really inappropriate for

Re: [sr-dev] [kamailio/kamailio] Small notes on $http_req(timeout) usage. (#1913)

2019-03-29 Thread Federico Cabiddu
Merged #1913 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1913#event-2238374358___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] Small notes on $http_req(timeout) usage. (#1913)

2019-03-28 Thread Federico Cabiddu
grumvalski commented on this pull request. Thank you! Just a small comment on the PR. > @@ -435,7 +435,7 @@ xlog("L_INFO", "received reply for query $http_req_id\n"); hdr: sets/modifies/removes a HTTP header. N.B.: setting this variable multiple times will add several headers

[sr-dev] git:master:4a2f5334: http_async_client: add ifdef/endif block for tcp_keepalive

2019-02-09 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 4a2f5334e898b0c1aaffdd73cae205c9fee43f37 URL: https://github.com/kamailio/kamailio/commit/4a2f5334e898b0c1aaffdd73cae205c9fee43f37 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-02-09T16:16:50+01:00 http_async_client: add ifdef/endif

Re: [sr-dev] [kamailio/kamailio] dmq: wait for a 2nd failed ping before deleting a node (#1840)

2019-02-07 Thread Federico Cabiddu
Merged #1840 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1840#event-2124046795___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] dmq: wait for a 2nd failed ping before deleting a node (#1840)

2019-02-07 Thread Federico Cabiddu
Mergin, thank you :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1840#issuecomment-461418016___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:8ffcb5f7: dmq: wait for a 2nd failed ping before deleting a node

2019-02-07 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 8ffcb5f7fee8223b4857135d3d64ac4414bf87a2 URL: https://github.com/kamailio/kamailio/commit/8ffcb5f7fee8223b4857135d3d64ac4414bf87a2 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-02-07T11:39:27+01:00 dmq: wait for a 2nd failed ping

Re: [sr-dev] [kamailio/kamailio] dmq: wait for a 2nd failed ping before deleting a node (#1840)

2019-02-07 Thread Federico Cabiddu
I discovered the problem exactly because I wanted to fail quickly, having a global fr_timer of 5 s. IMHO the patch as it is doesn't affect the capability to fail quickly since a node is taken off the nodelist for message broadcasting immediately, except for the ping. I would say that it

Re: [sr-dev] [kamailio/kamailio] dmq: wait for a 2nd failed ping before deleting a node (#1840)

2019-02-07 Thread Federico Cabiddu
Definitely :) Should I merge and backport this one? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1840#issuecomment-461376790___

[sr-dev] [kamailio/kamailio] dmq: wait for a 2nd failed ping before deleting a node (#1840)

2019-02-07 Thread Federico Cabiddu
Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for

[sr-dev] git:5.1:f1c3c374: jsonrpcs: fix double free crash

2019-02-07 Thread Federico Cabiddu
Module: kamailio Branch: 5.1 Commit: f1c3c3748a709c6c7cd1a6ff43a3d23ef97c1771 URL: https://github.com/kamailio/kamailio/commit/f1c3c3748a709c6c7cd1a6ff43a3d23ef97c1771 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-02-07T09:39:32+01:00 jsonrpcs: fix double free crash (cherry

Re: [sr-dev] [kamailio/kamailio] jsonrpcs: fix double free crash (#1839)

2019-02-07 Thread Federico Cabiddu
Merged #1839 into master. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1839#event-2123391668___ Kamailio (SER) - Development Mailing List

[sr-dev] git:5.2:f247933a: jsonrpcs: fix double free crash

2019-02-07 Thread Federico Cabiddu
Module: kamailio Branch: 5.2 Commit: f247933aac6ada6147ce83943cca87b24805e96f URL: https://github.com/kamailio/kamailio/commit/f247933aac6ada6147ce83943cca87b24805e96f Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-02-07T09:39:04+01:00 jsonrpcs: fix double free crash (cherry

[sr-dev] git:master:9dc5cbaa: jsonrpcs: fix double free crash

2019-02-07 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 9dc5cbaa4f078adee0a061885965494a9364e5d0 URL: https://github.com/kamailio/kamailio/commit/9dc5cbaa4f078adee0a061885965494a9364e5d0 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-02-07T09:23:01+01:00 jsonrpcs: fix double free crash

Re: [sr-dev] [kamailio/kamailio] jsonrpcs: fix double free crash (#1839)

2019-02-07 Thread Federico Cabiddu
Yes, was added in 8e5742ff1657bdb2adce357fc6f1a2e04fd913c6. On Thu, Feb 7, 2019 at 9:31 AM Daniel-Constantin Mierla < notificati...@github.com> wrote: > Was this added in a recent commit, right? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email

[sr-dev] [kamailio/kamailio] jsonrpcs: fix double free crash (#1839)

2019-02-07 Thread Federico Cabiddu
Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for

[sr-dev] git:master:5afe4863: http_async_client: add documentation for new TCP keepalive parameters

2019-02-06 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 5afe486375ae1ec8d7e479e579d5cc898fa1bac5 URL: https://github.com/kamailio/kamailio/commit/5afe486375ae1ec8d7e479e579d5cc898fa1bac5 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-02-06T17:17:17+01:00 http_async_client: add documentation

[sr-dev] git:master:a8e5f411: http_async_client: add parameters to enable/set tcp keepalive

2019-02-06 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: a8e5f411c4ab46b3c418533440e523d69a88aeb7 URL: https://github.com/kamailio/kamailio/commit/a8e5f411c4ab46b3c418533440e523d69a88aeb7 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-02-06T17:16:18+01:00 http_async_client: add parameters

[sr-dev] git:master:18ef9da4: tsilo: fixed ts_append example in the doc

2019-01-28 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 18ef9da4c029fefd5089aed484cd8f32ddb0fb17 URL: https://github.com/kamailio/kamailio/commit/18ef9da4c029fefd5089aed484cd8f32ddb0fb17 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-01-28T20:56:55+01:00 tsilo: fixed ts_append example

[sr-dev] git:5.2:bb9661c5: tsilo: fixed ts_append example in the doc

2019-01-28 Thread Federico Cabiddu
Module: kamailio Branch: 5.2 Commit: bb9661c595201ab6ce69e34e6084630be7faa307 URL: https://github.com/kamailio/kamailio/commit/bb9661c595201ab6ce69e34e6084630be7faa307 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-01-28T20:58:35+01:00 tsilo: fixed ts_append example

[sr-dev] git:5.1:f727b05a: tsilo: fixed ts_append example in the doc

2019-01-28 Thread Federico Cabiddu
Module: kamailio Branch: 5.1 Commit: f727b05ad76c1b22ddba8b3aed311084c260c588 URL: https://github.com/kamailio/kamailio/commit/f727b05ad76c1b22ddba8b3aed311084c260c588 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-01-28T20:58:58+01:00 tsilo: fixed ts_append example

[sr-dev] git:5.1:8a21170c: siptrace: don't calculate message source socket if already set

2019-01-17 Thread Federico Cabiddu
Module: kamailio Branch: 5.1 Commit: 8a21170c3a5283b84e0ff3cbc6db8c72413dec05 URL: https://github.com/kamailio/kamailio/commit/8a21170c3a5283b84e0ff3cbc6db8c72413dec05 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-01-17T09:43:47+01:00 siptrace: don't calculate message source

[sr-dev] git:5.2:b7193895: siptrace: don't calculate message source socket if already set

2019-01-17 Thread Federico Cabiddu
Module: kamailio Branch: 5.2 Commit: b71938952e1fc7543fa5bf7ba2abed6e39167150 URL: https://github.com/kamailio/kamailio/commit/b71938952e1fc7543fa5bf7ba2abed6e39167150 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-01-17T09:43:29+01:00 siptrace: don't calculate message source

[sr-dev] git:master:929a24f0: siptrace: don't calculate message source socket if already set

2019-01-17 Thread Federico Cabiddu
Module: kamailio Branch: master Commit: 929a24f08aeef6b72999ac9b188ffeded40759a9 URL: https://github.com/kamailio/kamailio/commit/929a24f08aeef6b72999ac9b188ffeded40759a9 Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2019-01-16T18:09:42+01:00 siptrace: don't calculate message

Re: [sr-dev] [kamailio/kamailio] siptrace: siptrace: don't calculate message source socket if already set (#1810)

2019-01-17 Thread Federico Cabiddu
Merged #1810 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1810#event-2079555129___ Kamailio (SER) - Development Mailing

[sr-dev] [kamailio/kamailio] siptrace: siptrace: don't calculate message source socket if already set (#1810)

2019-01-16 Thread Federico Cabiddu
When trace_mode = 1, the source socket of an outgoing message can be retrieved from the payload passed in the callback of SREV_NET_DATA_SEND. Otherwise, if the socket has been manually forced (setting $fs, calling force_send_socket..), the information will be overwritten and the actual source

Re: [sr-dev] [kamailio/kamailio] tsilo: add check for empty aor (#1802)

2019-01-10 Thread Federico Cabiddu
Merged #1802 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1802#event-2065239829___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] TSILO crashes kamailio on ts_store() (#1775)

2019-01-10 Thread Federico Cabiddu
Closed #1775 via #1802. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1775#event-2065239834___ Kamailio (SER) - Development Mailing

<    1   2   3   >