[sr-dev] Re: [kamailio/kamailio] new db_mysql warnings when Kamailio starts (Issue #3884)

2024-06-19 Thread juha-h via sr-dev
Reopened #3884. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3884#event-13214523439 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mail

[sr-dev] Re: [kamailio/kamailio] new db_mysql warnings when Kamailio starts (Issue #3884)

2024-06-19 Thread juha-h via sr-dev
This issue was about `opt_ssl_ca option` warnings and they still show up. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3884#issuecomment-2178390317 You are receiving this because you are subscribed to this thread. Message ID: _

[sr-dev] [kamailio/kamailio] new db_mysql warnings when Kamailio starts (Issue #3884)

2024-06-19 Thread juha-h via sr-dev
When I start Kamailio master version that has been built on Debian 12 with default-libmysqlclient-dev depending on libmariadb-dev-compat, several warnings like this are produced: ``` 2024-06-17T14:48:27.702827+03:00 siika /usr/bin/sip-proxy[297246]: WARNING: db_mysql [km_my_con.c:187]: db_mysql_

[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

2024-05-20 Thread juha-h via sr-dev
Daniel-Constantin Mierla writes: > Yes, it can be cherry-picked, it is about a mandatory header. Done. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120834113 You are receiving this because you are subscribed to this thread.

[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

2024-05-20 Thread juha-h via sr-dev
Is it OK to cherry-pick this to 5.8 branch? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120256287 You are receiving this because you are subscribed to this thread. Message ID: ___ K

[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

2024-05-20 Thread juha-h via sr-dev
juha-h writes: > Goes beyond me. In baresip project, nothing like that needs to be > done. If there is new commit to PR, all checks are automatically > re-run. ... and red marks turn green without any extra action. -- Reply to this email directly or view it on GitHub: https://github.com/kam

[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

2024-05-20 Thread juha-h via sr-dev
Victor Seva writes: > Just create one commit with the proper commit message prefix squashing > both previous commits in the branch. Goes beyond me. In baresip project, nothing like that needs to be done. If there is new commit to PR, all checks are automatically re-run. -- Reply to this emai

[sr-dev] Re: [kamailio/kamailio] Add mandatory Max-Forwards header to local ACK (PR #3856)

2024-05-20 Thread juha-h via sr-dev
Same checks bug as earlier: according to Details, check-format PASSED, but there still claim that `Some checks were not successful`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120012806 You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] Add mandatory Max-Forwards header to local ACK (PR #3856)

2024-05-20 Thread juha-h via sr-dev
@juha-h pushed 1 commit. 91747524b2e4b34fa1b68c8d5b0e0473cf2f2ff8 Run clang-format on the file -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3856/files/b9b90eb6ea5cb20466a74a739338d6fe25226438..91747524b2e4b34fa1b68c8d5b0e0473cf2f2ff8 You are receiving this because you are sub

[sr-dev] [kamailio/kamailio] Add mandatory Max-Forwards header to local ACK (PR #3856)

2024-05-20 Thread juha-h via sr-dev
Type Of Change - [ x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [x ] PR should be backported to stable branches - [

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
After the first commit. there was format issues that I tried to fix manually and pushed another commit. After that, format check was re-run automatically and one more format issue remained. I fixed also that, push a new commit, and again format check was re-run automatically. Now the format c

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
How about the failing format check? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110621100 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
> If you want to test README generation locally, then you are missing some > dockbook-relate packages, likely `docbook-xsl`. README generation worked after I installed Debian package `docbook-xsl`. For some reason make command as described here [https://www.kamailio.org/wikidocs/devel/module-d

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
Daniel-Constantin Mierla writes: > One can generate readme locally only for checking it if it is correct, > but then reverted before committing. That is exactly what I tried to do according to instructions, but generation failed. Also, there is something wrong with the format check. It shows re

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
@juha-h pushed 1 commit. 6992d1784aa3e1f96aa3a406f25675178605108d More format changes -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3849/files/4ccadb7ed3a762ec1d2781e783f760f6de4b588e..6992d1784aa3e1f96aa3a406f25675178605108d You are receiving this because you are subscribed t

[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
@juha-h pushed 1 commit. 4ccadb7ed3a762ec1d2781e783f760f6de4b588e Format changes -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3849/files/4a1aa23d6b1d8bb90f267b64a33b25beb2b0977c..4ccadb7ed3a762ec1d2781e783f760f6de4b588e You are receiving this because you are subscribed to thi

[sr-dev] [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)

2024-05-14 Thread juha-h via sr-dev
Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches -

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread juha-h via sr-dev
I'm fine with the above solution and can close this issue. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3843#issuecomment-2098939975 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread juha-h via sr-dev
Closed #3843 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3843#event-12732879781 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Devel

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread juha-h via sr-dev
With async_task_data() I got it working like this: ``` event_route [tcp:closed] { # Handle TCP connection close # Delete possible leftover registration if ($conid) { async_task_data("clean_location", "$conid"); } route [clean_location] { sql_query_async("sip_proxy_cache", "DEL

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread juha-h via sr-dev
Yes, I'm getting the same error message with sql_query_async: ``` 2024-05-07T19:02:24.167462+03:00 siika /usr/bin/sip-proxy[2948257]: CRITICAL: sqlops [sqlops.c:213]: sql_check_connection(): no database handle with reconnect disabled 2024-05-07T19:02:24.167640+03:00 siika /usr/bin/sip-proxy[29482

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread juha-h via sr-dev
I tried with async module, but always got error ``` 2024-05-07T17:31:16.143660+03:00 siika /usr/bin/sip-proxy[2910444]: ERROR: async [async_mod.c:462]: ki_async_task_group_route(): invalid usage for faked message ``` and when I read async module README, all its functions deal with SIP request pr

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread juha-h via sr-dev
In order to avoid any performance issues, I tried to change the query from ``` sql_query("sip_proxy_cache", "DELETE FROM location WHERE server_id=0 AND connection_id=$conid", "result"); ``` to ``` sql_query_async("sip_proxy_cache", "DELETE FROM location WHERE server_id=0 AND connection_id=$conid

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread juha-h via sr-dev
As I wrote, this used to work for many years and now it does not. It is very important to be able to delete the possible leftover registration if tcp connection from the SIP UA get closed due to some failure situation. Is there somewhere an example how to migrate the above event route action to

[sr-dev] Re: [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread juha-h via sr-dev
Same error with `event_route [websocket:closed]`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3843#issuecomment-2097918824 You are receiving this because you are subscribed to this thread. Message ID: _

[sr-dev] [kamailio/kamailio] sql_query fails from tcp:closed event_route (Issue #3843)

2024-05-07 Thread juha-h via sr-dev
### Description I noticed that sql_query does not work (using latest 5.8 on Debian 12) when called from `tcp:closed` event_route: ``` event_route [tcp:closed] { # Handle TCP connection close # Delete possible leftover registration if ($conid) sql_query("sip_proxy_cache", "DELETE

[sr-dev] Re: [kamailio/kamailio] Make tcp_check_timer default to depend on tcp_msg_data_timeout and tcp_msg_read_timeout values (PR #3608)

2023-10-19 Thread juha-h via sr-dev
Don't know why `check-format (pull_request)` failed again, because latest commit 38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a... PASSED. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3608#issuecomment-1770663120 You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] Make tcp_check_timer default to depend on tcp_msg_data_timeout and tcp_msg_read_timeout values (PR #3608)

2023-10-19 Thread juha-h via sr-dev
@juha-h pushed 1 commit. 38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a Trying to fix format -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3608/files/dd9d828a782c0c132c536a97beb792176928a716..38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a You are receiving this because you are subscribed

[sr-dev] [kamailio/kamailio] Make tcp_check_timer default to depend on tcp_msg_data_timeout and tcp_msg_read_timeout values (PR #3608)

2023-10-19 Thread juha-h via sr-dev
If `tcp_check_timer` is not set, use default value that is half of `tcp_msg_data_timeout` or `tcp_msg_read_timeout` value depending on which one is smaller and not zero. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3608 -- Commit