[sr-dev] [kamailio/kamailio] tm: T_ASYNC_SUSPENDED flag not removed when cancelling a suspension (PR #3629)

2023-11-06 Thread mtryfoss via sr-dev
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] [kamailio/kamailio] ims_charging: Implemented restore of Ro sessions from database (PR #3622)

2023-10-30 Thread mtryfoss via sr-dev
- realtime and shutdown mode support - removed duplicate entry in doc about ro_auth_expiry - RO_TABLE_VERSION constant did not match inserted value in db schema !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read:

[sr-dev] Re: [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)

2023-10-25 Thread mtryfoss via sr-dev
Sorry - closed by mistake. Reopened. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616#issuecomment-1778680443 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] Re: [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)

2023-10-25 Thread mtryfoss via sr-dev
There's a big "#if OPENSSL_VERSION_NUMBER >= 0x1010L" in cdp_tls.c, basically making the whole file empty for older versions. sp->tls_conn would never be true in do_read() and do_write() if there was no supported openssl, so I didn't find any need to change those functions - until your mod

[sr-dev] Re: [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)

2023-10-25 Thread mtryfoss via sr-dev
Reopened #3616. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616#event-10763326569 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

[sr-dev] Re: [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)

2023-10-25 Thread mtryfoss via sr-dev
Closed #3616. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616#event-10763322155 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)

2023-10-25 Thread mtryfoss via sr-dev
This was originaly fixed in #3601, but that did not handle the change in #3612 very well. !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be

[sr-dev] [kamailio/kamailio] ims_dialog: Add function to get dialog by hash entry and id (PR #3613)

2023-10-24 Thread mtryfoss via sr-dev
Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing

[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)

2023-10-19 Thread mtryfoss via sr-dev
My plan is to have this merged and then continue working on db operations for the ims_charging module. I just wanted to have this completed first, since the other part will not work without it. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)

2023-10-19 Thread mtryfoss via sr-dev
Like I wrote in the ticket related to this task, most of the stuff was there already - but it both caused a crash and was not fully functional. Entries were being written to the database, but was not restored correctly on startup. I assume the old dialog module was used as a basis and that the

[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)

2023-10-13 Thread mtryfoss via sr-dev
Seems like there's some issue with the CodeQL Analyzer (runner image out of disk space)? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3603#issuecomment-1761472985 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)

2023-10-13 Thread mtryfoss via sr-dev
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] [kamailio/kamailio] ims_dialog: Support for db storage (Issue #3602)

2023-10-11 Thread mtryfoss via sr-dev
### Description I've been looking at the ims_dialog module and notice that the documentation states that db storage is not yet supported. According to the source code that only partial true. Not sure if it's residues from the other dialog module, or some unfinished work. After some initial

[sr-dev] Re: [kamailio/kamailio] cdp: Disable TLS support for openssl versions older than 1.1.0 (PR #3601)

2023-10-11 Thread mtryfoss via sr-dev
I fixed the errors report by check-format in a new commit, but it stills seems to be marked as failed because of the first one. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3601#issuecomment-1757450838 You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] cdp: Disable TLS support for openssl versions older than 1.1.0 (PR #3601)

2023-10-11 Thread mtryfoss via sr-dev
@mtryfoss pushed 1 commit. 841d774dc1670987a6610ae1fe8f70b7b045f5d2 cdp: changed format -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3601/files/6bd5c508bb536efb516a608ffbcbd11f8e6dba89..841d774dc1670987a6610ae1fe8f70b7b045f5d2 You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] cdp: Not possible to load module with older openssl version than 1.1.0 (Issue #3600)

2023-10-11 Thread mtryfoss via sr-dev
PR created. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3600#issuecomment-1757373110 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

[sr-dev] [kamailio/kamailio] cdp: Disable TLS support for openssl versions older than 1.1.0 (PR #3601)

2023-10-11 Thread mtryfoss via sr-dev
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] [kamailio/kamailio] cdp: Not possible to load module with older openssl version than 1.1.1 (Issue #3600)

2023-10-11 Thread mtryfoss via sr-dev
### Description After adding TLS support to the CDP module, it's no longer possible to load on systems running a version of openssl older than 1.1.1. Reproduction Run on system with openssl older than 1.1.1. Log Messages ``` ERROR: [core/sr_module.c:599]: ksr_load_module():

[sr-dev] [kamailio/kamailio] smsops: avoid c99 error (PR #3597)

2023-10-10 Thread mtryfoss via sr-dev
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable