[sr-dev] [kamailio/kamailio] cdp deadlock (#1739)

2018-11-26 Thread thulasizwe-n
://github.com/kamailio/kamailio/pull/1739 -- Commit Summary -- * Add files via upload * Merge pull request #1 from thulasizwe-n/thulasizwe-n-patch-1 * fixed possible list corruption * cdp -- lockup fix -- File Changes -- A modules/routing.c (299) A msrp_env.c (226

Re: [sr-dev] [kamailio/kamailio] ims_usrloc_scscf: bugfix Contct is removed when old Contct expires (#1547)

2018-06-08 Thread thulasizwe-n
Hi @christoph-v Good fix...i see it's revealing another two potential issues on remove_impucontact_from_list same file (impurecord.c); 1) tail->next is not nullified on removing last impucontact--hence second last will still point to the "just-removed" impucontact 2)

Re: [sr-dev] [kamailio/kamailio] ims_charging unlink_unsafe_ro_session (#1549)

2018-06-07 Thread thulasizwe-n
Ok I'll do the pull request etc. Please forgive my unfamiliarity with kamailio patch standards...am in process of learning. Below is from modules/ims_charging/ro_session_hash.h function, I've just indicated patch changes as "+" static inline void unlink_unsafe_ro_session(struct

Re: [sr-dev] [kamailio/kamailio] ims_charging unlink_unsafe_ro_session (#1549)

2018-06-04 Thread thulasizwe-n
Sorry, previous supposed be as below.This must be first check if ((ro_session->next == 0x00) && (ro_session->prev == 0x00) && (ro_session != ro_session_entry->first) ) { return; } rest of the code -- You are receiving this because you are subscribed to this thread. Reply to

[sr-dev] [kamailio/kamailio] ims_charging unlink_unsafe_ro_session (#1549)

2018-05-28 Thread thulasizwe-n
Apologies if i have not kept with the reporting standard. Insertion attempts of out-of-credit replies from resume_on_initial_ccr callback, are corrupting the ro_session list. i.e. they nullify the first and last fields, which under certain conditions the first entry gets restored but not the