Re: [sr-dev] [kamailio/kamailio] xhttp_prom: added prom_counter_dec function (#2858)

2021-09-17 Thread vhernando
Hello Serguey, according to specifications https://prometheus.io/docs/concepts/metric_types/ counters should not decrease, if needed to decrease it recommends to use gauges instead. So what is the point of adding a forbidden feature? -- You are receiving this because you are subscribed to

Re: [sr-dev] [kamailio/kamailio] xhttp_prom: optional disabling of metrics deletion (#2430)

2020-10-06 Thread vhernando
Hello Henning, these changes are already included in latest big patch for xhttp_prom module in master branch along with new histogram feature. README updated too. Regards, Vicente. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [sr-dev] [kamailio/kamailio] xhttp_prom: add support for histogram metrics. (#2435)

2020-08-10 Thread vhernando
Merged #2435 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2435#event-3640518358___ Kamailio (SER) - Development Mailing

[sr-dev] [kamailio/kamailio] xhttp_prom: add support for histogram metrics. (#2435)

2020-08-10 Thread vhernando
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] xhttp_prom: optional disabling of metrics deletion (#2430)

2020-08-07 Thread vhernando
Thank you for your contribution, but I have it fixed in the next version for the module I am going soon to upload. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] xhttp_prom: optional disabling of metrics deletion (#2430)

2020-08-07 Thread vhernando
Closed #2430. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2430#event-3633806371___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] kafka: module to produce and send messages to a Kafka server (#2112)

2019-11-04 Thread vhernando
Merged #2112 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2112#event-2768479257___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] kafka: module to produce and send messages to a Kafka server (#2112)

2019-10-31 Thread vhernando
@vhernando pushed 1 commit. 4ae09ec3b1348df7c93c4a0e0f25e65acb223b49 kafka: comment about suitable versions of librdkafka library -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/2112/files

Re: [sr-dev] [kamailio/kamailio] kafka: module to produce and send messages to a Kafka server (#2112)

2019-10-30 Thread vhernando
@vhernando pushed 1 commit. fa9228b45b29e29b807d03e267d2cb328b882b3d kafka: comment about error return code for kafka_send function -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/2112/files

Re: [sr-dev] [kamailio/kamailio] kafka: module to produce and send messages to a Kafka server (#2112)

2019-10-30 Thread vhernando
@vhernando pushed 1 commit. 3052e563d80dd96de880bc68eed8f06bf6f6e753 kafka: delete optional word in kfk_logger function -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/2112/files

Re: [sr-dev] [kamailio/kamailio] kafka: module to produce and send messages to a Kafka server (#2112)

2019-10-30 Thread vhernando
vhernando commented on this pull request. > + + none. + + + + + + + External Libraries or Applications + + The following librar

Re: [sr-dev] [kamailio/kamailio] kafka: module to produce and send messages to a Kafka server (#2112)

2019-10-30 Thread vhernando
vhernando commented on this pull request. > + LM_DBG("Initializing statistics\n"); + + stats_lock = lock_alloc(); + if (!stats_lock) { + LM_ERR("Cannot allocate stats lock\n"); + return -1; + } + + if(lock_i

Re: [sr-dev] [kamailio/kamailio] kafka: module to produce and send messages to a Kafka server (#2112)

2019-10-30 Thread vhernando
@vhernando pushed 2 commits. f5539642dfda861e884283da3adb83338979e7b6 kafka: associate LOG_NOTICE to LM_NOTICE in kfk_logger a58e2f8bf7912f8c1d756cda346e0665edce9122 kafka: delete some debug code -- You are receiving this because you are subscribed to this thread. View it on GitHub: https

[sr-dev] [kamailio/kamailio] kafka: module to produce and send messages to a Kafka server (#2112)

2019-10-30 Thread vhernando
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] [kamailio/kamailio] xhttp_prom: module to generate Prometheus metrics. (#1976)

2019-06-07 Thread vhernando
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README

[sr-dev] [kamailio/kamailio] Textops in list prefix function (#1423)

2018-02-01 Thread vhernando
Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README

Re: [sr-dev] [kamailio/kamailio] app_lua: LUAJIT variable to build agains LuaJIT compiler (#1384)

2017-12-22 Thread vhernando
@vhernando pushed 2 commits. 55e3b72 app_lua: update doc about LUAJIT variable and building against LuaJIT libraries. 02723aa app_lua: README update -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1384/files

[sr-dev] [kamailio/kamailio] app_lua: LUAJIT variable to build agains LuaJIT compiler (#1384)

2017-12-22 Thread vhernando
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README

[sr-dev] [kamailio/kamailio] benchmark: b/f avoid undefined bytes when int and long int sizes mism… (#1146)

2017-06-02 Thread vhernando
…atch. void bm_rpc_enable_global(rpc_t* rpc, void* ctx) { long int v1; if(rpc->scan(ctx, "d", (int*)())<1) { rpc->scan does not fill all the bytes of v1 if long int and int sizes differ, then checks like this usually fail: if ((v1 < -1) || (v1 > 1)) {