Re: [sr-dev] [kamailio/kamailio] Crash in permissions module (#2151)

2019-12-03 Thread Victor Seva
@sjthomason it's not safe due to perm_dbf is not initialized. init_trusted() is not called. That's the origin of the crash. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Crash in permissions module (#2151)

2019-12-03 Thread Victor Seva
Closed #2151 via d7f4493da751802dc47a694d251d34a85a7b3bf1. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2151#event-2849587981___

Re: [sr-dev] [kamailio/kamailio] Crash in permissions module (#2151)

2019-12-02 Thread sjthomason
Hi Victor, The patch does indeed fix the crash. I've been looking at `init_child_trusted()` and should it not be safe to call it as written? This seems to be "safe": ``` if (!db_url.s) { return 0; } db_handle = perm_dbf.init(_url); if

Re: [sr-dev] [kamailio/kamailio] Crash in permissions module (#2151)

2019-11-27 Thread sjthomason
Thanks for the quick fix. I'll test soon and report back. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Crash in permissions module (#2151)

2019-11-27 Thread Victor Seva
can you try with this patch applied ``` diff --git a/src/modules/permissions/permissions.c b/src/modules/permissions/permissions.c index 7505bb3dd..dfb5a4afc 100644 --- a/src/modules/permissions/permissions.c +++ b/src/modules/permissions/permissions.c @@ -648,8 +648,10 @@ static int

[sr-dev] [kamailio/kamailio] Crash in permissions module (#2151)

2019-11-26 Thread sjthomason
### Description Crash in permissions module when `load_backends` set to 1 ``` modparam("permissions", "db_url", DBURL) modparam("permissions", "db_mode", 0) modparam("permissions", "address_table", "gw_auth_ip") modparam("permissions", "trusted_table", "user_auth_ip") modparam("permissions",