Closed #1446.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1446#event-2775084590___
Kamailio (SER) - Development Mailing List
sr-dev@lis
@SurendraPlivo - thanks for the feedback. So do you switched to the generic
redis module or still use this on internally?
For reference, it was discussed at this
[thread](https://lists.kamailio.org/pipermail/sr-users/2018-February/100423.html).
Closed
--
You are receiving this because you are
@miconda we can close this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1446#issuecomment-550275696___
Kamailio (SER) - Development Mai
Does this one still make sense to merge?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1446#issuecomment-546318559___
Kamailio (SER) - De
@SurendraPlivo pushed 1 commit.
e629543c6540bccb6118d9f55accd08a30edb46c handling snprintf issues, adding
table name size as symbolic constant
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1446/files/1999a526c
@SurendraPlivo pushed 1 commit.
1999a526ca4a9f57a480121601ba62300f632f1d db_redis: adding the error block
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1446/files/ad59363f9cf91e197fb93d333b91f891f2bd0ac3..1999a
@miconda sure.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1446#issuecomment-404229100___
Kamailio (SER) - Development Mailing List
sr-
Just looked quickly a bit ...
I spotted some sprintf() which are unsafe, especially when dealing with DB
string or blobs, the target buffer is 255 bytes in size, but I haven't seen any
check of input size.
This snippet needs some checks as well, for allocated pointer and snprintf:
```
+
@miconda please merge it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1446#issuecomment-404181127___
Kamailio (SER) - Development Maili
@SurendraPlivo pushed 1 commit.
ad59363 snprintf issues are fixed
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1446/files/7d6236c3d6e37a27811e464ca6a88b8b15dd9023..ad59363f9cf91e197fb93d333b91f891f2bd0ac3
sure . Its long back pull request. i need to check whether those comments
incorporated or not.
On Sat, May 5, 2018 at 1:07 PM, Daniel-Constantin Mierla <
notificati...@github.com> wrote:
> There was a discussion on mailing lists (sr-dev and sr-users) started in
> February with the subject "RFC: d
There was a discussion on mailing lists (sr-dev and sr-users) started in
February with the subject "RFC: db_redisusrloc module - review and how to deal
with" - can you follow up on that thread, some people had comments and it is
better that you express your point of view.
I haven't checked yet,
@miconda are we going to merge this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1446#issuecomment-386507713___
Kamailio (SER) - Develo
I didn't have the time to review yet. Probably it is better that I open a
discussion on the mailing list to speed up things by getting more feedback
quickly.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.co
@miconda can we have suggestion ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1446#issuecomment-366944865___
Kamailio (SER) - Developme
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files
16 matches
Mail list logo
