Merged #1243 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1243#event-2131731813___
Kamailio (SER) - Development Mailing
henningw commented on this pull request.
I reviewed it as well, looks good for me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Thanks! Looks ok after a quick review, I will go over one more try and then
merge if nothing discovered.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Worked around github's brokenness, commits are now in the correct order.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
github's broken commit sorting messes up the order of the patches, better
review it as a whole.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
gaaf commented on this pull request.
> if(append_branch( 0, [i]->uri, 0, 0,
> sqvalues[i],
- bflags, 0,
&_redirect_sruid.uid, 0,
+ flags, 0, &_redirect_sruid.uid,
0,
Both issues
@gaaf - soft reminder just in case you can address this one and eventually have
it merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> @gaaf - any updates on this?
I still have this on my todo list, just haven't found the time to fix it yet.
Sorry for the delay.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@gaaf - any updates on this? Last comment from your was related to some
merge/rebase errors.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
gaaf commented on this pull request.
> if(append_branch( 0, [i]->uri, 0, 0,
> sqvalues[i],
- bflags, 0,
&_redirect_sruid.uid, 0,
+ flags, 0, &_redirect_sruid.uid,
0,
1. If
miconda commented on this pull request.
> @@ -595,6 +598,17 @@ static int print_contact_str(char **dest, str *uri,
> qvalue_t q, str *path, char
memcpy(p, buf.s, buf.len);
p += buf.len;
}
+
+ /* branch flags (not SIP standard conformant) */
+
gaaf commented on this pull request.
> @@ -595,6 +598,17 @@ static int print_contact_str(char **dest, str *uri,
> qvalue_t q, str *path, char
memcpy(p, buf.s, buf.len);
p += buf.len;
}
+
+ /* branch flags (not SIP standard conformant) */
+
miconda commented on this pull request.
> @@ -595,6 +598,17 @@ static int print_contact_str(char **dest, str *uri,
> qvalue_t q, str *path, char
memcpy(p, buf.s, buf.len);
p += buf.len;
}
+
+ /* branch flags (not SIP standard conformant) */
+
miconda commented on this pull request.
> if(append_branch( 0, [i]->uri, 0, 0,
> sqvalues[i],
- bflags, 0,
&_redirect_sruid.uid, 0,
+ flags, 0, &_redirect_sruid.uid,
0,
As I got
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README
15 matches
Mail list logo
