Re: [sr-dev] [kamailio/kamailio] acc_json: adding module (#1440)

2018-02-16 Thread Julien Chavanton
Packet Type 1 - load tests ``` Total 250 INVITE calls sent in 2522028 ms at rate of 991/sec Total 250 responses received in 2522826 ms at rate of 990/sec: Detailed responses received: - 200 responses: 250 (OK) -- TOTAL responses: 250 (rate=990/sec)

Re: [sr-dev] [kamailio/kamailio] acc_json: adding module (#1440)

2018-02-15 Thread William King
Great work @jchavanton Glad to see this make it upstream. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1440#issuecomment-366010253___ K

Re: [sr-dev] [kamailio/kamailio] acc_json: adding module (#1440)

2018-02-15 Thread Julien Chavanton
Hi, @lazedo, thank for the feedback, we could keep some default provided outputs as "ease of use" default solutions and add a generic PV output or another module API. I can share my thoughts, using mqueue we can already do routing script operation without blocking the worker process. (reusing a

Re: [sr-dev] [kamailio/kamailio] acc_json: adding module (#1440)

2018-02-15 Thread Daniel-Constantin Mierla
You can add a modparam to tune its behaviour and act as you want. Each developer is guided mainly by what he/she needs. What you suggest is also interesting to have and iirc it was mentioned in the previous related PR, suggesting that future improvement, which can allow pushing out of kamailio

Re: [sr-dev] [kamailio/kamailio] acc_json: adding module (#1440)

2018-02-15 Thread lazedo
this is a great addition but i think its restricted in the output. `mqueue` and `syslog` shouldn't be here. the module should emit an event with the json payload as a new pseudo var, and in the script we could the use mqueue, syslog or whatever the integrator/developer wishes to do with json pa

Re: [sr-dev] [kamailio/kamailio] acc_json: adding module (#1440)

2018-02-15 Thread Daniel-Constantin Mierla
Merged #1440. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1440#event-1475570021___ Kamailio (SER) - Development Mailing List sr-dev@lis

Re: [sr-dev] [kamailio/kamailio] acc_json: adding module (#1440)

2018-02-15 Thread Daniel-Constantin Mierla
Thanks! I am going to merge it and do some small adjustments afterwards. I will also grant you commit permissions to maintain this module directly, without a need for pull requests. For other modules or parts of Kamailio, pull requests should still be used, to allow the original developer as wel

[sr-dev] [kamailio/kamailio] acc_json: adding module (#1440)

2018-02-14 Thread Julien Chavanton
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README