Pushed patch with a manual commit.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1217#issuecomment-323050655___
Kamailio (SER) -
The commit message is the one you give when doing "git commit ...".
The patch is small, so probably is faster to use the diff
(https://github.com/kamailio/kamailio/commit/b84d4a1f09b6310522ac83546a7a34b2c52f0ecf.diff),
make a fresh clone of kamailio repo and do the commit again, with a new PR.
See the commit message as it appears in the patch:
*
https://github.com/kamailio/kamailio/commit/b84d4a1f09b6310522ac83546a7a34b2c52f0ecf.patch
What you had as Description in PR comment is not in the commit message.
--
You are receiving this because you are subscribed to this thread.
Reply
Sorry what's wrong? Looks like formatted right. Or should I elaborate in desc
why this fix is required?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Reopened #1217.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1217#event-1208019817___
Kamailio (SER) - Development Mailing List
Closed #1217.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1217#event-1208015340___
Kamailio (SER) - Development Mailing List
The commit message doesn't have the format required by the contributing guide,
although you have checked that box. Amend the commit message accordingly:
*
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format
--
You are receiving this because you are
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files
