Re: [sr-dev] contact uri is too long

2017-09-14 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > The values are defined inside entities.xml in the same folder. I would > put there contact_len as a new entity defined for 512, because I think > we need to adjust also for other modules that store contact URI, such as > presence or dialog, because they will be h

Re: [sr-dev] contact uri is too long

2017-09-14 Thread Daniel-Constantin Mierla
On 14.09.17 12:06, Juha Heinanen wrote: > Daniel-Constantin Mierla writes: > >> if such change to increase the default is to be done, I think it is >> better to double it, rather that just adding 128 which can be hit soon >> again. > OK. > >> I haven't checked, but probably the db table column ty

Re: [sr-dev] contact uri is too long

2017-09-14 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > if such change to increase the default is to be done, I think it is > better to double it, rather that just adding 128 which can be hit soon > again. OK. > I haven't checked, but probably the db table column type needs to be > changed, iirc, varchar was up to 2

Re: [sr-dev] contact uri is too long

2017-09-14 Thread Daniel-Constantin Mierla
Hello, if such change to increase the default is to be done, I think it is better to double it, rather that just adding 128 which can be hit soon again. I haven't checked, but probably the db table column type needs to be changed, iirc, varchar was up to 256 for mysql, but maybe later that limit

[sr-dev] contact uri is too long

2017-09-14 Thread Juha Heinanen
Looks like also the SIP world is getting more complex all the time and URIs are getting larger. How about if I increase size of location table contact column from 255 to 386 and make the same change in registrar module contact_max_size param default value? I checked and didn't find any other code

[sr-dev] contact uri is too long

2017-09-13 Thread Juha Heinanen
It turned out that registrar module takes max contact size from contact_max_size param that defaults to 255. Would it make sense to increase the default (and location table contact column size) for the next K release so that K would work out-of-the-box with e.g. Linphone? -- Juha ___

[sr-dev] contact uri is too long

2017-09-13 Thread Juha Heinanen
I tried latest Linphone and when it tried to register, K complained: Sep 13 20:56:06 box /usr/bin/sip-proxy[111574]: WARNING: registrar [sip_msg.c:194]: check_contacts(): contact uri is too long: [sip:username@host:port;app-id=929724111839;pn-type=firebase;pn-tok=dYqC3AnzCxI:APA91bF84yDlViEZtJyu