> Don't know why `check-format (pull_request)` failed again, because latest
> commit
> [38a1c73](https://github.com/kamailio/kamailio/commit/38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a)...
> PASSED.
yes, the action checks if *all* commits follows the clang-format not the final
result. That is why
Closed #3608.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3608#event-10709891167
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing
I guess clang format may differ based on clang version and maybe global
defaults on OSes -- the check here should be taken as a soft recommendation,
but if it looks pretty ok, it can be merged.
Anyhow, in this particular case I merged manually, closing this one..
--
Reply to this email directl
I am going to apply it manually, because the commit message is not following
the contributing guidelines.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3608#issuecomment-1770706662
You are receiving this because you are subscribed to this thread.
Don't know why `check-format (pull_request)` failed again, because latest
commit 38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a... PASSED.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3608#issuecomment-1770663120
You are receiving this because you are
@juha-h pushed 1 commit.
38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a Trying to fix format
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3608/files/dd9d828a782c0c132c536a97beb792176928a716..38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a
You are receiving this because you are subscribed
