Merged #3375 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3375#event-8890089881
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) -
> I have also changes which change typos and documentation,
which change/add/remove sentences in the documentation
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3375#issuecomment-1431039692
You are receiving this because you are subscribed to
I have changes on my computer concerning typos, and I submit them in batches
for some modules. I have also changes which change typos and documentation,
these I will submit in separate PR per modules, once I am confident with the
changes.
The changes were **caught** by using regex and
Problems can also be when backporting fixes, because if a line was changed for
a spell fix in variable/function name or in the comment and the code fix
changes the same line or adjacent lines, then backporting fails because it does
not matches the context in the file.
So sometimes backporting
Good to bring this up, it might be indeed cause some issues for backports. We
might consider not backporting this spelling fixes to the stable branches, just
fixes for "real" bugs. I think we got some hundreds of these commits in the
last weeks, which is impressive, but quite some work to
What I mean is in the global context of your planned work to fix the typos,
which is very appreciated, but has to be coordinated and planned somehow,
because the commit messages are not very explicit and repeat, then backports
can be affected, making the release procedure more difficulat.
For
The changes here are for modules, whose name starts with “a”. I do not expect
more typos in modules, whose name starts with “a”.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3375#issuecomment-1430063609
You are receiving this because you are
Are you expecting to be many more pull requests related to typos?
We should wait and collect all in one PR and squeeze per module, otherwise
there are more and more chances of conflicts when we need to backport fixes to
the code.
--
Reply to this email directly or view it on GitHub:
