Merged #3612 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3612#event-10757588772
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Developm
Thanks, merged
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3612#issuecomment-161242
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development M
>From my point of view this PR can be squashed and merged.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3612#issuecomment-1777676433
You are receiving this because you are subscribed to this thread.
Message ID: __
@xkaraman pushed 1 commit.
7d0b7e0bd49b8534b35c8c10a41c4d6ca86b9164 cdp: Remove extra line
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3612/files/79ba6edcaea2b31823ffbfbfc79cc41d4c1ced24..7d0b7e0bd49b8534b35c8c10a41c4d6ca86b9164
You are receiving this because you are subscri
Done.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3612#issuecomment-1777110534
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing Li
@xkaraman pushed 1 commit.
79ba6edcaea2b31823ffbfbfc79cc41d4c1ced24 cdp: Move function to cdp_tls
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3612/files/eb36512a644a92e6764ad53a8b4c4f23740c96ba..79ba6edcaea2b31823ffbfbfc79cc41d4c1ced24
You are receiving this because you are
In the cdp_tls.c I would put the function before the first one that uses it,
possibly SSL *init_ssl_conn(int client_fd, SSL_CTX *ctx). In the cdp_tls.h,
maybe just under tls_parse_method(). Much appreciated.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kama
Sure thing, I will revise it! Any specific order you may want it to appear?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3612#issuecomment-1777028396
You are receiving this because you are subscribed to this thread.
Message ID:
Hello,
Thanks for the changes.
I did manage to get some extra information with this new function so the
addition is welcome.
Sorry to come just now with another suggestion: we can use cdp_tls.h/cdp_tls.c
to house the cdp_openssl_clear_errors() function. This would get rid of the
extra utils.c
@xkaraman pushed 1 commit.
eb36512a644a92e6764ad53a8b4c4f23740c96ba cdp: Expand buffer and change info
call
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3612/files/5f7077f06b2e93d22128c4bb8bf6eec55bd3f39e..eb36512a644a92e6764ad53a8b4c4f23740c96ba
You are receiving this becau
@xkaraman commented on this pull request.
> +#include
+#include
+
+#include "../../core/dprint.h"
+#include "utils.h"
+
+/*
+ * Get any leftover errors from OpenSSL and print them.
+ * ERR_get_error() also removes the error from the OpenSSL error stack.
+ * This is useful to call before any SS
@xkaraman commented on this pull request.
> +#include "../../core/dprint.h"
+#include "utils.h"
+
+/*
+ * Get any leftover errors from OpenSSL and print them.
+ * ERR_get_error() also removes the error from the OpenSSL error stack.
+ * This is useful to call before any SSL_* IO calls to make sur
@lbalaceanu commented on this pull request.
Hello @xkaraman ,
Thank you for your contribution. I will also test minimally the code and give
an input after that as well.
> +#include "../../core/dprint.h"
+#include "utils.h"
+
+/*
+ * Get any leftover errors from OpenSSL and print them.
+ * ERR_g
13 matches
Mail list logo
