[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-11-16 Thread Daniel-Constantin Mierla via sr-dev
Merged #3594 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3594#event-10983815203 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-11-16 Thread Xenofon Karamanos via sr-dev
Reopened #3594. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3594#event-10978551563 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-11-16 Thread Xenofon Karamanos via sr-dev
Closed #3594. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3594#event-10978432072 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-11-16 Thread Xenofon Karamanos via sr-dev
@xkaraman pushed 0 commits. -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3594/files/6d2315552665d082eddd4bb3fb4ed4b3134640e8..4e614ba6b7a5663bd88f353a3ce7a0976d8e878f You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-11-15 Thread Daniel-Constantin Mierla via sr-dev
@xkaraman: the PR has conflicts with the master branch, which introduced a while ago checks for access rights of the rc files. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3594#issuecomment-1813909143 You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-11-13 Thread Xenofon Karamanos via sr-dev
Removed them as suggested. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3594#issuecomment-1808245741 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-11-13 Thread Xenofon Karamanos via sr-dev
@xkaraman pushed 1 commit. 6d2315552665d082eddd4bb3fb4ed4b3134640e8 kamctl: Remove echo -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3594/files/4eee8b1ebbbc029ad7bfbaa52cb718fa3d9ded39..6d2315552665d082eddd4bb3fb4ed4b3134640e8 You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-11-13 Thread Daniel-Constantin Mierla via sr-dev
I see that the patch introduced a bunch of `echo` lines, which could be good for debugging but can be a pain when using kamctl many times, specially when one wants to divert the output to a file or pipe for further processing (e.g., output of a kamctl rpc command which should be just the

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-11-10 Thread Xenofon Karamanos via sr-dev
@xkaraman pushed 1 commit. 4eee8b1ebbbc029ad7bfbaa52cb718fa3d9ded39 Fix source order -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3594/files/29250dbebff8c5670c07a82ad943121dd1d1b99e..4eee8b1ebbbc029ad7bfbaa52cb718fa3d9ded39 You are receiving this because you are subscribed

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-09 Thread Xenofon Karamanos via sr-dev
> Usually is expected to have the default config as deployed by install (in > /etc/ or /usr/local/etc) when running a globally deployed kamctl or by > presence in source three when running a devel environment, plus user specific > options (e.g., user/password for database) in a user home config

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-06 Thread Daniel-Constantin Mierla via sr-dev
As we kind of try to move from shell-based kamctl/kamdbctl to kamcli, I looked at it and it does a similar approach, relying on the fact that Python's `configparser.read()` has support to get a list of (config) files: -

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-06 Thread Daniel-Constantin Mierla via sr-dev
I missed that part, but indeed is looking for a kamctlrc in the same folder as kamctl. Digging in memory, the actual purpose for it is to allow running/operating kamailio from source directory (just compile, not install), which is convenient when developing. That's also why loadmodule looks not

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-06 Thread Xenofon Karamanos via sr-dev
> It is somehow expected that when one does own custom installation may have to > tune it properly in many places. Surely, i understand that. This specific script `kamctl` offers an easy way to accomplish that by searching some standard paths it may find the `kamctlrc`. Maybe we can document,

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-06 Thread Daniel-Constantin Mierla via sr-dev
@xkaraman: usually the applications are designed to work with standard installation from a package or source tree. That's what kamctl tries to look after as well. It is somehow expected that when one does own custom installation may have to tune it properly in many places. I am not against

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-06 Thread Xenofon Karamanos via sr-dev
Hello @miconda, Indeed this script goes way back and i am still getting familiar with the codebase. You are suggesting that `/etc/kamailio/kamctl` should be and is the base config file and that is fine. I see some flows as it right now. 1) What if user has installed kamailio not from

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-06 Thread Henning Westerholt via sr-dev
Thank you -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3594#issuecomment-1750064416 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-06 Thread Daniel-Constantin Mierla via sr-dev
This behaviour is likely there from the beginning, or at least more than 10-15 years old. I do use it, although not very often, to put in home kamctlrc some new queries that can be run via db command, relying on etc file for the rest of the options. I pushed a commit to check if kamctlrc is

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-05 Thread Henning Westerholt via sr-dev
Many linux software packages uses a different behaviour, if one configuration file is found, its using this and no merge of the values is done. Bash profile loading does it differently indeed, but I would argue that kamctl is more like a tool. But if people depend on this current behaviour,

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-05 Thread Daniel-Constantin Mierla via sr-dev
The scope of loading all configs in cascade is to allow overwriting on specific options with home config, not to have the entire config there. Practically the /etc config is the one with all options and then add a user home config only to change specific options (e.g., have a different mysql