Merged #3793 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3793#event-12356211255
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) -
OK!. Then please merge it ... or I can do it. Is it just pressing the `Squash
and merge` button?
After that I will add the documentation.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3793#issuecomment-2027551190
You are receiving this because
I am fine to merge if there are no other comments.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3793#issuecomment-2027513172
You are receiving this because you are subscribed to this thread.
Message ID:
Are we good to go with this one?
The name of the parameter has been changed to `xhttp_prom_pkg_stats`.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3793#issuecomment-2025378262
You are receiving this because you are subscribed to this thread.
@ovidiusas pushed 1 commit.
5d14ddd277394b4d7fad6fc5bdc284bb4bfa68bf xhttp_prom: rename module parameter
to xhttp_prom_pkg_stats
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3793/files/07c82c46ff0900ba5fe57fb79e79408925b340d6..5d14ddd277394b4d7fad6fc5bdc284bb4bfa68bf
You
@ovidiusas pushed 2 commits.
5c66426a1380fbba7181956c43b341c96701d3b7 kex: clang format
07c82c46ff0900ba5fe57fb79e79408925b340d6 xhttp_prom: clang format
--
View it on GitHub:
I haven't looked at code, but if `xhttp_prom_stats` cannot be easily reused,
then at least a shorter name for modparam has to be found,
`xhttp_prom_pkgmem_stats_enabled` is really long and looking rather odd.
Usually private memory is referred simply as `pkg`, not `pkgmem`, also
`enabled`
Another reason for implementing the pkg mem via a new parameter was related to
the fact the pkg mem stats are not available via the `get_statistics` mi
command. The idea was to mirror the mi layout over the xhttp_prometheus control.
--
Reply to this email directly or view it on GitHub:
I think it's better to control the pkg mem statistics via a parameter.
If the admin want's the pkg mem stats to be available but the kex module is
loaded after the xhttp_prom, the pkg mem stats won't be available which will
lead to confusion. Also, this will keep the existing behavior untouched.
Thanks for the PR. Two comments:
- the code format checker seems to fail, could you please check with
clang-format and update if necessary?
- you introduced a new parameter "xhttp_prom_pkgmem_stats_enabled", what about
just checking during startup if the kex module is available, if yes enable
10 matches
Mail list logo
