[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-19 Thread Daniel-Constantin Mierla via sr-dev
Looks ok for me. If you push it, then you have to update the wiki core books section for it as well. Cheers, Daniel On 19.10.23 09:14, Juha Heinanen via sr-dev wrote: > How about the diff below? > > Also, is there plan to backport ksr_tcp_msg_data_timeout, > ksr_tcp_msg_read_timeout, and

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-19 Thread Juha Heinanen via sr-dev
How about the diff below? Also, is there plan to backport ksr_tcp_msg_data_timeout, ksr_tcp_msg_read_timeout, and ksr_tcp_check_timer to 5.7, since they can help in protecting from DoS attacks that we have seen in the wild. -- Juha diff --git a/src/main.c b/src/main.c index

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Daniel-Constantin Mierla via sr-dev
On 16.10.23 12:44, Juha Heinanen wrote: > Daniel-Constantin Mierla writes: > >>> In order to make configuration simpler, how about having a dynamic default >>> as I suggested? >> Default is half (hardcoded), but its own parameter gives more >> flexibility for granularity -- one extra parameter is

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
Daniel-Constantin Mierla writes: > > In order to make configuration simpler, how about having a dynamic default > > as I suggested? > > Default is half (hardcoded), but its own parameter gives more > flexibility for granularity -- one extra parameter is not adding much > complexity, imo, and

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Daniel-Constantin Mierla via sr-dev
On 16.10.23 12:27, Juha Heinanen wrote: > Daniel-Constantin Mierla writes: > >> Smaller is recommended for better accuracy. > In order to make configuration simpler, how about having a dynamic default > as I suggested? Default is half (hardcoded), but its own parameter gives more flexibility for

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
Daniel-Constantin Mierla writes: > Smaller is recommended for better accuracy. In order to make configuration simpler, how about having a dynamic default as I suggested? ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Daniel-Constantin Mierla via sr-dev
On 16.10.23 10:25, Juha Heinanen wrote: > Daniel-Constantin Mierla via sr-dev writes: > >> core: added tcp_check_timer parameter >> >> - set the check interval (in seconds) for tcp connections >> - default 10 > Does this need to be smaller than tcp_msg_read_timeout and > tcp_msg_data_timeout in

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
If so, how about defaulting to half of tcp_msg_read_timeout or tcp_msg_data_timeout whichever is smallest? ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org