Re: [sr-dev] add_contact_alias(0) is proto differs

2017-11-25 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > I am fine to get such fields to the same type, just be careful to have > them aligned to 32bits from the start of the structure. I'm not qualified enough to do that kind change, since it may affect many parts of the core and many modules. -- Juha

Re: [sr-dev] add_contact_alias(0) is proto differs

2017-11-23 Thread Daniel-Constantin Mierla
On 24.11.17 01:56, Juha Heinanen wrote: > When adding transport proto check to add_contact_alias, I noticed that > in receive_info struct proto is defined like this: > > char proto; > > and in sip_uri struct like this: > > unsigned short proto; /*!< from transport */ > > That does not

Re: [sr-dev] add_contact_alias(0) is proto differs

2017-11-23 Thread Daniel-Constantin Mierla
On 24.11.17 01:26, Juha Heinanen wrote: > Currently add_contact_alias() works like this: > > Adds an “;alias=ip~port~transport” parameter to the contact URI > containing either received ip, port, and transport protocol or those > given as parameters. If called without parameters, “;alias”

[sr-dev] add_contact_alias(0) is proto differs

2017-11-23 Thread Juha Heinanen
When adding transport proto check to add_contact_alias, I noticed that in receive_info struct proto is defined like this: char proto; and in sip_uri struct like this: unsigned short proto; /*!< from transport */ That does not look good to me. They should have the same type in

[sr-dev] add_contact_alias(0) is proto differs

2017-11-23 Thread Juha Heinanen
Currently add_contact_alias() works like this: Adds an “;alias=ip~port~transport” parameter to the contact URI containing either received ip, port, and transport protocol or those given as parameters. If called without parameters, “;alias” parameter is only added if received ip and port