Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-20 Thread Daniel-Constantin Mierla
Closed #1150. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1150#event-1130489809___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-20 Thread Daniel-Constantin Mierla
Thanks, closing it then! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1150#issuecomment-309676278___ Kamailio (SER) - Development

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-20 Thread Alexandr Dubovikov
yep. It works now! :-) thank you -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1150#issuecomment-309675518___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-20 Thread Daniel-Constantin Mierla
So #1155 is fixing also the introduced bug with bad pointer? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-20 Thread Alexandr Dubovikov
https://github.com/kamailio/kamailio/pull/1155 looks like it has been fixed :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-19 Thread Alexandr Dubovikov
bingo! :-) now another issue: /usr/sbin/kamailio[1798]: ERROR: topoh [topoh_mod.c:560]: th_execute_event_route(): exit due to 'drop' in event route /usr/sbin/kamailio[1798]: : [core/mem/q_malloc.c:469]: qm_free(): BUG: qm_free: bad pointer 0x7fa3461b9000 (out of memory block!) called from

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-19 Thread Daniel-Constantin Mierla
Indeed, that condition should be with &&. Is the next fake msg null, or what is failing there? Can you see what is the return code for t_relay? I guess the slow error is because of sl_send_error () in kamaulio.cfg. I am traveling, no much testing that I can do. -- You are receiving this

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-19 Thread Alexandr Dubovikov
Thank you @miconda , unfortunately there is bug that I couldnt catch. 6 days ago I have implemented same way in my repository: https://github.com/adubovikov/kamailio/commit/ae15a717e9a5849b4ac295c5864cd6e9b198b6d1 but your and my patches makes same results: /usr/sbin/kamailio[1260]: ERROR: sl

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-16 Thread Anthony Messina
Can this be used for topos as well as topoh? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1150#issuecomment-309004565___ Kamailio (SER)

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-14 Thread Daniel-Constantin Mierla
I did an implementation to execute an event_route before the topoh processing for messages to be sent out. Documentation will follow soon, meanwhile you can see the comments of the commit f7d1d23 . Basically, $sndto(ip) should point to the ip address of the destination and calling `drop`

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-09 Thread Alexandr Dubovikov
ok. agree.. this way will be more effective and flexible. Should I do or you wanna ? ;-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-09 Thread Daniel-Constantin Mierla
Giving a fake request is very fast, like done at: * https://github.com/kamailio/kamailio/blob/master/src/modules/htable/htable.c#L268 It is no parsing apart of the first time. This way is safe, because some functions need the msg structure. -- You are receiving this because you are

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-09 Thread Alexandr Dubovikov
so, from topoh we can call topoh-route in kamailio.cfg , there we can use allow_address from the permissions module and base on the result we can reject and accept topoh request. Should we just send empty sip_msg structure there ? Just to avoid sip message parsing in case the request will be

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-09 Thread Daniel-Constantin Mierla
We have the source code, we can change if something helps substantially -- currently, I see two options that can be controlled via a mod param (or just choose one that it is considered better): * give a fake request, like it is done with other event_route blocks (e.g., htable:mod-init) --

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-09 Thread Alexandr Dubovikov
Yes, exactly this way, just to exclude or include destination IP for topology hiding. I am not sure that there is a way to do it via internal flags, because the event socket for SREV_NET_DATA_OUT will be called from retransmission function in the tm module and in this case you don't have

Re: [sr-dev] [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

2017-06-09 Thread Daniel-Constantin Mierla
What is exactly the purpose of this new functionality? To allow/deny traffic from those IP addresses or for doing/skipping topology hiding? I am somehow not very pleased with importing a lot of code similar to what permissions does in regards to address matching. I would rather do another