> Thanks!
>
> Is the PR completed? If yes, I would merge it manually to make the commit
> message follow the contributing guidelines:
>
> *
> https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format
Hi Daniel, yes, it's complete. Thanks for pointing out,
How about the diff below?
Also, is there plan to backport ksr_tcp_msg_data_timeout,
ksr_tcp_msg_read_timeout, and ksr_tcp_check_timer to 5.7, since they can
help in protecting from DoS attacks that we have seen in the wild.
-- Juha
diff --git a/src/main.c b/src/main.c
index
If `tcp_check_timer` is not set, use default value that is half of
`tcp_msg_data_timeout` or `tcp_msg_read_timeout` value depending on which one
is smaller and not zero.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3608
--
@xkaraman pushed 1 commit.
5ce80d2f0dab8137cba31367bd8ca923424d0687 Fix format
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3607/files/f2083f611dcbf2da0320f629a30cc65f09fcb5da..5ce80d2f0dab8137cba31367bd8ca923424d0687
You are receiving this because you are subscribed to this
can you please rebase and squash?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3607#issuecomment-1770252065
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio
I will later merge it manually
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3607#issuecomment-1770265188
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio
Looks ok for me. If you push it, then you have to update the wiki core
books section for it as well.
Cheers,
Daniel
On 19.10.23 09:14, Juha Heinanen via sr-dev wrote:
> How about the diff below?
>
> Also, is there plan to backport ksr_tcp_msg_data_timeout,
> ksr_tcp_msg_read_timeout, and
I guess clang format may differ based on clang version and maybe global
defaults on OSes -- the check here should be taken as a soft recommendation,
but if it looks pretty ok, it can be merged.
Anyhow, in this particular case I merged manually, closing this one..
--
Reply to this email
Closed #3608.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3608#event-10709891167
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing
Thanks! CodeQL can indeed fail from other reasons than the code, can be ignored
if that happens.
Regarding the patch of the PR, I could spot only a database delete operation
being added. The commit message says `Add support for database backend`. Was
there code for database support but not
Module: kamailio
Branch: master
Commit: 110ebbafadcc225f4e88749287f06ae29a6cfa2e
URL:
https://github.com/kamailio/kamailio/commit/110ebbafadcc225f4e88749287f06ae29a6cfa2e
Author: Xenofon Karamanos
Committer: Henning Westerholt
Date: 2023-10-19T12:18:38Z
tls: Add and apply
Thanks, was merged manually, close it
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3607#issuecomment-1770847826
You are receiving this because you are subscribed to this thread.
Message ID: ___
Closed #3607.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3607#event-10710873842
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing
> Don't know why `check-format (pull_request)` failed again, because latest
> commit
> [38a1c73](https://github.com/kamailio/kamailio/commit/38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a)...
> PASSED.
yes, the action checks if *all* commits follows the clang-format not the final
result. That is
Module: kamailio
Branch: master
Commit: f27eda6fe3d99d1352d4df86d79e4646b0a4c17a
URL:
https://github.com/kamailio/kamailio/commit/f27eda6fe3d99d1352d4df86d79e4646b0a4c17a
Author: Victor Seva
Committer: Victor Seva
Date: 2023-10-19T14:33:45+02:00
presence: active_watcher cleanup timer
related
Merged #3605 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3605#event-10711237721
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) -
Don't know why `check-format (pull_request)` failed again, because latest
commit 38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a... PASSED.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3608#issuecomment-1770663120
You are receiving this because you
I am going to apply it manually, because the commit message is not following
the contributing guidelines.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3608#issuecomment-1770706662
You are receiving this because you are subscribed to this
Module: kamailio
Branch: master
Commit: 5077127b0fe1a2d803e42abe19cfcd93339f0519
URL:
https://github.com/kamailio/kamailio/commit/5077127b0fe1a2d803e42abe19cfcd93339f0519
Author: Juha Heinanen
Committer: Daniel-Constantin Mierla
Date: 2023-10-19T13:36:32+02:00
core: change tcp_check_timer
Fine to merge from my point of view.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3605#issuecomment-1770735259
You are receiving this because you are subscribed to this thread.
Message ID: ___
Hello,
thank you, will take a look! Regarding backporting it to stable branch, this
will be unfortunately not possible as it's a new functionality.
Generally speaking, its not necessary to create additional PRs for stable
branches, this is usually done with cherry-picking.
Cheers,
Henning
--
My plan is to have this merged and then continue working on db operations for
the ims_charging module. I just wanted to have this completed first, since the
other part will not work without it.
--
Reply to this email directly or view it on GitHub:
@juha-h pushed 1 commit.
38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a Trying to fix format
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3608/files/dd9d828a782c0c132c536a97beb792176928a716..38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a
You are receiving this because you are subscribed
Thanks!
Is the PR completed? If yes, I would merge it manually to make the commit
message follow the contributing guidelines:
-
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format
--
Reply to this email directly or view it on GitHub:
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for
Like I wrote in the ticket related to this task, most of the stuff was there
already - but it both caused a crash and was not fully functional. Entries were
being written to the database, but was not restored correctly on startup.
I assume the old dialog module was used as a basis and that the
Thank you for contributing. I would prefer if there's only one variable and
that we use the milliseconds always internally and just keep the old setting
for backwards compatibility.
--
Reply to this email directly or view it on GitHub:
27 matches
Mail list logo
