Re: [sr-dev] [kamailio/kamailio] Extend keepalive module documentation (#1082)

2017-04-24 Thread Guillaume Bour
Hi @agranig, @kamailio-sync @
First, the module is still young, so the documentation may be incomplete. I 
will improve it asap

Second, my primary idea when started this module was to implement the same 
"destinations probing" mechanism found in dispatcher module, both in drouting & 
carrierroute modules. So instead of directly patching those modules (and 
duplicating the same code), I regroup all probing features in *keepalive* 
module that also expose a set of APIs (to be documented) to register a 
destination and be notified of destination status change.
Following @miconda suggestions, it can also be used standalone

_What does that mean?_
So currently you can use it in 2 ways:
- standalone: destinations to monitor are statically defined as module 
parameter then you can use is_alive() function or event route to react to 
destination state change
- as "probing engine" for drouting module: by setting _enable_keepalive_ 
drouting parameter, drouting destinations will be monitored by keepalive, and a 
call to do_routing() will ignore inactive destinations in the resultset.
I will add examples to the documentation to make things clear, but you can 
already see a kamailio.cfg example for both case in this ml post: 
https://lists.kamailio.org/pipermail/sr-users/2017-March/096521.html

_What are the use cases and which problems does it solve?_
- monitor remote trunks (allowing to take actions or trigger an alert when a 
destination is down)
- ignore down destinations when routing a call

_Which mechanisms does it use (SIP, ICMP, others?)_
It is working the same way as dispatcher does, by regularly sending SIP OPTIONS 
to destinations

Hope I answered all your questions 

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1082#issuecomment-296810631___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] git:5.0:4ad64c0f: db_text: add db_delim parameter

2017-04-24 Thread Daniel-Constantin Mierla
Hello,

I did the revert so the debian nightly builds from branch 5.0 don't mix
with the backport.

Cheers,
Daniel


On 24.04.17 16:56, Daniel-Constantin Mierla wrote:
> Hello,
>
> nothing to be really sorry about, we collaborate here and it is the role
> of github to make it easy to revert.
>
> I think it is good to revert to keep it clean, as we build packages over
> the night and some people are using them.
>
> If this is something that solve some problems for you, then you can
> write an email to sr-dev or even better make a pull request to backport
> this patch and let the others comment there to take a decision.
>
> Cheers,
> Daniel
>
>
> On 24.04.17 16:52, Lucian Balaceanu wrote:
>> Hello Daniel,
>>
>> I am sorry for this situation; do I revert the commit?
>>
>> Thank you,
>> Lucian
>>
>> On 24.04.2017 17:41, Daniel-Constantin Mierla wrote:
>>> Hello,
>>>
>>> the rule is not to backport new features to stable versions, because we
>>> will end up in a mixture of untested code where stability cannot be
>>> ensured.
>>>
>>> I don't feel that this commit is fixing an existing issues, rather
>>> making it more aesthetic in some cases.
>>>
>>> If I got it wrong, please provide more details and if other developers
>>> are fine with this backport, I won't be against it.
>>>
>>> Cheers,
>>> Daniel
>>>
>>> On 24.04.17 16:36, Lucian Balaceanu wrote:
 Module: kamailio
 Branch: 5.0
 Commit: 4ad64c0ff0384b232b7c198316b46a86ad2c4f31
 URL:
 https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31

 Author: Lucian Balaceanu 
 Committer: Lucian Balaceanu 
 Date: 2017-04-24T17:31:45+03:00

 db_text: add db_delim parameter

 - make the delimiter between fields in th db_text file configurable;
useful when one would need to escape a lot of appearances of the
default delimiter (';' in IPv6 addresses).

 ---

 Modified: src/modules/db_text/db_text.c
 Modified: src/modules/db_text/dbt_file.c
 Modified: src/modules/db_text/dbt_lib.h
 Modified: src/modules/db_text/doc/db_text_admin.xml

 ---

 Diff: 
 https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31.diff
 Patch:
 https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31.patch


 ___
 Kamailio (SER) - Development Mailing List
 sr-dev@lists.kamailio.org
 https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - May 22-24 (USA) - www.asipto.com
Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:5.0:a3b376a1: modules: readme files regenerated - modules ... [skip ci]

2017-04-24 Thread Kamailio Dev
Module: kamailio
Branch: 5.0
Commit: a3b376a178532508e595c7bb1ed9278351f9c0c4
URL: 
https://github.com/kamailio/kamailio/commit/a3b376a178532508e595c7bb1ed9278351f9c0c4

Author: Kamailio Dev 
Committer: Kamailio Dev 
Date: 2017-04-24T21:16:13+02:00

modules: readme files regenerated - modules ... [skip ci]

---

Modified: src/modules/db_text/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/a3b376a178532508e595c7bb1ed9278351f9c0c4.diff
Patch: 
https://github.com/kamailio/kamailio/commit/a3b376a178532508e595c7bb1ed9278351f9c0c4.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:5.0:1dad5027: Revert "db_text: add db_delim parameter"

2017-04-24 Thread Daniel-Constantin Mierla
Module: kamailio
Branch: 5.0
Commit: 1dad50274d4f22a50d90894b1b6dfa64baa7c638
URL: 
https://github.com/kamailio/kamailio/commit/1dad50274d4f22a50d90894b1b6dfa64baa7c638

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2017-04-24T21:09:12+02:00

Revert "db_text: add db_delim parameter"

This reverts commit 4ad64c0ff0384b232b7c198316b46a86ad2c4f31.

---

Modified: src/modules/db_text/db_text.c
Modified: src/modules/db_text/dbt_file.c
Modified: src/modules/db_text/dbt_lib.h
Modified: src/modules/db_text/doc/db_text_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/1dad50274d4f22a50d90894b1b6dfa64baa7c638.diff
Patch: 
https://github.com/kamailio/kamailio/commit/1dad50274d4f22a50d90894b1b6dfa64baa7c638.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:24f507f4: app_sqlang: use only function name in the exports table

2017-04-24 Thread Daniel-Constantin Mierla
Module: kamailio
Branch: master
Commit: 24f507f4f0643cd6157b6ac1339be77afe0bdd64
URL: 
https://github.com/kamailio/kamailio/commit/24f507f4f0643cd6157b6ac1339be77afe0bdd64

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2017-04-24T20:55:10+02:00

app_sqlang: use only function name in the exports table

---

Modified: src/modules/app_sqlang/app_sqlang_api.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/24f507f4f0643cd6157b6ac1339be77afe0bdd64.diff
Patch: 
https://github.com/kamailio/kamailio/commit/24f507f4f0643cd6157b6ac1339be77afe0bdd64.patch

---

diff --git a/src/modules/app_sqlang/app_sqlang_api.c 
b/src/modules/app_sqlang/app_sqlang_api.c
index d1c6b79..648e802 100644
--- a/src/modules/app_sqlang/app_sqlang_api.c
+++ b/src/modules/app_sqlang/app_sqlang_api.c
@@ -1483,7 +1483,7 @@ SQInteger sqlang_open_KSR(HSQUIRRELVM J)
goto error;
}
_sr_crt_J_KSRMethods[i].nparamscheck = 0;
-   snprintf(malias, 256, "%s.%s", mname, 
_sr_crt_J_KSRMethods[i].name);
+   snprintf(malias, 256, "%s", 
_sr_crt_J_KSRMethods[i].name);
sqlang_register_global_func(J, 
_sr_crt_J_KSRMethods[i].f, malias);
n++;
}


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] pkg/kamailio: Fix of ticket 1085 (#1086)

2017-04-24 Thread sergey-safarov
@linuxmaniac we can also mark exit code for broken config as SuccessExitStatus. 
Than unit will not restart in case of broken config 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1086#issuecomment-296780645___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Paul Claudiu Boriga
Hello, there was a problem because _redisc_srv_list type was modified.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1079#issuecomment-296702299___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Paul Claudiu Boriga
@claudiupb pushed 1 commit.

3f696ae  fix compilation error


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1079/files/83c68c5ededc0a5f06bb8d2fa3d778e7a6a17675..3f696aea111823bb0641ad9f255a6fb5bb15b0d3
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Daniel-Constantin Mierla
@claudiupb - the travis-ci is reporting compilation errors with the patches, 
see the details the post above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1079#issuecomment-296695783___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] git:5.0:4ad64c0f: db_text: add db_delim parameter

2017-04-24 Thread Daniel-Constantin Mierla
Hello,

nothing to be really sorry about, we collaborate here and it is the role
of github to make it easy to revert.

I think it is good to revert to keep it clean, as we build packages over
the night and some people are using them.

If this is something that solve some problems for you, then you can
write an email to sr-dev or even better make a pull request to backport
this patch and let the others comment there to take a decision.

Cheers,
Daniel


On 24.04.17 16:52, Lucian Balaceanu wrote:
> Hello Daniel,
>
> I am sorry for this situation; do I revert the commit?
>
> Thank you,
> Lucian
>
> On 24.04.2017 17:41, Daniel-Constantin Mierla wrote:
>> Hello,
>>
>> the rule is not to backport new features to stable versions, because we
>> will end up in a mixture of untested code where stability cannot be
>> ensured.
>>
>> I don't feel that this commit is fixing an existing issues, rather
>> making it more aesthetic in some cases.
>>
>> If I got it wrong, please provide more details and if other developers
>> are fine with this backport, I won't be against it.
>>
>> Cheers,
>> Daniel
>>
>> On 24.04.17 16:36, Lucian Balaceanu wrote:
>>> Module: kamailio
>>> Branch: 5.0
>>> Commit: 4ad64c0ff0384b232b7c198316b46a86ad2c4f31
>>> URL:
>>> https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31
>>>
>>> Author: Lucian Balaceanu 
>>> Committer: Lucian Balaceanu 
>>> Date: 2017-04-24T17:31:45+03:00
>>>
>>> db_text: add db_delim parameter
>>>
>>> - make the delimiter between fields in th db_text file configurable;
>>>useful when one would need to escape a lot of appearances of the
>>>default delimiter (';' in IPv6 addresses).
>>>
>>> ---
>>>
>>> Modified: src/modules/db_text/db_text.c
>>> Modified: src/modules/db_text/dbt_file.c
>>> Modified: src/modules/db_text/dbt_lib.h
>>> Modified: src/modules/db_text/doc/db_text_admin.xml
>>>
>>> ---
>>>
>>> Diff: 
>>> https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31.diff
>>> Patch:
>>> https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31.patch
>>>
>>>
>>> ___
>>> Kamailio (SER) - Development Mailing List
>>> sr-dev@lists.kamailio.org
>>> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>

-- 
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - May 22-24 (USA) - www.asipto.com
Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] git:5.0:4ad64c0f: db_text: add db_delim parameter

2017-04-24 Thread Lucian Balaceanu

Hello Daniel,

I am sorry for this situation; do I revert the commit?

Thank you,
Lucian

On 24.04.2017 17:41, Daniel-Constantin Mierla wrote:

Hello,

the rule is not to backport new features to stable versions, because we
will end up in a mixture of untested code where stability cannot be ensured.

I don't feel that this commit is fixing an existing issues, rather
making it more aesthetic in some cases.

If I got it wrong, please provide more details and if other developers
are fine with this backport, I won't be against it.

Cheers,
Daniel

On 24.04.17 16:36, Lucian Balaceanu wrote:

Module: kamailio
Branch: 5.0
Commit: 4ad64c0ff0384b232b7c198316b46a86ad2c4f31
URL: 
https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31

Author: Lucian Balaceanu 
Committer: Lucian Balaceanu 
Date: 2017-04-24T17:31:45+03:00

db_text: add db_delim parameter

- make the delimiter between fields in th db_text file configurable;
   useful when one would need to escape a lot of appearances of the
   default delimiter (';' in IPv6 addresses).

---

Modified: src/modules/db_text/db_text.c
Modified: src/modules/db_text/dbt_file.c
Modified: src/modules/db_text/dbt_lib.h
Modified: src/modules/db_text/doc/db_text_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31.diff
Patch: 
https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev



___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:8be11111: app_sqlang: link against libstdc++

2017-04-24 Thread Daniel-Constantin Mierla
Module: kamailio
Branch: master
Commit: 8be15e2748cbde4ce841ae72b49badb7e4d5
URL: 
https://github.com/kamailio/kamailio/commit/8be15e2748cbde4ce841ae72b49badb7e4d5

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2017-04-24T16:51:30+02:00

app_sqlang: link against libstdc++

- fix on linux for undefined symbol: __cxa_pure_virtual

---

Modified: src/modules/app_sqlang/Makefile

---

Diff:  
https://github.com/kamailio/kamailio/commit/8be15e2748cbde4ce841ae72b49badb7e4d5.diff
Patch: 
https://github.com/kamailio/kamailio/commit/8be15e2748cbde4ce841ae72b49badb7e4d5.patch

---

diff --git a/src/modules/app_sqlang/Makefile b/src/modules/app_sqlang/Makefile
index 129a93e..481d13e 100644
--- a/src/modules/app_sqlang/Makefile
+++ b/src/modules/app_sqlang/Makefile
@@ -8,7 +8,7 @@ auto_gen=
 NAME=app_sqlang.so
 
 DEFS+=-DKAMAILIO_MOD_INTERFACE -I./squirrel/include
-LIBS += -L. -lsquirrel -lsqstdlib
+LIBS += -L. -lsquirrel -lsqstdlib -lstdc++
 
 include ../../Makefile.modules
 


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] git:5.0:4ad64c0f: db_text: add db_delim parameter

2017-04-24 Thread Daniel-Constantin Mierla
Hello,

the rule is not to backport new features to stable versions, because we
will end up in a mixture of untested code where stability cannot be ensured.

I don't feel that this commit is fixing an existing issues, rather
making it more aesthetic in some cases.

If I got it wrong, please provide more details and if other developers
are fine with this backport, I won't be against it.

Cheers,
Daniel

On 24.04.17 16:36, Lucian Balaceanu wrote:
> Module: kamailio
> Branch: 5.0
> Commit: 4ad64c0ff0384b232b7c198316b46a86ad2c4f31
> URL: 
> https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31
>
> Author: Lucian Balaceanu 
> Committer: Lucian Balaceanu 
> Date: 2017-04-24T17:31:45+03:00
>
> db_text: add db_delim parameter
>
> - make the delimiter between fields in th db_text file configurable;
>   useful when one would need to escape a lot of appearances of the
>   default delimiter (';' in IPv6 addresses).
>
> ---
>
> Modified: src/modules/db_text/db_text.c
> Modified: src/modules/db_text/dbt_file.c
> Modified: src/modules/db_text/dbt_lib.h
> Modified: src/modules/db_text/doc/db_text_admin.xml
>
> ---
>
> Diff:  
> https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31.diff
> Patch: 
> https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31.patch
>
>
> ___
> Kamailio (SER) - Development Mailing List
> sr-dev@lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - May 22-24 (USA) - www.asipto.com
Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:50718957: misc/examples: more complex example of using sqlang kemi interpreter

2017-04-24 Thread Daniel-Constantin Mierla
Module: kamailio
Branch: master
Commit: 5071895772c42699bad6cfc982c89e3faccad29f
URL: 
https://github.com/kamailio/kamailio/commit/5071895772c42699bad6cfc982c89e3faccad29f

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2017-04-24T16:36:27+02:00

misc/examples: more complex example of using sqlang kemi interpreter

---

Added: misc/examples/kemi/kamailio-basic-kemi-sqlang.sq
Modified: misc/examples/kemi/kamailio-basic-kemi.cfg

---

Diff:  
https://github.com/kamailio/kamailio/commit/5071895772c42699bad6cfc982c89e3faccad29f.diff
Patch: 
https://github.com/kamailio/kamailio/commit/5071895772c42699bad6cfc982c89e3faccad29f.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Paul Claudiu Boriga
I resolved the conflicts in the PR. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1079#issuecomment-296679014___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Paul Claudiu Boriga
@claudiupb pushed 1 commit.

83c68c5  fix indentation


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1079/files/f3a00aa8f78a441cc427f43ba65ae8ef8434a2be..83c68c5ededc0a5f06bb8d2fa3d778e7a6a17675
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Paul Claudiu Boriga
@claudiupb pushed 1 commit.

f3a00aa  Merge branch 'master' into redis_pipeline


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1079/files/0a0ac0eabb0e635d7d0ed64746df7d22512d4f47..f3a00aa8f78a441cc427f43ba65ae8ef8434a2be
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Daniel-Constantin Mierla
@claudiupb - can you resolve the conflicts so this PR can be merged? The module 
was in a broken state at the time you did the PR, which needed to be fixed, 
sorry for the extra work.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1079#issuecomment-296672929___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:3efdeefd: acc: exported functions to kemi framework

2017-04-24 Thread Daniel-Constantin Mierla
Module: kamailio
Branch: master
Commit: 3efdeefdf80c3bc544b19f260981ea5d98d71ff7
URL: 
https://github.com/kamailio/kamailio/commit/3efdeefdf80c3bc544b19f260981ea5d98d71ff7

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2017-04-24T15:38:24+02:00

acc: exported functions to kemi framework

---

Modified: src/modules/acc/acc_logic.c
Modified: src/modules/acc/acc_logic.h
Modified: src/modules/acc/acc_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/3efdeefdf80c3bc544b19f260981ea5d98d71ff7.diff
Patch: 
https://github.com/kamailio/kamailio/commit/3efdeefdf80c3bc544b19f260981ea5d98d71ff7.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:ec8f7722: app_sqlang: fixed compile warnings about unused code

2017-04-24 Thread Daniel-Constantin Mierla
Module: kamailio
Branch: master
Commit: ec8f7722b8e9380f1357796da33da735cfb72913
URL: 
https://github.com/kamailio/kamailio/commit/ec8f7722b8e9380f1357796da33da735cfb72913

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2017-04-24T15:00:30+02:00

app_sqlang: fixed compile warnings about unused code

---

Modified: src/modules/app_sqlang/app_sqlang_api.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/ec8f7722b8e9380f1357796da33da735cfb72913.diff
Patch: 
https://github.com/kamailio/kamailio/commit/ec8f7722b8e9380f1357796da33da735cfb72913.patch

---

diff --git a/src/modules/app_sqlang/app_sqlang_api.c 
b/src/modules/app_sqlang/app_sqlang_api.c
index e654cdc..d1c6b79 100644
--- a/src/modules/app_sqlang/app_sqlang_api.c
+++ b/src/modules/app_sqlang/app_sqlang_api.c
@@ -248,6 +248,7 @@ static int sqlang_isfunction(HSQUIRRELVM J, int idx)
}
 }
 
+#if 0
 static char* sqlang_safe_tostring(HSQUIRRELVM J, int idx)
 {
const SQChar *s = NULL;
@@ -260,6 +261,7 @@ static char* sqlang_safe_tostring(HSQUIRRELVM J, int idx)
}
return (s)?(char*)s:"Error on sqlang";
 }
+#endif
 
 static int sqlang_gettype(HSQUIRRELVM J, int idx)
 {
@@ -946,7 +948,6 @@ int app_sqlang_run_ex(sip_msg_t *msg, char *func, char *p1, 
char *p2,
 {
int n;
int ret;
-   str txt;
int top;
sip_msg_t *bmsg;
SQInteger rv;


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] dialog: execute pre script callback only when event route is set (7004969)

2017-04-24 Thread Victor Seva
forget it, I was mistaken. sorry for the noise

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/7004969cf94815167d72d2e7158e4754c730ff1d#commitcomment-21878037___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:73ae92bc: modules: readme files regenerated - ndb_redis ... [skip ci]

2017-04-24 Thread Kamailio Dev
Module: kamailio
Branch: master
Commit: 73ae92bc900472eb6afee12da6265798a59a8cef
URL: 
https://github.com/kamailio/kamailio/commit/73ae92bc900472eb6afee12da6265798a59a8cef

Author: Kamailio Dev 
Committer: Kamailio Dev 
Date: 2017-04-24T14:31:32+02:00

modules: readme files regenerated - ndb_redis ... [skip ci]

---

Modified: src/modules/ndb_redis/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/73ae92bc900472eb6afee12da6265798a59a8cef.diff
Patch: 
https://github.com/kamailio/kamailio/commit/73ae92bc900472eb6afee12da6265798a59a8cef.patch

---

diff --git a/src/modules/ndb_redis/README b/src/modules/ndb_redis/README
index 3613f57..54c6ad7 100644
--- a/src/modules/ndb_redis/README
+++ b/src/modules/ndb_redis/README
@@ -187,10 +187,22 @@ modparam("ndb_redis", "cmd_timeout", 500)
If set to 1, the module will connect to servers indicated in the
"MOVED" reply.
 
+   The module needs to know all existing REDIS-Nodes at startup. The nodes
+   are searched by the name "ip:port", e.g. if REDIS replies with "MOVED
+   127.0.0.1:4711", ndb_redis needs to know the databases
+   "127.0.0.1:4711".
+
Default value is “0” (disabled).
 
Example 1.5. Set cluster parameter
 ...
+modparam("ndb_redis", "server", 
"name=127.0.0.1:26001;addr=127.0.0.1;port=26001"
+)
+modparam("ndb_redis", "server", 
"name=127.0.0.1:26004;addr=127.0.0.1;port=26004"
+)
+modparam("ndb_redis", "server", 
"name=127.0.0.1:26008;addr=127.0.0.1;port=26008"
+)
+...
 modparam("ndb_redis", "cluster", 1)
 ...
 


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:3c1f6a51: Fix ndb_redis Cluster implementation

2017-04-24 Thread Carsten Bock
Module: kamailio
Branch: master
Commit: 3c1f6a51e830f6b3c3d98b32178c3cf6af16f62d
URL: 
https://github.com/kamailio/kamailio/commit/3c1f6a51e830f6b3c3d98b32178c3cf6af16f62d

Author: Carsten Bock 
Committer: Carsten Bock 
Date: 2017-04-24T14:23:47+02:00

Fix ndb_redis Cluster implementation

---

Modified: src/modules/ndb_redis/doc/ndb_redis_admin.xml
Modified: src/modules/ndb_redis/ndb_redis_mod.c
Modified: src/modules/ndb_redis/redis_client.c
Modified: src/modules/ndb_redis/redis_client.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/3c1f6a51e830f6b3c3d98b32178c3cf6af16f62d.diff
Patch: 
https://github.com/kamailio/kamailio/commit/3c1f6a51e830f6b3c3d98b32178c3cf6af16f62d.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] pkg/kamailio: Fix of ticket 1085 (#1086)

2017-04-24 Thread sergey-safarov
@linuxmaniac yes, unit will be restarted infinity, Rate of restarts may limiter 
using "RestartSec" keyword

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1086#issuecomment-296640401___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Daemon not restated if process exited with not null code (#1085)

2017-04-24 Thread sergey-safarov
Hello @linuxmaniac 
Yes, I want say "non-zero exit code" or  "Unclean exit code"
Clean exit code is "0" or codes marked as "SuccessExitStatus"
Please see same link

> SuccessExitStatus=1 2 8 SIGKILL
> ensures that exit codes 1, 2, 8 and the termination signal SIGKILL are 
> considered clean service terminations.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1085#issuecomment-296637582___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:e94e9d8b: Merge pull request #1078 from lbalaceanu/replace_db_text_delim

2017-04-24 Thread GitHub
Module: kamailio
Branch: master
Commit: e94e9d8bdcdb3d340b14868f9d7e52ef0ab71894
URL: 
https://github.com/kamailio/kamailio/commit/e94e9d8bdcdb3d340b14868f9d7e52ef0ab71894

Author: Lucian Balaceanu 
Committer: GitHub 
Date: 2017-04-24T14:07:59+03:00

Merge pull request #1078 from lbalaceanu/replace_db_text_delim

db_text: introduce db_delim parameter

---

Modified: src/modules/db_text/db_text.c
Modified: src/modules/db_text/dbt_file.c
Modified: src/modules/db_text/dbt_lib.h
Modified: src/modules/db_text/doc/db_text_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/e94e9d8bdcdb3d340b14868f9d7e52ef0ab71894.diff
Patch: 
https://github.com/kamailio/kamailio/commit/e94e9d8bdcdb3d340b14868f9d7e52ef0ab71894.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] pkg/kamailio: Fix of ticket 1085 (#1086)

2017-04-24 Thread Victor Seva
What happens if you have a non-working config and you have `on-failure`? I 
would assume the daemon will be restarted forever

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1086#issuecomment-296593428___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Daemon not restated if process exited with not null code (#1085)

2017-04-24 Thread Victor Seva
What do you mean by 'not null code'?

>From https://www.freedesktop.org/software/systemd/man/systemd.service.html

```
Restart:
[...] If set to on-failure, the service will be restarted when the process 
exits with a non-zero exit code, is terminated by a signal (including on core 
dump, but excluding the aforementioned four signals), when an operation (such 
as service reload) times out, and when the configured watchdog timeout is 
triggered.
[...] If set to on-abort, the service will be restarted only if the service 
process exits due to an uncaught signal not specified as a clean exit status. 
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1085#issuecomment-296592791___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] pkg/kamailio: Fix of ticket 1085 (#1086)

2017-04-24 Thread Victor Seva
See my comment at 
https://github.com/kamailio/kamailio/issues/1085#issuecomment-296592791

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1086#issuecomment-296593042___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] pkg/kamailio: Fix of ticket 1085 (#1086)

2017-04-24 Thread Daniel-Constantin Mierla
@linuxmaniac - are you ok with the changes proposed for deb packaging regarding 
the systemd?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1086#issuecomment-296591080___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Daniel-Constantin Mierla
Pinging Carsten (@ngvoice) -- is it needed to wait for fixing the changes done 
by using shm memory or this PR can be merged?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1079#issuecomment-296590855___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] db_text: change field separator from ":" to "|" (#1078)

2017-04-24 Thread Daniel-Constantin Mierla
Thanks! It is ok to merge.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1078#issuecomment-296590125___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] db_text: change field separator from ":" to "|" (#1078)

2017-04-24 Thread Lucian Balaceanu
Updated code in the merge branch. If this also looks good to you I will close 
the merge.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1078#issuecomment-296551283___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev