Re: [sr-dev] [kamailio/kamailio] pua_reginfo: use outbound proxy for PUBLISHes (#1177)

2017-07-03 Thread Vasiliy Ganchev
Thanks for accepting, next time I will try to prepare all the things thoroughly! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] deb nightly-builds not being built

2017-07-03 Thread Victor Seva
We are having some issues with our building infrastructure so packages are not being built. We are working on it, please be patient. Cheers, Victor signature.asc Description: OpenPGP digital signature ___ Kamailio (SER) - Development Mailing List

[sr-dev] git:master:e4f0facc: modules: readme files regenerated - pua_reginfo ... [skip ci]

2017-07-03 Thread Kamailio Dev
Module: kamailio Branch: master Commit: e4f0facccb130599acfd0c4abbfd954a427c3d96 URL: https://github.com/kamailio/kamailio/commit/e4f0facccb130599acfd0c4abbfd954a427c3d96 Author: Kamailio Dev Committer: Kamailio Dev Date:

Re: [sr-dev] [kamailio/kamailio] pua_reginfo: use outbound proxy for PUBLISHes (#1177)

2017-07-03 Thread Daniel-Constantin Mierla
The first commit had the message ok, but the second didn't -- it didn't explain what the patch does effectively: 'correct docs' or 'fixed code' are not useful at all; a useful example: 'reflect that outbound proxy is used for PUBLISH in docs'. Anyhow, I merged the PR manually. Thanks! -- You

Re: [sr-dev] [kamailio/kamailio] pua_reginfo: use outbound proxy for PUBLISHes (#1177)

2017-07-03 Thread Daniel-Constantin Mierla
Closed #1177. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1177#event-1148474374___ Kamailio (SER) - Development Mailing List

[sr-dev] git:master:385995c2: pua_reginfo: use outbound proxy for PUBLISH requests

2017-07-03 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 385995c27084bdca9ebc4a472f9ab41311416f35 URL: https://github.com/kamailio/kamailio/commit/385995c27084bdca9ebc4a472f9ab41311416f35 Author: Vasiliy Ganchev Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] ndb_redis: enhance debug info related to redis replies (#1175)

2017-07-03 Thread Daniel-Constantin Mierla
Merged #1175. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1175#event-1148465872___ Kamailio (SER) - Development Mailing List

[sr-dev] git:master:6002f2de: ndb_redis: enhance debug info related to redis replies

2017-07-03 Thread Claudiu Boriga
Module: kamailio Branch: master Commit: 6002f2de79b1f344bf9326763d63a1f978d0ddc7 URL: https://github.com/kamailio/kamailio/commit/6002f2de79b1f344bf9326763d63a1f978d0ddc7 Author: Claudiu Boriga Committer: Claudiu Boriga Date:

[sr-dev] git:master:4168a6c3: Merge pull request #1175 from claudiupb/redis_enhance_debug

2017-07-03 Thread GitHub
Module: kamailio Branch: master Commit: 4168a6c3221f95e50aa7a0769d1abecfa255fa10 URL: https://github.com/kamailio/kamailio/commit/4168a6c3221f95e50aa7a0769d1abecfa255fa10 Author: Daniel-Constantin Mierla Committer: GitHub Date: 2017-07-03T18:52:32+02:00

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.0.2 suddenly stops processing traffic, then generates a core when restarting. (#1172)

2017-07-03 Thread Joel Serrano
Hi Daniel, thanks for helping troubleshoot the issue. I have Kamailio v4.4 with Debian 8 working with TLS on other servers and we have had 0 problems (OpenSSL v1.0) If I install the kamailio 5 nightly deb build from tomorrow, would your latest patch be applied? Or should I manually compile

Re: [sr-dev] tls warnings

2017-07-03 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > The warnings were reported before: > > - https://lists.kamailio.org/pipermail/sr-dev/2017-April/040137.html > > Meanwhile (recently) I fixed them in master branch (see git log for > src/modules/tls/) and I am fine to backport provided that someone does >

Re: [sr-dev] [kamailio/kamailio] Incorrect translation of tel: uri to sip: uri in tel2sip() (#1173)

2017-07-03 Thread Juha Heinanen
Donald Carr writes: > At the link below, you can go to 19.1.6. It is a very strange ordering > giving priority to two parameters that should be first, if present. > > https://www.ietf.org/rfc/rfc3261.txt > > 19.1.6 Relating SIP URIs and tel URLs > . . . . > ``` >To mitigate this problem,

[sr-dev] git:master:3ce65db8: cfgutils: more log messages for locking functions

2017-07-03 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 3ce65db8747ad7b382824f389c2b782a76dbb7a1 URL: https://github.com/kamailio/kamailio/commit/3ce65db8747ad7b382824f389c2b782a76dbb7a1 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] Incorrect translation of tel: uri to sip: uri in tel2sip() (#1173)

2017-07-03 Thread Donald Carr
Actually, I intended to use most of the existing function, just inserting a sort, and, removal of duplicate domain. But, yes, it could be a new function, leaving the existing one exactly as-is. It would also be nice for the update to be active without having to edit the configuration file. I

Re: [sr-dev] [kamailio/kamailio] Incorrect translation of tel: uri to sip: uri in tel2sip() (#1173)

2017-07-03 Thread Daniel-Constantin Mierla
@doncarr - ti can be also a new function, like tel_to_sip_uri(), so if one wants to use the old/lightweight version can still do it. I guess the new function is not going to share too much code with the old onw. -- You are receiving this because you commented. Reply to this email directly or

Re: [sr-dev] [kamailio/kamailio] Incorrect translation of tel: uri to sip: uri in tel2sip() (#1173)

2017-07-03 Thread Donald Carr
At the link below, you can go to 19.1.6. It is a very strange ordering giving priority to two parameters that should be first, if present. https://www.ietf.org/rfc/rfc3261.txt 19.1.6 Relating SIP URIs and tel URLs . . . . ``` To mitigate this problem, elements constructing

Re: [sr-dev] tls warnings

2017-07-03 Thread Daniel-Constantin Mierla
The warnings were reported before: - https://lists.kamailio.org/pipermail/sr-dev/2017-April/040137.html Meanwhile (recently) I fixed them in master branch (see git log for src/modules/tls/) and I am fine to backport provided that someone does some proper testing on Stretch -- I have a devel VM

Re: [sr-dev] [kamailio/kamailio] Incorrect translation of tel: uri to sip: uri in tel2sip() (#1173)

2017-07-03 Thread Juha Heinanen
Donald Carr writes: > @miconda, I have written a routine that puts the parameters for the > tel: uri into an array with key/value separated, then uses qsort to > sort. With this, they can be put into the sip: uri in correct sorted > order. The sort is very esoteric, specific to the requirements

[sr-dev] tls warnings

2017-07-03 Thread Juha Heinanen
I got these TLS related warnings when compiling K 5.0 on Debian Stretch. -- Juha CC (gcc) [M tls.so] tls_init.o tls_init.c: In function 'init_ssl_methods': tls_init.c:377:2: warning: 'TLSv1_client_method' is deprecated [-Wdeprecated-declarations] ssl_methods[TLS_USE_TLSv1_cli - 1]

Re: [sr-dev] [kamailio/kamailio] Incorrect translation of tel: uri to sip: uri in tel2sip() (#1173)

2017-07-03 Thread Donald Carr
@miconda, I have written a routine that puts the parameters for the tel: uri into an array with key/value separated, then uses qsort to sort. With this, they can be put into the sip: uri in correct sorted order. The sort is very esoteric, specific to the requirements for sip: uri when

[sr-dev] [kamailio/kamailio] pua_reginfo: use outbound proxy for PUBLISHes (#1177)

2017-07-03 Thread Vasiliy Ganchev
Hi again, duplicate of [previous pull](https://github.com/kamailio/kamailio/pull/1176), as there is some mess. Hope this time is better. thanks! You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1177 -- Commit Summary -- *

Re: [sr-dev] [kamailio/kamailio] pua_reginfo: use outbound proxy for PUBLISHes (#1176)

2017-07-03 Thread Vasiliy Ganchev
Closed #1176. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1176#event-1148196622___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] ndb_redis: enhance debug info related to redis replies (#1175)

2017-07-03 Thread Paul Claudiu Boriga
I have modified the commit to use is_printable, instead of defining a new function to get the log level for redis module. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] pua_reginfo: use outbound proxy for PUBLISHes (#1176)

2017-07-03 Thread Daniel-Constantin Mierla
The commit message is not good, it is `Update usrloc_cb.c`, whichd doesn't describe what the patch does, not it follows the guidelines for contributions. Actually, the title of this pull request is suitable for commit message -- see: *

[sr-dev] [kamailio/kamailio] pua_reginfo: use outbound proxy for PUBLISHes (#1176)

2017-07-03 Thread Vasiliy Ganchev
Hi, guys! Pua module provides a callback "send_publish". One of the parameters is "outbound_proxy", but pua_reginfo does not use it, even if the parameter is specified. Documentation says: "The outbound_proxy uri to be used when sending Subscribe requests." Any reason to use it only for

Re: [sr-dev] [kamailio/kamailio] ndb_redis: enhance debug info related to redis replies (#1175)

2017-07-03 Thread Paul Claudiu Boriga
claudiupb commented on this pull request. > @@ -1061,3 +1067,57 @@ int redis_count_err_and_disable(redisc_server_t *rsrv) } return 0; } + +void print_redis_reply(int log_level, redisReply *rpl,int offset) +{ + int i; + char padding[MAXIMUM_NESTED_KEYS + 1]; + +

Re: [sr-dev] [kamailio/kamailio] ndb_redis: enhance debug info related to redis replies (#1175)

2017-07-03 Thread Daniel-Constantin Mierla
miconda commented on this pull request. > @@ -1061,3 +1067,57 @@ int redis_count_err_and_disable(redisc_server_t *rsrv) } return 0; } + +void print_redis_reply(int log_level, redisReply *rpl,int offset) +{ + int i; + char padding[MAXIMUM_NESTED_KEYS + 1]; + +

[sr-dev] [kamailio/kamailio] ndb_redis: enhance debug info related to redis replies (#1175)

2017-07-03 Thread Paul Claudiu Boriga
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README

[sr-dev] git:master:8eb84f76: core: parse rr - reset head in case of parse error

2017-07-03 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 8eb84f76a6d52598bb2fd5d13b96fba4c6326b7f URL: https://github.com/kamailio/kamailio/commit/8eb84f76a6d52598bb2fd5d13b96fba4c6326b7f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:dbd52dac: core: avoid accessing freed structure in case of duplicated listen addresses

2017-07-03 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: dbd52dacae17eca5a48359c605a2d93607b7c041 URL: https://github.com/kamailio/kamailio/commit/dbd52dacae17eca5a48359c605a2d93607b7c041 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.0.2 suddenly stops processing traffic, then generates a core when restarting. (#1172)

2017-07-03 Thread Daniel-Constantin Mierla
It looks like something blocked on tls processing. The process 14848 is doing: ``` #0 __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135 No locals. #1 0x7f4fdee39c50 in __GI___pthread_rwlock_unlock (rwlock=0x7f4dde916288) at pthread_rwlock_unlock.c:42

Re: [sr-dev] [kamailio/kamailio] Kamailio does not set the right advertised RR (#1174)

2017-07-03 Thread Daniel-Constantin Mierla
Afaik, this config param was always only for Via headers. For Record-Route, there are some functions inside the rr module targeting this option. Anyhow, I think `advertised_address` and `advertised_port` should be deprecated and removed, in favor of `advertise` option for `listen` parameter. I

Re: [sr-dev] [kamailio/kamailio] Kamailio does not set the right advertised RR (#1174)

2017-07-03 Thread Daniel-Constantin Mierla
Closed #1174. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1174#event-1148041527___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] CDR information is not getting logged, when dialog:end takes too long

2017-07-03 Thread Daniel-Constantin Mierla
Hello, do you have proper retransmission detection in the kamailio.cfg? If you look at etc/kamailio.cfg with the latest master, it uses t_precheck_trans() to detect the retransmission in early phase and not allow parallel processing of the same request. If routing of BYE doesn't depend on any

[sr-dev] git:master:b95e5363: enum: fixed code for country code length

2017-07-03 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: b95e536335083ee6f1f67e2007463ac7e8403ec8 URL: https://github.com/kamailio/kamailio/commit/b95e536335083ee6f1f67e2007463ac7e8403ec8 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:366104d2: seas: avoid double free and leak

2017-07-03 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 366104d2f79ccfa65850cd2e3bfb5ed8be467bc2 URL: https://github.com/kamailio/kamailio/commit/366104d2f79ccfa65850cd2e3bfb5ed8be467bc2 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:b3030a29: enum: free variable in case of error and safety check for returned pointer

2017-07-03 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: b3030a2965889a788093b2c372c1d7ac9441e8cc URL: https://github.com/kamailio/kamailio/commit/b3030a2965889a788093b2c372c1d7ac9441e8cc Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:8b0a42ab: rr: use macro to get parsed From in record_route_preset()

2017-07-03 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 8b0a42ab64c02a1fa253ce156442bab64a4fe3db URL: https://github.com/kamailio/kamailio/commit/8b0a42ab64c02a1fa253ce156442bab64a4fe3db Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: