Re: [sr-dev] rfc: clang format the code

2017-11-23 Thread Daniel-Constantin Mierla
Hello Henning, indeed, git blame is not going to show directly the original author... as I wanted to see if there is a solution for this, I found:   - https://blog.andrewray.me/a-better-git-blame/ and actually a comment there seems to be a decent solution to go back in the history of the

Re: [sr-dev] add_contact_alias(0) is proto differs

2017-11-23 Thread Daniel-Constantin Mierla
On 24.11.17 01:56, Juha Heinanen wrote: > When adding transport proto check to add_contact_alias, I noticed that > in receive_info struct proto is defined like this: > > char proto; > > and in sip_uri struct like this: > > unsigned short proto; /*!< from transport */ > > That does not

Re: [sr-dev] rfc: clang format the code

2017-11-23 Thread Henning Westerholt
Am Donnerstag, 23. November 2017, 17:20:48 CET schrieb Daniel-Constantin Mierla: > it was discussed during the last irc devel meeting and everyone there > agreed to use clang-format to format the source code: > > - https://clang.llvm.org/docs/ClangFormat.html > > Is any developer (maybe not

Re: [sr-dev] add_contact_alias(0) is proto differs

2017-11-23 Thread Daniel-Constantin Mierla
On 24.11.17 01:26, Juha Heinanen wrote: > Currently add_contact_alias() works like this: > > Adds an “;alias=ip~port~transport” parameter to the contact URI > containing either received ip, port, and transport protocol or those > given as parameters. If called without parameters, “;alias”

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » i386,trusty,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » i386,jessie,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » i386,squeeze,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » i386,precise,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » amd64,wheezy,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » amd64,squeeze,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » i386,xenial,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » amd64,precise,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » amd64,xenial,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » amd64,jessie,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » i386,wheezy,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-binaries » amd64,trusty,slave #122

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-source » wheezy,master #123

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-source » trusty,master #123

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-source » squeeze,master #123

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-source » precise,master #123

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-source » xenial,master #123

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build became unstable: kamailio44-nightly-source » jessie,master #123

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] add_contact_alias(0) is proto differs

2017-11-23 Thread Juha Heinanen
When adding transport proto check to add_contact_alias, I noticed that in receive_info struct proto is defined like this: char proto; and in sip_uri struct like this: unsigned short proto; /*!< from transport */ That does not look good to me. They should have the same type in

[sr-dev] add_contact_alias(0) is proto differs

2017-11-23 Thread Juha Heinanen
Currently add_contact_alias() works like this: Adds an “;alias=ip~port~transport” parameter to the contact URI containing either received ip, port, and transport protocol or those given as parameters. If called without parameters, “;alias” parameter is only added if received ip and port

[sr-dev] git:master:a9ef7fe0: ndb_redis: exported redis_cmd() and redis_free() to kemi framework

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: a9ef7fe010492710e0a81a4505337accb5e1fea6 URL: https://github.com/kamailio/kamailio/commit/a9ef7fe010492710e0a81a4505337accb5e1fea6 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] rfc: clang format the code

2017-11-23 Thread Daniel-Constantin Mierla
Hello, it was discussed during the last irc devel meeting and everyone there agreed to use clang-format to format the source code:   - https://clang.llvm.org/docs/ClangFormat.html Is any developer (maybe not present during the irc devel meeting) opposing this? It is not going to be all at

[sr-dev] git:master:ccbd1176: http_client: print url in log messages if query return code is not ok

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: ccbd1176242632fae2af39a168e4692dcf7ebcf9 URL: https://github.com/kamailio/kamailio/commit/ccbd1176242632fae2af39a168e4692dcf7ebcf9 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] OBS spec update for 5.1.0 release (#1316)

2017-11-23 Thread sergey-safarov
yes, Daniel. This may be merged. Readme instruction i can check when get access to RHEL with optional repo. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1329)

2017-11-23 Thread Daniel-Constantin Mierla
Merged #1329. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1329#event-1355790565___ Kamailio (SER) - Development Mailing List

[sr-dev] git:4.4:3037665c: rtpengine: fixed segfault when using read_sdp_pv

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 4.4 Commit: 3037665c0794c5e00f074a7e389793a29ba9b960 URL: https://github.com/kamailio/kamailio/commit/3037665c0794c5e00f074a7e389793a29ba9b960 Author: Phil Lavin Committer: Daniel-Constantin Mierla Date:

[sr-dev] [kamailio/kamailio] pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject (#1330)

2017-11-23 Thread sergey-safarov
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1330 -- Commit Summary -- * pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject -- File Changes -- A .gitmodules (3) A pkg/docker (1) M

Re: [sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1327)

2017-11-23 Thread Daniel-Constantin Mierla
Merged #1327. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1327#event-1355660852___ Kamailio (SER) - Development Mailing List

[sr-dev] git:5.0:bae64449: rtpengine: fixed segfault when using read_sdp_pv

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.0 Commit: bae644494e3ad1a1384def016a9343c073cfe1a6 URL: https://github.com/kamailio/kamailio/commit/bae644494e3ad1a1384def016a9343c073cfe1a6 Author: Phil Lavin Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1328)

2017-11-23 Thread Daniel-Constantin Mierla
Merged #1328. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1328#event-1355659857___ Kamailio (SER) - Development Mailing List

[sr-dev] git:5.1:096de8d0: rtpengine: fixed segfault when using read_sdp_pv

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.1 Commit: 096de8d0979a71005e3f52146252365b53ab6197 URL: https://github.com/kamailio/kamailio/commit/096de8d0979a71005e3f52146252365b53ab6197 Author: Phil Lavin Committer: Daniel-Constantin Mierla Date:

[sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1328)

2017-11-23 Thread Phil Lavin
Backport of #1326 to 5.1 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1328 -- Commit Summary -- * rtpengine: fixed segfault when using read_sdp_pv -- File Changes -- M src/modules/rtpengine/rtpengine.c (8) -- Patch Links --

[sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1327)

2017-11-23 Thread Phil Lavin
Backport of #1326 to 5.0 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1327 -- Commit Summary -- * rtpengine: fixed segfault when using read_sdp_pv -- File Changes -- M src/modules/rtpengine/rtpengine.c (8) -- Patch Links --

[sr-dev] git:master:873ffcad: modules: readme files regenerated - app_python ... [skip ci]

2017-11-23 Thread Kamailio Dev
Module: kamailio Branch: master Commit: 873ffcad3a609d1372eed8e8b4e6a3ff033bc524 URL: https://github.com/kamailio/kamailio/commit/873ffcad3a609d1372eed8e8b4e6a3ff033bc524 Author: Kamailio Dev Committer: Kamailio Dev Date:

[sr-dev] git:master:cbaceaf8: app_python: documented rpc commands

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: cbaceaf891e16e9b0a1ef4883b8fec5e33698a86 URL: https://github.com/kamailio/kamailio/commit/cbaceaf891e16e9b0a1ef4883b8fec5e33698a86 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:bea0b53c: app_python: implemented rpc command to list kemi functions

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: bea0b53ce57f08ab9fc019c19f616b3b67795d64 URL: https://github.com/kamailio/kamailio/commit/bea0b53ce57f08ab9fc019c19f616b3b67795d64 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1326)

2017-11-23 Thread Phil Lavin
Already ported it to 4.2 as that's what we're running on this particular proxy. I'll submit PRs for 5.0, 5.1 and 4.4. Thanks! :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1326)

2017-11-23 Thread Daniel-Constantin Mierla
Do it for 5.0 and 5.1, it should be straightforward. For 4.4 might need some more work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1326)

2017-11-23 Thread Phil Lavin
Can you remind me which versions are still being supported? I'll create backport PRs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1326)

2017-11-23 Thread Daniel-Constantin Mierla
Merged #1326. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1326#event-1355580442___ Kamailio (SER) - Development Mailing List

[sr-dev] git:master:76085672: Merge pull request #1326 from phil-lavin/bugfix-rtpengine-read-sdp

2017-11-23 Thread GitHub
Module: kamailio Branch: master Commit: 76085672c0f00d8539ab16652d4404266ad8184c URL: https://github.com/kamailio/kamailio/commit/76085672c0f00d8539ab16652d4404266ad8184c Author: Daniel-Constantin Mierla Committer: GitHub Date: 2017-11-23T11:59:23+01:00

Re: [sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1326)

2017-11-23 Thread Daniel-Constantin Mierla
Thanks! It will be merged. For convenience, can you make pull requests for stable branches? It makes it faster to backport by merging them via web here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:4bd1d70c: tm: fixed condition in via_matching()

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 4bd1d70c2804ee2a1d29bd911275aa241577cfc1 URL: https://github.com/kamailio/kamailio/commit/4bd1d70c2804ee2a1d29bd911275aa241577cfc1 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] [kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1326)

2017-11-23 Thread Phil Lavin
Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [X] PR should be backported to stable branches

[sr-dev] Jenkins build is back to stable : kamailio50-nightly-binaries » amd64,xenial,slave #101

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build is back to stable : kamailio50-nightly-binaries » i386,trusty,slave #101

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build is back to stable : kamailio50-nightly-binaries » amd64,trusty,slave #101

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject (#1323)

2017-11-23 Thread Daniel-Constantin Mierla
Merged #1323. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1323#event-1355443952___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject (#1323)

2017-11-23 Thread Daniel-Constantin Mierla
Btw, can you make a PR also for branch 5.1? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1323#issuecomment-346568500___ Kamailio (SER)

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject (#1323)

2017-11-23 Thread Daniel-Constantin Mierla
Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1323#issuecomment-346568439___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] OBS spec update for 5.1.0 release (#1316)

2017-11-23 Thread Daniel-Constantin Mierla
@sergey-safarov, @oyvindkolbu -- was all sorted out here? Should I merge this one? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] Jenkins build is back to stable : kamailio50-nightly-binaries » i386,precise,slave #101

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

Re: [sr-dev] [kamailio/kamailio] cfg_rpc: extending the functionality of cfg.get command (#1321)

2017-11-23 Thread Daniel-Constantin Mierla
miconda commented on this pull request. > + str group, var; + void*val; + unsigned intval_type; + int ret, n; + unsigned int*group_id; + + n = rpc->scan(c, "SS", , ); + /* 2: both group and variable name are present +* -1:

[sr-dev] Jenkins build is back to stable : kamailio50-nightly-binaries » amd64,stretch,slave #101

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build is back to stable : kamailio50-nightly-binaries » i386,xenial,slave #101

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] git:master:7b61c725: modules: readme files regenerated - drouting ... [skip ci]

2017-11-23 Thread Kamailio Dev
Module: kamailio Branch: master Commit: 7b61c725bd867540197e695cad1f61e494d0a869 URL: https://github.com/kamailio/kamailio/commit/7b61c725bd867540197e695cad1f61e494d0a869 Author: Kamailio Dev Committer: Kamailio Dev Date:

[sr-dev] Jenkins build is back to stable : kamailio50-nightly-binaries » i386,jessie,slave #101

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] git:master:5fabdea4: tm: default port checking in via_matching()

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 5fabdea4d86c527a2e38caaae7a54884367d6a7c URL: https://github.com/kamailio/kamailio/commit/5fabdea4d86c527a2e38caaae7a54884367d6a7c Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:57c14e65: drouting: exported next_routing() to kemi framework

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 57c14e65d3cea754c88374b8dd1d67cb5be3f295 URL: https://github.com/kamailio/kamailio/commit/57c14e65d3cea754c88374b8dd1d67cb5be3f295 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:ce969665: drouting: updates to documentation

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: ce96966593c9f7e12595b74c2a6bf50b248e64c8 URL: https://github.com/kamailio/kamailio/commit/ce96966593c9f7e12595b74c2a6bf50b248e64c8 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:db6eae95: drouting: use core fixup helper functions

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: db6eae95e2c9a17eef8f823c30a39812429158d3 URL: https://github.com/kamailio/kamailio/commit/db6eae95e2c9a17eef8f823c30a39812429158d3 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:51837d8d: drouting: exported functions to kemi interface

2017-11-23 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 51837d8dd4bb42d4ad59da39ab9be9f5db58231e URL: https://github.com/kamailio/kamailio/commit/51837d8dd4bb42d4ad59da39ab9be9f5db58231e Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] Jenkins build is back to stable : kamailio50-nightly-binaries » amd64,jessie,slave #101

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] Jenkins build is back to stable : kamailio50-nightly-binaries » amd64,wheezy,slave #101

2017-11-23 Thread jenkins
See ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org