Re: [sr-dev] [kamailio/kamailio] Modules: db_redis for usrloc module (#1422)

2018-01-30 Thread Surendra Tiwari
@agranig @miconda -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1422#issuecomment-361842108___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:3430db51: siptrace: replaced use of copy defines with formated string functions

2018-01-30 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 3430db51cabfca102109da582b355c0fd725523a URL: https://github.com/kamailio/kamailio/commit/3430db51cabfca102109da582b355c0fd725523a Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] redis support into usrloc (#1137)

2018-01-30 Thread Surendra Tiwari
https://github.com/kamailio/kamailio/pull/1422 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1137#issuecomment-361736065___ Kamailio

Re: [sr-dev] [kamailio/kamailio] redis support into usrloc (#1137)

2018-01-30 Thread Surendra Tiwari
We can close this feature request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1137#issuecomment-361736152___ Kamailio (SER) -

[sr-dev] [kamailio/kamailio] Modules: db_redis for usrloc module (#1422)

2018-01-30 Thread Surendra Tiwari
This module provides db api interface to redis database Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not,

[sr-dev] [kamailio/kamailio] topos 5.1.1 regression: missing Contact header in in-dialog requests despite record_route() having been executed for initial request (#1421)

2018-01-30 Thread George Diamantopoulos
Hello all, It seems there has been a regression between kamailio 5.1.0 and 5.1.1 with the topos module. ### Description Kamailio acts as a proxy for asterisk instances residing in a private IP range and other entities (subscribers, peers) residing on other networks. This is a multihomed

Re: [sr-dev] [kamailio/kamailio] presence: add API endpoints to update presentity and notify watchers (#1417)

2018-01-30 Thread Charles Chance
> the last 2 parameters are option, yet you have no way of knowing that by > looking at the API function. Then there are, of course, the docs :) No worries, anyway - it was just an observation - it was by no means supposed to detract from your contribution. I'll leave it for others now to

Re: [sr-dev] [kamailio/kamailio] presence: add API endpoints to update presentity and notify watchers (#1417)

2018-01-30 Thread Emmanuel Schmidbauer
i am considering others' needs as Im preparing these API functions in order to submit a new module which will use them. The new module will be for everyone to freely use-- and if there becomes a need to use any more API functions, i expect the developer that requires them, will have to do

Re: [sr-dev] [kamailio/kamailio] presence: add API endpoints to update presentity and notify watchers (#1417)

2018-01-30 Thread Charles Chance
To me, adding a separate function for an extra two params is bloating the code. The final two params are a direct passthrough, anyway. So your function simply becomes: ``` int _api_pres_refresh_watchers(str *pres, str *event, int type, str *file_uri, str *filename) { return

Re: [sr-dev] [kamailio/kamailio] presence: add API endpoints to update presentity and notify watchers (#1417)

2018-01-30 Thread Emmanuel Schmidbauer
looking a few lines below my code, the KI interface uses a separate function if the last 2 params are required. i dont think we need to bloat the code just for completeness-- if someone desires to use that API function they can easily add it. but for my purposes, i will not be using it and

Re: [sr-dev] [kamailio/kamailio] presence: add API endpoints to update presentity and notify watchers (#1417)

2018-01-30 Thread Charles Chance
Nice...why not include the last two params now, though, for completeness? Then it's just a question of the docs - seems to be a lot of API functions missing already, so could be a good time to bring them up to date. What do others think? -- You are receiving this because you are subscribed to

Re: [sr-dev] [kamailio/kamailio] presence: add API endpoints to update presentity and notify watchers (#1417)

2018-01-30 Thread Emmanuel Schmidbauer
@charlesrchance went a step further and allowed the type to get passed into pres_refresh_watchers() another API func can be added later to allow the last 2 params if needed -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] pua: removed null pointer access from subscribe_cbparam() (#1409)

2018-01-30 Thread Christoph VALENTIN
Will you backport to 5.1 ? Should I create a 5.1 pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] presence: add API endpoints to update presentity and notify watchers (#1417)

2018-01-30 Thread Charles Chance
Yes, looks better now  The same applies to the other new function - it can be replaced by a call to existing function pres_refresh_watchers(), passing type=1 and last two parameters NULL. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [sr-dev] [kamailio/kamailio] presence: add API endpoints to update presentity and notify watchers (#1417)

2018-01-30 Thread Emmanuel Schmidbauer
@charlesrchance thanks for the comment on this, turned out it was not too difficult to call the existing function. when you get a chance, please let me know what you think about this. my tests show it's working (calling the API with some test code updates presentity table) -- You are

Re: [sr-dev] [kamailio/kamailio] json: pass str pointer to API (#1418)

2018-01-30 Thread Emmanuel Schmidbauer
Merged #1418. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1418#event-1448745166___ Kamailio (SER) - Development Mailing List

[sr-dev] git:master:00da0530: Merge pull request #1418 from kamailio/json-update-api

2018-01-30 Thread GitHub
Module: kamailio Branch: master Commit: 00da0530c7295b74b932307bad27580e14c3a987 URL: https://github.com/kamailio/kamailio/commit/00da0530c7295b74b932307bad27580e14c3a987 Author: Emmanuel Schmidbauer Committer: GitHub Date: 2018-01-30T10:09:10-05:00

[sr-dev] git:master:26b09ae0: json: pass str pointer to API

2018-01-30 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: 26b09ae0d9b36dfed9688536e7f8cd6ff22d89fd URL: https://github.com/kamailio/kamailio/commit/26b09ae0d9b36dfed9688536e7f8cd6ff22d89fd Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date:

Re: [sr-dev] [kamailio/kamailio] Transactions kept in memory, shared memory runs out and Kamailio gives up hope of life. (#1220)

2018-01-30 Thread Olle E. Johansson
This server was running on VM ware. We tested with another server and could not see the same behaviour. Still trying to find any differences while installing a third server to test with... Life. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Crash on receiving incorrect REGISTER request? (#1420)

2018-01-30 Thread kbdfck
Thanks, I'll get the core dump. It is harder to get a siptrace, as our SIP message tracking systems seem to ignore this request, maybe due to its incorrect format. I'll try to dump a traffic for some time with tcpdump and give details about SIP message. -- You are receiving this because you

Re: [sr-dev] [kamailio/kamailio] Crash on receiving incorrect REGISTER request? (#1420)

2018-01-30 Thread Victor Seva
Having the coredump will help to find the issue, please try to enable it. https://www.kamailio.org/wiki/tutorials/troubleshooting/coredumpfile Having the SIP message that produces the issue too, please provide a pcap. https://github.com/irontec/sngrep/ is a really easy tool for that -- You are