Re: [sr-dev] [kamailio/kamailio] cdp deadlock (#1739)

2018-11-26 Thread Surendra Tiwari
surendratiwari3 requested changes on this pull request. move routing.c to cdp module. its outside. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] cdp deadlock (#1739)

2018-11-26 Thread Daniel-Constantin Mierla
This doesn't look like a valid patch to be a pull request. There are complete files that seems to be relocated, including some from msrp module. Are you sure this is what fixes the issue you had? Maybe you can just paste here in a comment the diff of your changes done to cdp module... -- You

[sr-dev] [kamailio/kamailio] cdp deadlock (#1739)

2018-11-26 Thread thulasizwe-n
Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README