[sr-dev] [kamailio/kamailio] Setting notifier_processes to 1 or more seems to cause memory leak (#2733)

2021-05-10 Thread Amit Nir
Hello, We use Kamailio with KAZOO. We have set notifier_processes as follows: modparam("presence", "notifier_processes", 1) A value of 1 or greater seems to be required to avoid race conditions when multiple notify's need to be sent. We've noticed noticed what seems to be a memory leak in

Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

2021-05-10 Thread riccardv
@riccardv commented on this pull request. > -// for Reply and TCP sends from P-CSCF server port, for Reply and > UDP sends from P-CSCF client port -src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc; +// Check send socket +struct socket_info *

Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

2021-05-10 Thread alexyosifov
@alexyosifov commented on this pull request. > +// cipher_null, des, des3_ede, aes strcpy(l_enc_algo->alg_name,"cipher_null"); +if (strncasecmp(r_ealg.s,"aes-cbc",r_ealg.len) == 0) { +LM_DBG("Creating security associations: AES\n"); +

Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

2021-05-10 Thread alexyosifov
@alexyosifov commented on this pull request. > -// for Reply and TCP sends from P-CSCF server port, for Reply and > UDP sends from P-CSCF client port -src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc; +// Check send socket +struct socket_info *

Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

2021-05-10 Thread riccardv
@riccardv commented on this pull request. > +// cipher_null, des, des3_ede, aes strcpy(l_enc_algo->alg_name,"cipher_null"); +if (strncasecmp(r_ealg.s,"aes-cbc",r_ealg.len) == 0) { +LM_DBG("Creating security associations: AES\n"); +

Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

2021-05-10 Thread riccardv
@riccardv commented on this pull request. > -// for Reply and TCP sends from P-CSCF server port, for Reply and > UDP sends from P-CSCF client port -src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc; +// Check send socket +struct socket_info *

Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

2021-05-10 Thread riccardv
@riccardv commented on this pull request. > @@ -100,8 +100,15 @@ static void string_to_key(char* dst, const str > key_string) } } +static uint choose_nlmsg_seq (void) Hi @henningw , I choose the 1 micro seconds granulation due to the commit comment: "improve nlmsg_seq choice for

Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

2021-05-10 Thread alexyosifov
@alexyosifov approved this pull request. > -// for Reply and TCP sends from P-CSCF server port, for Reply and > UDP sends from P-CSCF client port -src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc; +// Check send socket +struct socket_info *

Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

2021-05-10 Thread alexyosifov
@alexyosifov approved this pull request. Added some comments > @@ -846,11 +846,20 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d, int > _cflags) // for Reply get the dest proto from the received request dst_proto = req->rcv.proto; -// for Reply and TCP sends

Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

2021-05-10 Thread Henning Westerholt
@henningw commented on this pull request. Thanks for the pull request, i have added one comment regarding the time handling. Are there module any documentation updates necessary as well? > @@ -100,8 +100,15 @@ static void string_to_key(char* dst, const str > key_string) } } +static

Re: [sr-dev] [kamailio/kamailio] is_first_hop() support for FQDN in RR header in a case of reply (#2732)

2021-05-10 Thread Igor Olhovskiy
Daniel, thanks for the clarification, really missed the option it's working only with IP addresses. Then it's definitely not a bug. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

2021-05-10 Thread Daniel-Constantin Mierla
@alexyosifov - given that you contributed recently to this module, do you have any comment on this PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] when use pcscf_unregister behind nat (#2729)

2021-05-10 Thread Daniel-Constantin Mierla
Do not give links to screenshots (nor embed screenshots) if they are to show log messages. Simply copy and paste the log messages here, because it makes it easier to search for them in the source code. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [sr-dev] [kamailio/kamailio] is_first_hop() not processing FQDN in RR header in a case of reply (#2732)

2021-05-10 Thread Daniel-Constantin Mierla
For replies, the function `is_first_hop()` is a best effort attempt to figure out if the proxy is the node next to the callee and cannot detect spirals. See the readme explaining what it does for a reply. The parsing of the IP in the record route header is needed to match the source IP and

[sr-dev] [kamailio/kamailio] is_first_hop() not processing FQDN in RR header in a case of reply (#2732)

2021-05-10 Thread Igor Olhovskiy
### Description In the case of using FQDN in `listen = ... advertise ... ` FQDN is populated in the `Record-Route` header. In this case `is_first_hop()` function is not returning true even if `FQDN == myself` in replies. Reproduction Add FQND in advertise and check `is_first_hop()`

[sr-dev] git:master:cc2a9518: modules: readme files regenerated - uac ... [skip ci]

2021-05-10 Thread Kamailio Dev
Module: kamailio Branch: master Commit: cc2a9518207e36b7b18aef5c8714f0c21da3dd95 URL: https://github.com/kamailio/kamailio/commit/cc2a9518207e36b7b18aef5c8714f0c21da3dd95 Author: Kamailio Dev Committer: Kamailio Dev Date: 2021-05-10T09:46:22+02:00 modules: readme files regenerated - uac ...

[sr-dev] git:master:ec600414: uac: docs for reg_use_domain parameter

2021-05-10 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: ec600414a3ba01e641beda6c11201b7185c879db URL: https://github.com/kamailio/kamailio/commit/ec600414a3ba01e641beda6c11201b7185c879db Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-05-10T09:39:16+02:00 uac: docs for

[sr-dev] git:master:cd2abf6e: uac: exposed reg_use_domain via modparam

2021-05-10 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: cd2abf6e278539b31ebfd355acf841faf6121e25 URL: https://github.com/kamailio/kamailio/commit/cd2abf6e278539b31ebfd355acf841faf6121e25 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-05-10T09:34:47+02:00 uac: exposed

[sr-dev] git:master:ea3ca819: uac: renamed parameter for kemi uac_reg_lookup_uri()

2021-05-10 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: ea3ca819bc07fed6b40bd6cc8f6f147dac66d9ca URL: https://github.com/kamailio/kamailio/commit/ea3ca819bc07fed6b40bd6cc8f6f147dac66d9ca Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-05-10T09:28:31+02:00 uac: renamed