[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-19 Thread Juha Heinanen via sr-dev
How about the diff below? Also, is there plan to backport ksr_tcp_msg_data_timeout, ksr_tcp_msg_read_timeout, and ksr_tcp_check_timer to 5.7, since they can help in protecting from DoS attacks that we have seen in the wild. -- Juha diff --git a/src/main.c b/src/main.c index

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
Daniel-Constantin Mierla writes: > Smaller is recommended for better accuracy. In order to make configuration simpler, how about having a dynamic default as I suggested? ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to

[sr-dev] git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
Daniel-Constantin Mierla via sr-dev writes: > core: added tcp_check_timer parameter > > - set the check interval (in seconds) for tcp connections > - default 10 Does this need to be smaller than tcp_msg_read_timeout and tcp_msg_data_timeout in order for them to have effect?

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
If so, how about defaulting to half of tcp_msg_read_timeout or tcp_msg_data_timeout whichever is smallest? ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
Daniel-Constantin Mierla writes: > > In order to make configuration simpler, how about having a dynamic default > > as I suggested? > > Default is half (hardcoded), but its own parameter gives more > flexibility for granularity -- one extra parameter is not adding much > complexity, imo, and

[sr-dev] git:5.8:1928af8f: core: set null-terminated char for modparam (backport from master)

2024-03-11 Thread Juha Heinanen via sr-dev
Module: kamailio Branch: 5.8 Commit: 1928af8f90ebf02f610c0904bc3d24a00aaedb81 URL: https://github.com/kamailio/kamailio/commit/1928af8f90ebf02f610c0904bc3d24a00aaedb81 Author: Juha Heinanen Committer: Juha Heinanen Date: 2024-03-12T07:54:50+02:00 core: set null-terminated char for modparam

[sr-dev] git:5.8:2122afae: Avoid 'qm_strnstr' defined but not used warning

2024-03-12 Thread Juha Heinanen via sr-dev
Module: kamailio Branch: 5.8 Commit: 2122afae2a6604c0bc44a43ab37ee274a15a700a URL: https://github.com/kamailio/kamailio/commit/2122afae2a6604c0bc44a43ab37ee274a15a700a Author: Juha Heinanen Committer: Juha Heinanen Date: 2024-03-12T22:16:23+02:00 Avoid 'qm_strnstr' defined but not used

[sr-dev] git:master:0054b875: Avoid 'qm_strnstr' defined but not used warning

2024-03-12 Thread Juha Heinanen via sr-dev
Module: kamailio Branch: master Commit: 0054b875045b4badfedd3e8424bf4772d6a9bc6b URL: https://github.com/kamailio/kamailio/commit/0054b875045b4badfedd3e8424bf4772d6a9bc6b Author: Juha Heinanen Committer: Juha Heinanen Date: 2024-03-12T22:18:20+02:00 Avoid 'qm_strnstr' defined but not used

[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local AC (3a34b46)

2024-05-20 Thread Juha Heinanen via sr-dev
Victor Seva via sr-dev writes: > @juha-h please use ``cherry-pick -x `` when back-porting I used `git cherry-pick . This gets too complicated for me so better that I leave the git stuff to those who know. ___ Kamailio (SER) - Development Mailing List

[sr-dev] git:5.8:3a34b468: tm: add mandatory Max-Forwards header to local AC

2024-05-20 Thread Juha Heinanen via sr-dev
Module: kamailio Branch: 5.8 Commit: 3a34b468ad93904c507bd0fc7ef592b25321807f URL: https://github.com/kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b25321807f Author: Juha Heinanen Committer: Juha Heinanen Date: 2024-05-20T19:54:45+03:00 tm: add mandatory Max-Forwards header to local