[sr-dev] [kamailio/kamailio] Fix coverity issues in carrierroute module (#1199)

2017-08-01 Thread Paul Claudiu Boriga
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README

Re: [sr-dev] CDR information is not getting logged, when dialog:end takes too long

2017-07-04 Thread Paul Claudiu Boriga
. Cheers, Daniel On 03.07.17 13:31, Paul Claudiu Boriga wrote: Hello, We are experiencing an issue when having some blocking code in the dialog:end event route. If the code takes too long to execute then CDR information is not logged. In our case we have a blocking socket trying to establish

[sr-dev] [kamailio/kamailio] ndb_redis: enhance debug info related to redis replies (#1175)

2017-07-03 Thread Paul Claudiu Boriga
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README

Re: [sr-dev] [kamailio/kamailio] ndb_redis: enhance debug info related to redis replies (#1175)

2017-07-03 Thread Paul Claudiu Boriga
claudiupb commented on this pull request. > @@ -1061,3 +1067,57 @@ int redis_count_err_and_disable(redisc_server_t *rsrv) } return 0; } + +void print_redis_reply(int log_level, redisReply *rpl,int offset) +{ + int i; + char padding[MAXIMUM_NESTED_KEYS + 1]; + +

Re: [sr-dev] [kamailio/kamailio] ndb_redis: enhance debug info related to redis replies (#1175)

2017-07-03 Thread Paul Claudiu Boriga
I have modified the commit to use is_printable, instead of defining a new function to get the log level for redis module. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Paul Claudiu Boriga
@claudiupb pushed 1 commit. f3a00aa Merge branch 'master' into redis_pipeline -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Paul Claudiu Boriga
@claudiupb pushed 1 commit. 83c68c5 fix indentation -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1079/files/f3a00aa8f78a441cc427f43ba65ae8ef8434a2be..83c68c5ededc0a5f06bb8d2fa3d778e7a6a17675

Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Paul Claudiu Boriga
I resolved the conflicts in the PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1079#issuecomment-296679014___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Paul Claudiu Boriga
@claudiupb pushed 1 commit. 3f696ae fix compilation error -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1079/files/83c68c5ededc0a5f06bb8d2fa3d778e7a6a17675..3f696aea111823bb0641ad9f255a6fb5bb15b0d3

Re: [sr-dev] [kamailio/kamailio] ndb_redis: add pipeline suppport for REDIS Module (#1079)

2017-04-24 Thread Paul Claudiu Boriga
Hello, there was a problem because _redisc_srv_list type was modified. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Fix redis pipeline (#1102)

2017-04-28 Thread Paul Claudiu Boriga
Closed #1102. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1102#event-1062047146___ Kamailio (SER) - Development Mailing List

[sr-dev] [kamailio/kamailio] Fix redis pipeline (#1102)

2017-04-28 Thread Paul Claudiu Boriga
Hello, I have found some bugs with the original commit that adds redis_pipe_cmd. If a command to the server fails, this may leave the redisContext in an invalid state, and this means that a reconnect to the server needs to be performed. The problem is that when reconnecting, a new context is

[sr-dev] [kamailio/kamailio] ndb_redis: add flush_db_on_reconnect parameter (#1125)

2017-05-09 Thread Paul Claudiu Boriga
Hello, We added a new parameter to ndb_redis module. If set to 1 a "FLUSHALL" command is issued to the REDIS server when reconnecting to a server after a failed command. This way for each failed command the database is flushed. This is useful when a connection to the REDIS server may become

[sr-dev] [kamailio/kamailio] ndb_redis: enhance access to REDIS replies (#1147)

2017-06-02 Thread Paul Claudiu Boriga
Hello, I have enhanced the way REDIS replied are accessed in the Kamailio config, to be able to access arrays that are members of other arrays. In the original code, we could access members of an array like this: $redis(reply=>value[0]). But if that member was itself an array it was

[sr-dev] [kamailio/kamailio] Redis remove redis_execute() command with no arguments (#1112)

2017-05-02 Thread Paul Claudiu Boriga
Hello, We realized that redis_execute should return a negative value in case of failure (just like redis_cmd), instead of always returning 1. This introduced a problem with the behavior when calling redis_execute without giving a server name. Since this function will loop through all the

Re: [sr-dev] [kamailio/kamailio] ndb_redis: add disable server on failure feature (#1116)

2017-05-05 Thread Paul Claudiu Boriga
@claudiupb pushed 1 commit. 395699a ndb_redis: rename variables to avoind name conflicts -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[sr-dev] [kamailio/kamailio] Add stop_recording function, and make start/stop_recording functions accept flags (#1253)

2017-09-28 Thread Paul Claudiu Boriga
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README

[sr-dev] [kamailio/kamailio] presence: test if event is dialog to avoid unnecessary xml parsing (#1453)

2018-02-23 Thread Paul Claudiu Boriga
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README

Re: [sr-dev] [kamailio/kamailio] presence: test if event is dialog to avoid unnecessary xml parsing (#1453)

2018-02-28 Thread Paul Claudiu Boriga
Looking through the code it appears that 'check_if_dialog' should be used only for DIALOG events, but maybe someone who knows the presence module better can also take a look just to be safe. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or