[sr-dev] [kamailio/kamailio] rtpengine: doc typos (#2174)

2019-12-09 Thread Dmitri Savolainen 


- [x ] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2174

-- Commit Summary --

  * rtpengine: doc typos

-- File Changes --

M src/modules/rtpengine/doc/rtpengine_admin.xml (8)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2174.patch
https://github.com/kamailio/kamailio/pull/2174.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2174
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio crash while concurrent dialplan.reload (#1874)

2019-03-01 Thread Dmitri Savolainen 
Hi, Daniel.
Now there are not Kamailio crashes. Just "ongoing reload" errors  in 5sec period

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1874#issuecomment-468635987___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] Kamailio crash while concurrent dialplan.reload (#1874)

2019-02-28 Thread Dmitri Savolainen 
 Reproduction

run this script simultaneously (from two console for example)
```
#!/usr/bin/perl
$cmd = q(curl -X GET -H "Content-Type: application/json" -d '{"jsonrpc": "2.0", 
"method": "dialplan.reload", "params":[],  "id": 1 }' http://IP:PORT/jsonrpc/);
for ($i=0; $i<1000; $i++){
`$cmd`;
}
```

 Debugging Data
```
Program terminated with signal 11, Segmentation fault.
#0  0x7ffaa39e95f7 in add_rule2hash (rule=0x7ffa9fa05248, h_index=1) at 
dp_db.c:563
/home/snen/KamailioGitMyFork/src/modules/dialplan/dp_db.c:563:12474:beg:0x7ffaa39e95f7
(gdb) bt
#0  0x7ffaa39e95f7 in add_rule2hash (rule=0x7ffa9fa05248, h_index=1) at 
dp_db.c:563
#1  0x7ffaa39e4831 in dp_load_db () at dp_db.c:305
#2  0x7ffaa39ce914 in dialplan_rpc_reload (rpc=0x7ffa9f382a80 , 
ctx=0x7ffa9f3829a0 <_jsonrpc_ctx_global>) at dialplan.c:610
#3  0x7ffa9f16398f in jsonrpc_dispatch (msg=0x7ffd427ad880, s1=0x0, s2=0x0) 
at jsonrpcs_mod.c:1294
#4  0x00461a5f in do_action (h=0x7ffd427ad7a0, a=0x7ffaa72987d8, 
msg=0x7ffd427ad880) at core/action.c:1067
#5  0x0046e23e in run_actions (h=0x7ffd427ad7a0, a=0x7ffaa72987d8, 
msg=0x7ffd427ad880) at core/action.c:1564
#6  0x004619ce in do_action (h=0x7ffd427ad7a0, a=0x7ffaa729b140, 
msg=0x7ffd427ad880) at core/action.c:1058
#7  0x0046e23e in run_actions (h=0x7ffd427ad7a0, a=0x7ffaa729b140, 
msg=0x7ffd427ad880) at core/action.c:1564
#8  0x7ffa9f38868c in xhttp_process_request (orig_msg=0x7ffaa72a6ed0, 
new_buf=0x7ffaa72c4420 "GET /jsonrpc/ HTTP/1.1\r\nVia: SIP/2.0/TCP 
192.168.10.190:48542\r\nUser-Agent: curl/7.29.0\r\nHost: 
192.168.10.190:5071\r\nAccept: */*\r\nContent-Type: 
application/json\r\nContent-Length: 71\r\n\r\n{\"jsonrpc\": \"2.0\","..., 
new_len=253) at xhttp_mod.c:296
#9  0x7ffa9f389dcf in xhttp_handler (msg=0x7ffaa72a6ed0) at xhttp_mod.c:383
#10 0x004ff30c in nonsip_msg_run_hooks (msg=0x7ffaa72a6ed0) at 
core/nonsip_hooks.c:112
#11 0x0057b373 in receive_msg (
buf=0x7ffaa02ec618 "GET /jsonrpc/ HTTP/1.1\r\nUser-Agent: 
curl/7.29.0\r\nHost: 192.168.10.190:5071\r\nAccept: */*\r\nContent-Type: 
application/json\r\nContent-Length: 71\r\n\r\n{\"jsonrpc\": \"2.0\", 
\"method\": \"dialplan.reload\", \"params\":"..., len=214, 
rcv_info=0x7ffaa02ec338) at core/receive.c:270
#12 0x00635eb5 in receive_tcp_msg (
tcpbuf=0x7ffaa02ec618 "GET /jsonrpc/ HTTP/1.1\r\nUser-Agent: 
curl/7.29.0\r\nHost: 192.168.10.190:5071\r\nAccept: */*\r\nContent-Type: 
application/json\r\nContent-Length: 71\r\n\r\n{\"jsonrpc\": \"2.0\", 
\"method\": \"dialplan.reload\", \"params\":"..., len=214, 
rcv_info=0x7ffaa02ec338, con=0x7ffaa02ec320) at core/tcp_read.c:1399
#13 0x00638372 in tcp_read_req (con=0x7ffaa02ec320, 
bytes_read=0x7ffd427ae65c, read_flags=0x7ffd427ae658) at core/tcp_read.c:1631
#14 0x0063b115 in handle_io (fm=0x7ffaa7302d78, events=1, idx=-1) at 
core/tcp_read.c:1804
#15 0x006299b6 in io_wait_loop_epoll (h=0xae9060 , t=2, repeat=0) 
at core/io_wait.h:1062
#16 0x0063d172 in tcp_receive_loop (unix_sock=16) at 
core/tcp_read.c:1974
#17 0x004dcaf9 in tcp_init_children () at core/tcp_main.c:5086
#18 0x004266c4 in main_loop () at main.c:1750
#19 0x0042d14b in main (argc=13, argv=0x7ffd427aedc8) at main.c:2737
(gdb) l
558 new_id = 0;
559 
560 /*search for the corresponding dpl_id*/
561 for(crt_idp = last_idp =rules_hash[h_index]; crt_idp!= NULL; 
562 last_idp = crt_idp, crt_idp = crt_idp->next)
563 if(crt_idp->dp_id == rule->dpid)
564 break;
565 
566 /*didn't find a dpl_id*/
567 if(!crt_idp){
(gdb) p crt_idp->dp_id
Cannot access memory at address 0x7ffa9f002429
(gdb) 

```


### Additional Information

```
kamailio 5.3.0-dev3 (x86_64/linux) d726bd
```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1874___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] tcp: correct queued length checking (#1376)

2019-01-15 Thread Dmitri Savolainen 
I use "-m64 -M32" for current master and result is the same (can't read all 
response data).  
But then I remembered the Centos7 buffers. Current (and Centos7 default) 
net.ipv4.tcp_wmem is "4096 16384 4194304", after change it via sysctl to   
'8194304 8194304 8194304' all works fine...

 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1376#issuecomment-454320015___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] dialog: fix typo in warn message (#1731)

2018-11-19 Thread Dmitri Savolainen 

- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1731

-- Commit Summary --

  * dialog: fix typo in warn message

-- File Changes --

M src/modules/dialog/dlg_db_handler.c (4)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1731.patch
https://github.com/kamailio/kamailio/pull/1731.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1731
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] drouting: fix crush for empty username in ruri (#1625)

2018-08-23 Thread Dmitri Savolainen 
 - uri like sip:@host crushed kamailio

 Pre-Submission Checklist



- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1625

-- Commit Summary --

  * drouting: fix crush for empty username in ruri

-- File Changes --

M src/modules/drouting/prefix_tree.c (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1625.patch
https://github.com/kamailio/kamailio/pull/1625.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1625
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] tcp: correct queued length checking (#1376)

2018-07-06 Thread Dmitri Savolainen 
here is minimal config for current master
[kamailio.txt](https://github.com/kamailio/kamailio/files/2170252/kamailio.txt)

here is sql script for load data
[big_htable_create.txt](https://github.com/kamailio/kamailio/files/2170253/big_htable_create.txt)

how to reproduce
```
[snen@sw5 kamailio]# cat big_htable_create.txt | mysql kamailio_dev
[snen@sw5 kamailio]# devkamctl restart
[snen@sw5 kamailio]# curl -X GET -H "Content-Type: application/json" -d 
'{"jsonrpc": "2.0", "method": "htable.dump", "params":["big_htable"],  "id": 1 
}' http://192.168.10.190:5071/jsonrpc/ > /tmp/big_htable.data 
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
 59 4181k   59 2479k  10079   9.7M318 --:--:-- --:--:-- --:--:--  9.8M
curl: (18) transfer closed with 1743335 bytes remaining to read
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1376#issuecomment-403005582___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [SR-Users] Releasing Kamailio v5.1.4

2018-06-05 Thread Dmitri Savolainen 
Hi Daniel,
can't locate this one
https://github.com/kamailio/kamailio/pull/1552


2018-05-30 19:29 GMT+03:00 Daniel-Constantin Mierla :

> Hello,
>
> I am considering to release a new minor version out of branch 5.1,
> respectively the v5.1.4, sometime next week, likely on Tuesday, June 5,
> 2018. As usual, if there is any issue not yet reported on github
> tracker, do it as soon as possible to give it a chance to be fixed.
>
> Soon I am going to do the backports of commits with fixes in master that
> apply in branch 5.1, so keep a close eye and if someone is missing, let
> me know to push it in the stable branch.
>
> Cheers,
> Daniel
>
> --
> Daniel-Constantin Mierla -- www.asipto.com
> www.twitter.com/miconda -- www.linkedin.com/in/miconda
> Kamailio World Conference -- www.kamailioworld.com
>
>
> ___
> Kamailio (SER) - Users Mailing List
> sr-us...@lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
>



-- 
Savolainen Dmitri
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:59c7bf4f: dialog: check CSeq careful with track_cseq_updates

2018-06-01 Thread Dmitri Savolainen 
Module: kamailio
Branch: master
Commit: 59c7bf4f43a8cd5dcb0555835a064d88679956c5
URL: 
https://github.com/kamailio/kamailio/commit/59c7bf4f43a8cd5dcb0555835a064d88679956c5

Author: Dmitri Savolainen 
Committer: Dmitri Savolainen 
Date: 2018-06-01T10:38:40+03:00

dialog: check CSeq careful with track_cseq_updates

to avoid null pointer access for malformed messages

---

Modified: src/modules/dialog/dlg_cseq.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/59c7bf4f43a8cd5dcb0555835a064d88679956c5.diff
Patch: 
https://github.com/kamailio/kamailio/commit/59c7bf4f43a8cd5dcb0555835a064d88679956c5.patch

---

diff --git a/src/modules/dialog/dlg_cseq.c b/src/modules/dialog/dlg_cseq.c
index 1e343c9981..b97e8f7123 100644
--- a/src/modules/dialog/dlg_cseq.c
+++ b/src/modules/dialog/dlg_cseq.c
@@ -73,7 +73,8 @@ static int dlg_cseq_prepare_msg(sip_msg_t *msg)
return 1;
}
 
-   if (parse_headers(msg, HDR_CSEQ_F, 0)==-1) {
+   if((!msg->cseq && (parse_headers(msg,HDR_CSEQ_F,0)<0 || !msg->cseq))
+   || !msg->cseq->parsed){
LM_DBG("parsing cseq header failed\n");
return 2;
}


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] dialog: check CSeq careful with track_cseq_updates (#1552)

2018-06-01 Thread Dmitri Savolainen 
to avoid null pointer access for malformed messages
 Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description
after adding modparam("dialog", "track_cseq_updates", 1) and getting some 
malformed SIP  kamailio crushed


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1552

-- Commit Summary --

  * dialog: check CSeq careful with track_cseq_updates

-- File Changes --

M src/modules/dialog/dlg_cseq.c (3)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1552.patch
https://github.com/kamailio/kamailio/pull/1552.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1552
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:ad427fc1: dialog: typo fix for DLG_IFLAG_DMQ_SYNC flag value

2018-04-16 Thread Dmitri Savolainen 
Module: kamailio
Branch: master
Commit: ad427fc19c56110f66df86b7b49e23c00313610a
URL: 
https://github.com/kamailio/kamailio/commit/ad427fc19c56110f66df86b7b49e23c00313610a

Author: Dmitri Savolainen <savolai...@erinaco.ru>
Committer: Dmitri Savolainen <savolai...@erinaco.ru>
Date: 2018-04-16T19:43:50+03:00

dialog: typo fix for DLG_IFLAG_DMQ_SYNC flag value

---

Modified: src/modules/dialog/dlg_hash.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/ad427fc19c56110f66df86b7b49e23c00313610a.diff
Patch: 
https://github.com/kamailio/kamailio/commit/ad427fc19c56110f66df86b7b49e23c00313610a.patch

---

diff --git a/src/modules/dialog/dlg_hash.h b/src/modules/dialog/dlg_hash.h
index 91eb129d67..85fdc6cb83 100644
--- a/src/modules/dialog/dlg_hash.h
+++ b/src/modules/dialog/dlg_hash.h
@@ -78,7 +78,7 @@
 #define DLG_IFLAG_TIMER_NORESET (1<<3) /*!< don't reset dialog timers on 
in-dialog messages reception */
 #define DLG_IFLAG_CSEQ_DIFF (1<<4) /*!< CSeq changed in dialog */
 #define DLG_IFLAG_PRACK (1<<5) /*!< PRACK was routed during 
initial state */
-#define DLG_IFLAG_DMQ_SYNC  (1<<5) /*!< sync this dialog via dmq DMQ*/
+#define DLG_IFLAG_DMQ_SYNC  (1<<6) /*!< sync this dialog via dmq DMQ*/
 
 #define DLG_CALLER_LEG 0 /*!< attribute that belongs to a caller leg */
 #define DLG_CALLEE_LEG 1 /*!< attribute that belongs to a callee leg */


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:a821ff61: dialog: restore keep-alive after restart

2018-04-16 Thread Dmitri Savolainen 
Module: kamailio
Branch: master
Commit: a821ff61029a4e8a9f220d60f95bd7b5a545f9b4
URL: 
https://github.com/kamailio/kamailio/commit/a821ff61029a4e8a9f220d60f95bd7b5a545f9b4

Author: Dmitri Savolainen <savolai...@erinaco.ru>
Committer: Dmitri Savolainen <savolai...@erinaco.ru>
Date: 2018-04-16T19:32:05+03:00

dialog: restore keep-alive after restart

---

Modified: src/modules/dialog/dlg_db_handler.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/a821ff61029a4e8a9f220d60f95bd7b5a545f9b4.diff
Patch: 
https://github.com/kamailio/kamailio/commit/a821ff61029a4e8a9f220d60f95bd7b5a545f9b4.patch

---

diff --git a/src/modules/dialog/dlg_db_handler.c 
b/src/modules/dialog/dlg_db_handler.c
index 2a3e4301ad..eb1d97d7b7 100644
--- a/src/modules/dialog/dlg_db_handler.c
+++ b/src/modules/dialog/dlg_db_handler.c
@@ -464,6 +464,8 @@ int load_dialog_info_from_db(int dlg_hash_size, int 
fetch_num_rows,
srjson_DestroyDoc();
}
dlg->iflags = (unsigned int)VAL_INT(values+22);
+   if (dlg->state==DLG_STATE_CONFIRMED)
+   dlg_ka_add(dlg);
 
if (!dlg->bind_addr[DLG_CALLER_LEG] || 
!dlg->bind_addr[DLG_CALLEE_LEG]) {
/* non-local socket, probably not our dialog */


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] dialog: typo fix for DLG_IFLAG_DMQ_SYNC flag value (#1502)

2018-04-16 Thread Dmitri Savolainen 


 Pre-Submission Checklist



- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description
typo fix for DLG_IFLAG_DMQ_SYNC flag value

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1502

-- Commit Summary --

  * dialog: typo fix for DLG_IFLAG_DMQ_SYNC flag value

-- File Changes --

M src/modules/dialog/dlg_hash.h (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1502.patch
https://github.com/kamailio/kamailio/pull/1502.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1502
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] dialog: restore keep-alive after restart (#1501)

2018-04-16 Thread Dmitri Savolainen 


 Pre-Submission Checklist



- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description
I've noticed kamailio stop send OPTIONS ("ka-dst"/"ka-src" params) after 
restart. This should fix

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1501

-- Commit Summary --

  * dialog: restore keep-alive after restart

-- File Changes --

M src/modules/dialog/dlg_db_handler.c (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1501.patch
https://github.com/kamailio/kamailio/pull/1501.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1501
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] registrar: function "registered(...)" different workers integrity (#1267)

2018-02-16 Thread Dmitri Savolainen 
with this path  it seems ok
```
diff --git a/src/modules/registrar/lookup.c b/src/modules/registrar/lookup.c
index b18fe99..84c0f40 100644
--- a/src/modules/registrar/lookup.c
+++ b/src/modules/registrar/lookup.c
@@ -759,6 +759,7 @@ int registered4(struct sip_msg* _m, udomain_t* _d, str* 
_uri, int match_flag,
}
}
 
+   get_act_time();
for (ptr = r->contacts; ptr; ptr = ptr->next) {
if(!VALID_CONTACT(ptr, act_time)) continue;
if (match_callid.s && /* optionally enforce tighter 
matching w/ Call-ID */
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1267#issuecomment-366275132___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] tcp: correct queued length checking (#1376)

2018-01-31 Thread Dmitri Savolainen 
i use default TCP params and change  _tcp_conn_wq_max_ and _tcp_wq_max_ can 
help of course according to if statement.

_q->queued_ is zero in my fail test,  so it is strange for me.
in docs
>tcp_conn_wq_max
> Maximum bytes queued for write allowed per connection. Attempting to queue 
> more bytes would result in an error and in the connection being closed (**too 
> slow**). If tcp_write_buf is not enabled, it has no effect.

So i try to add  the last 700k and it is failed always. I undestand this 
paramenter as not yet sent data (connection too slow), so if 
_q->queued

Re: [sr-dev] [kamailio/kamailio] tcp: correct queued length checking (#1376)

2018-01-24 Thread Dmitri Savolainen 
It woks just according to: "i can dump the same big htable via jsonrpcs/tcp  
with this patch, and can't without it". 
In my mind we have to check already "queued" length, not  "queued+size", but  
as mensioned before my understanding of these parameters is superficial

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1376#issuecomment-360160489___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:e66f109c: pv: correct sbranch params appending

2017-12-20 Thread Dmitri Savolainen 
Module: kamailio
Branch: master
Commit: e66f109c0d2cf657387ee1e0745ff2d55eebcaaa
URL: 
https://github.com/kamailio/kamailio/commit/e66f109c0d2cf657387ee1e0745ff2d55eebcaaa

Author: Dmitri Savolainen <savolai...@erinaco.ru>
Committer: Dmitri Savolainen <savolai...@erinaco.ru>
Date: 2017-12-20T13:07:35+03:00

pv: correct sbranch params appending

- some params (like dest uri) were not appended to branch
  due to a copy-paste typo

---

Modified: src/modules/pv/pv_branch.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/e66f109c0d2cf657387ee1e0745ff2d55eebcaaa.diff
Patch: 
https://github.com/kamailio/kamailio/commit/e66f109c0d2cf657387ee1e0745ff2d55eebcaaa.patch

---

diff --git a/src/modules/pv/pv_branch.c b/src/modules/pv/pv_branch.c
index 7e6911c8d2..b0668c07f8 100644
--- a/src/modules/pv/pv_branch.c
+++ b/src/modules/pv/pv_branch.c
@@ -730,19 +730,19 @@ int sbranch_append(sip_msg_t *msg)
uri.s = br->uri;
uri.len = br->len;
 
-   if(br->dst_uri_len==0) {
+   if(br->dst_uri_len) {
duri.s = br->dst_uri;
duri.len = br->dst_uri_len;
}
-   if(br->path_len==0) {
+   if(br->path_len) {
path.s = br->path;
path.len = br->path_len;
}
-   if(br->ruid_len==0) {
+   if(br->ruid_len) {
ruid.s = br->ruid;
ruid.len = br->ruid_len;
}
-   if(br->location_ua_len==0) {
+   if(br->location_ua_len) {
location_ua.s = br->location_ua;
location_ua.len = br->location_ua_len;
}


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] pv: correct sbranch params appending (#1377)

2017-12-20 Thread Dmitri Savolainen 
- some params (like dest uri) were not appended to branch
  due to a copy-paste typo





 Pre-Submission Checklist



- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, 
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ x] PR should be backported to stable branches
- [ x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1377

-- Commit Summary --

  * pv: correct sbranch params appending

-- File Changes --

M src/modules/pv/pv_branch.c (8)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1377.patch
https://github.com/kamailio/kamailio/pull/1377.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1377
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] tcp: correct queued length checking (#1376)

2017-12-19 Thread Dmitri Savolainen 




 Pre-Submission Checklist



- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, 
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description
I can’t get big responses via jsonrpcs with default tcp params. According to 
log response size ~3200k,  kamailio send ~2500k of data and can’t add 700k to 
queue after. This patch should fix, if my understanding of “queued” value is 
right.


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1376

-- Commit Summary --

  * tcp: correct queued length checking

-- File Changes --

M src/core/tcp_main.c (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1376.patch
https://github.com/kamailio/kamailio/pull/1376.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1376
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] registrar: function "registered(...)" different workers integrity (#1267)

2017-10-13 Thread Dmitri Savolainen 
It seems not startup issue. I add [usrloc:contact-expired] hook
11:58:31 kamailio started, then i register/unregister my endpoint and check it 
status for all workers. After one of unregister integrity was missed and 
continued up to [usrloc:contact-expired] fire ("usrloc", "timer_interval")
```
Oct 13 12:31:24 kamailio[32018] registered
Oct 13 12:31:24 kamailio[32016] registered
Oct 13 12:31:24 kamailio[32022] NOT registered
Oct 13 12:31:24 kamailio[32025] NOT registered
Oct 13 12:31:26 kamailio[32023] registered
Oct 13 12:31:26 kamailio[32022] NOT registered
Oct 13 12:31:26 kamailio[32016] registered
Oct 13 12:31:26 kamailio[32020] NOT registered
Oct 13 12:31:26 kamailio[32015] registered
Oct 13 12:31:26 kamailio[32025] NOT registered
Oct 13 12:31:26 kamailio[32018] registered
Oct 13 12:31:26 kamailio[32028] registered
Oct 13 12:31:28 kamailio[32015] registered
Oct 13 12:31:28 kamailio[32018] registered
Oct 13 12:31:28 kamailio[32022] NOT registered
Oct 13 12:31:28 kamailio[32028] registered
Oct 13 12:31:28 kamailio[32025] NOT registered
Oct 13 12:31:28 kamailio[32020] NOT registered
Oct 13 12:31:28 kamailio[32023] registered
Oct 13 12:31:28 kamailio[32016] registered
Oct 13 12:31:30 kamailio[32023] registered
Oct 13 12:31:30 kamailio[32025] NOT registered
Oct 13 12:31:30 kamailio[32018] registered
Oct 13 12:31:30 kamailio[32015] registered
Oct 13 12:31:30 kamailio[32020] NOT registered
Oct 13 12:31:30 kamailio[32022] NOT registered
Oct 13 12:31:30 kamailio[32028] registered
Oct 13 12:31:30 kamailio[32016] registered
Oct 13 12:31:32 kamailio[32022] NOT registered
Oct 13 12:31:32 kamailio[32020] NOT registered
Oct 13 12:31:32 kamailio[32016] registered
Oct 13 12:31:32 kamailio[32025] NOT registered
Oct 13 12:31:32 kamailio[32018] registered
Oct 13 12:31:32 kamailio[32015] registered
Oct 13 12:31:32 kamailio[32028] registered
Oct 13 12:31:32 kamailio[32023] registered
Oct 13 12:31:33 kamailio[32030] INFO:

[sr-dev] [kamailio/kamailio] registrar: function "registered(...)" different workers integrity (#1267)

2017-10-09 Thread Dmitri Savolainen 
### Description
Sometimes "registered" function return different result for different SIP 
worker process.
It seems reproduced for a some time after restart. I have locate it on 
4.4.6version and reproduce for master branch too.  I tried Register/Unregister 
sip account while testing (via SIP)

### Troubleshooting

 Reproduction
```
children=8

# registrar params
modparam("registrar", "append_branches", 0)
modparam("registrar", "use_path", 1)
modparam("registrar", "path_mode", 0) 
modparam("registrar", "max_expires", 1800)
modparam("registrar", "min_expires", 60)

# usrloc params
modparam("usrloc", "db_mode", 2)
modparam("usrloc", "timer_interval", 20) #default 60
modparam("usrloc", "db_check_update", 1)
modparam("usrloc", "use_domain", 1)
modparam("usrloc", "nat_bflag", FLB_NATB) 
modparam("usrloc", "db_ops_ruid", 1)

request_route{
route(REG);
route(TESTREG);
exit;
}

route[SEND_TESTREG]
{
$uac_req(method)="PUBLISH";
$uac_req(ruri) = $tu;
$uac_req(furi) = $tu;
$uac_req(turi) = $tu;
$uac_req(callid) = $ci; 
$uac_req(ouri) = "MYADDRPORT";
uac_req_send();
}

route[PRINT_REGISTERED]
{
if (registered("location", "$tu")){
xlog("L_INFO", "$rm $ci registered");
}
else{
xlog("L_INFO", "$rm $ci NOT registered");
}
}

route[REG] {
if (!is_method("REGISTER")) return;
xlog("L_INFO", "-");
route(PRINT_REGISTERED);
if ( !save("location") ) {
sl_reply_error();
exit;
}
route(PRINT_REGISTERED);
# children=8
route(SEND_TESTREG);
route(SEND_TESTREG);
route(SEND_TESTREG);
route(SEND_TESTREG);
route(SEND_TESTREG);
route(SEND_TESTREG);
route(SEND_TESTREG);
route(SEND_TESTREG);
exit;
}

route[TESTREG]{
if (!is_method("PUBLISH")) return;
usleep("500");
route(PRINT_REGISTERED);
sl_send_reply("200", "OK");
exit;
}
```

 Log Messages
Oct  9 20:13:38 kamailio[19514] INFO:

[sr-dev] [kamailio/kamailio] to tags generation (#1164)

2017-06-23 Thread Dmitri Savolainen 
### Description
Not shure is this relevant issue.
according to rfc3261:

> When a tag is generated by a UA for insertion into a request or
>response, it MUST be globally unique and cryptographically random
>with at least 32 bits of randomness.

Kamailio has 16 instead and distribution is not good.
I look at tags for 419485 sip flows (different callid) and table below (top 
keys ordered by count): 
tag suffix; count for different flows with this suffix
ed54 6258
d118 5988
56ce 5923
a7a5 5220
de51 2150
82d8 1143
cf52 890
af92 740
7b5f 534
85f7 307
e553 163
7f7e 138
1d55 130
1afe 62
5a69 43
7caa 18
8474 18
9db2 18
11d3 18
f9ff 18
5420 17
dae6 17
908d 17
ede4 17
09ee 17
96be 17
25dc 17
af6d 16
2506 16
3da0 16
f161 16
1c29 16

 SIP Traffic
To: ;tag=555d2c3eafafcba8ac92b676e91bb6ed.58eb


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1164___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] Planning Kamailio v4.4.6

2017-06-14 Thread Dmitri Savolainen 
Thanks, Daniel!

Can't locate this memory leak fix
https://github.com/kamailio/kamailio/issues/1001

2017-06-14 9:32 GMT+03:00 Daniel-Constantin Mierla :

> Hello,
>
> I backported a consistent set of patches to branch 4.4 and plan to
> release v4.4.6 in the next days. Should anyone be interested in that
> branch, it would be good to review and see if any relevant fix from
> newer branches is missing in order to assert the feasibility of
> backporting. If time allows, 4.4.6 can be out as soon as tomorrow
> afternoon, if not, sometime during following days.
>
> Cheers,
> Daniel
>
>
> --
> Daniel-Constantin Mierla
> www.twitter.com/miconda -- www.linkedin.com/in/miconda
> Kamailio Advanced Training - www.asipto.com
> Kamailio World Conference - www.kamailioworld.com
>
>
> ___
> Kamailio (SER) - Development Mailing List
> sr-dev@lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>



-- 
Savolainen Dmitri
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:d6490589: pua_dialoginfo: remove DLGCB_MI_CONTEXT

2017-05-22 Thread Dmitri Savolainen 
Module: kamailio
Branch: master
Commit: d64905895f68932b9d8ce39ab17a84022630343b
URL: 
https://github.com/kamailio/kamailio/commit/d64905895f68932b9d8ce39ab17a84022630343b

Author: Dmitri Savolainen <savolai...@erinaco.ru>
Committer: Dmitri Savolainen <savolai...@erinaco.ru>
Date: 2017-05-22T17:48:42+03:00

pua_dialoginfo: remove DLGCB_MI_CONTEXT

- DLGCB_MI_CONTEXT was deleted in dialog module

---

Modified: src/modules/pua_dialoginfo/pua_dialoginfo.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/d64905895f68932b9d8ce39ab17a84022630343b.diff
Patch: 
https://github.com/kamailio/kamailio/commit/d64905895f68932b9d8ce39ab17a84022630343b.patch

---

diff --git a/src/modules/pua_dialoginfo/pua_dialoginfo.c 
b/src/modules/pua_dialoginfo/pua_dialoginfo.c
index ed1f107f28..6141e3bdec 100644
--- a/src/modules/pua_dialoginfo/pua_dialoginfo.c
+++ b/src/modules/pua_dialoginfo/pua_dialoginfo.c
@@ -238,10 +238,6 @@ __dialog_cbtest(struct dlg_cell *dlg, int type, struct 
dlg_cb_params *_params)
LM_ERR("dialog callback type 'DLGCB_RESPONSE_WITHIN' 
received, from=%.*s\n",
dlg->from_uri.len, dlg->from_uri.s);
break;
-   case DLGCB_MI_CONTEXT:
-   LM_ERR("dialog callback type 'DLGCB_MI_CONTEXT' 
received, from=%.*s\n",
-   dlg->from_uri.len, dlg->from_uri.s);
-   break;
case DLGCB_DESTROY:
LM_ERR("dialog callback type 'DLGCB_DESTROY' received, 
from=%.*s\n",
dlg->from_uri.len, dlg->from_uri.s);
@@ -605,7 +601,7 @@ struct dlginfo_cell* get_dialog_data(struct dlg_cell *dlg, 
int type)
DLGCB_FAILED| DLGCB_CONFIRMED_NA | 
DLGCB_CONFIRMED
| DLGCB_REQ_WITHIN | DLGCB_TERMINATED | 
DLGCB_EXPIRED
| DLGCB_EARLY | DLGCB_RESPONSE_FWDED | 
DLGCB_RESPONSE_WITHIN
-   | DLGCB_MI_CONTEXT | DLGCB_DESTROY,
+   | DLGCB_DESTROY,
__dialog_cbtest, NULL, NULL) != 0) {
LM_ERR("cannot register callback for all dialog types\n");
free_dlginfo_cell(dlginfo);


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:3a6b28d2: pua_dialoginfo: docs typo fix

2017-05-22 Thread Dmitri Savolainen 
Module: kamailio
Branch: master
Commit: 3a6b28d2cbab37091485ed7802fc5d2ecbd4803a
URL: 
https://github.com/kamailio/kamailio/commit/3a6b28d2cbab37091485ed7802fc5d2ecbd4803a

Author: Dmitri Savolainen <savolai...@erinaco.ru>
Committer: Dmitri Savolainen <savolai...@erinaco.ru>
Date: 2017-05-22T18:53:38+03:00

pua_dialoginfo: docs typo fix

---

Modified: src/modules/pua_dialoginfo/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/3a6b28d2cbab37091485ed7802fc5d2ecbd4803a.diff
Patch: 
https://github.com/kamailio/kamailio/commit/3a6b28d2cbab37091485ed7802fc5d2ecbd4803a.patch

---

diff --git a/src/modules/pua_dialoginfo/README 
b/src/modules/pua_dialoginfo/README
index 4544ed8dde..edb4c29f00 100644
--- a/src/modules/pua_dialoginfo/README
+++ b/src/modules/pua_dialoginfo/README
@@ -54,7 +54,7 @@ Phil Lavin
   5.10. pubruri_caller_avp (int)
   5.11. pubruri_callee_avp (int)
   5.12. pubruri_caller_dlg_var (str)
-  5.13. pubruri_callee_dlg_var (int)
+  5.13. pubruri_callee_dlg_var (str)
   5.14. callee_trying (int)
 
 6. Functions
@@ -102,7 +102,7 @@ Chapter 1. Admin Guide
 5.10. pubruri_caller_avp (int)
 5.11. pubruri_callee_avp (int)
 5.12. pubruri_caller_dlg_var (str)
-5.13. pubruri_callee_dlg_var (int)
+5.13. pubruri_callee_dlg_var (str)
 5.14. callee_trying (int)
 
6. Functions
@@ -165,7 +165,9 @@ Chapter 1. Admin Guide
example:
 
 
+ version="1"
+ state="full"
+ entity="sip:al...@example.com">
 https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] pua dialoginfo (#1135)

2017-05-22 Thread Dmitri Savolainen 
some docs fix & compile error with PUA_DIALOGINFO_DEBUG enabled
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1135

-- Commit Summary --

  * pua_dialoginfo: remove DLGCB_MI_CONTEXT
  * pua_dialoginfo: docs typo fix

-- File Changes --

M src/modules/pua_dialoginfo/README (12)
M src/modules/pua_dialoginfo/pua_dialoginfo.c (6)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1135.patch
https://github.com/kamailio/kamailio/pull/1135.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1135
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev