Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)
Just tested both with TCP and UDP. Its working fine. Thank you very much! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-365872768___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)
Oups -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-365868838___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)
Daniel, in fact it is not working. See previous comment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-365862634___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)
If I inspect the packet I see a single route without transport information. And yet the correct source port is selected ! Can you tell us how kamailio guess the source port to use in that case. These traces demonstrate that in the loose_route() function, send_socket is NOT forced. And yet this is working. Can you tell me HOW kamailio knows that -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-365665157___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)
Ok, I tested and it is working but I would kindly need an explanation
1- the setup :
- kamailio 5.1 with three listen (on port 5060, 5063, 5066)
- 2 UAs using UDP on port 5063
- added a log in the script
```
route[WITHINDLG] {
if (!has_totag()) return;
# sequential request withing a dialog should
# take the path determined by record-routing
if (loose_route()) {
route(DLGURI);
if (is_method("BYE")) {
setflag(FLT_ACC); # do accounting ...
setflag(FLT_ACCFAILED); # ... even if the transaction
fails
} else if ( is_method("ACK") ) {
# ACK is forwarded statelessly
xlog("forced socket $fs\n");
route(NATMANAGE);
} else if ( is_method("NOTIFY") ) {
# Add Record-Route for in-dialog NOTIFY as per RFC 6665.
record_route();
}
route(RELAY);
```
2- parameter for rr module
```
modparam("rr", "enable_full_lr", 0)
modparam("rr", "enable_double_rr", 1)
```
3- result - on K master, ACK gets forwarded **properly** using source port
5036 with the following traces
```
Feb 14 17:13:50 mcudev3 /usr/local/sbin/kamailio[21394]: {1 5765 ACK
ffb8d7ca-efae-79ef-6035-dd1043352c55} DEBUG: rr [loose.c:812]: after_loose():
Topmost route URI: 'sip:172.21.100.108:5063;lr' is me
Feb 14 17:13:50 mcudev3 /usr/local/sbin/kamailio[21394]: {1 5765 ACK
ffb8d7ca-efae-79ef-6035-dd1043352c55} DEBUG:
[core/parser/msg_parser.c:89]: get_hdr_field(): found end of header
Feb 14 17:13:50 mcudev3 /usr/local/sbin/kamailio[21394]: {1 5765 ACK
ffb8d7ca-efae-79ef-6035-dd1043352c55} DEBUG: rr [loose.c:181]:
find_next_route(): No next Route HF found
Feb 14 17:13:50 mcudev3 /usr/local/sbin/kamailio[21394]: {1 5765 ACK
ffb8d7ca-efae-79ef-6035-dd1043352c55} DEBUG: rr [loose.c:842]: after_loose():
No next URI found
Feb 14 17:13:50 mcudev3 /usr/local/sbin/kamailio[21394]: {1 5765 ACK
ffb8d7ca-efae-79ef-6035-dd1043352c55} ERROR:
Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)
No I did not test it. I will. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-364925128___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)
Hi Daniel, I reviewed the code and unfortunately, it does not cover the case when - enable_double_rr=1 - both UA are using the same IP and the same port and there is only one route inserted by record_route() To handle this case, see the patch I suggest below. Alternatively, we could set enable_double_rr=2 I guess. What is your opinion ? [loose.diff.txt](https://github.com/kamailio/kamailio/files/1716237/loose.diff.txt) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-364906786___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] rtpengine: rtpengine_offer is stripping all INVITE multipart bodies except application/sdp (#1434)
That is an issue as multipart bodies can be used when geolocation is transmitted by value. Typically, a geolocalized INVITE packet body would contain an SDP part and a second part with an LO-PIDF payload. https://www.rfc-editor.org/rfc/rfc6442.txt section 5.1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1434#issuecomment-364196709___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
