[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-26 Thread Joey Golan
Hi @miconda, I was wondering, if I wish to back-port this to 5.7.1, what is the right way of doing so? Thanks, Joey. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3473#issuecomment-1607279322 You are receiving this because you are subscribed

[sr-dev] Re: [kamailio/kamailio] jwt: propagate decoded jwt payload after successful jwt_verify() (PR #3492)

2023-06-22 Thread Joey Golan
Hi @miconda, You are right. I wasn't thinking about that option. Sorry about that :-) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3492#issuecomment-1602566526 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] jwt: propagate decoded jwt payload after successful jwt_verify() (PR #3492)

2023-06-22 Thread Joey Golan
Closed #3492. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3492#event-9606148379 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] [kamailio/kamailio] jwt: propagate decoded jwt payload after successful jwt_verify() (PR #3492)

2023-06-22 Thread Joey Golan
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-20 Thread Joey Golan
Hi @miconda, Is there anything else I should do or join wait for someone to merge the PR? Thanks -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3473#issuecomment-1600089504 You are receiving this because you are subscribed to this thread.

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-14 Thread Joey Golan
@joeygo commented on this pull request. > + } + + if(rank == PROC_MAIN) { + if(rtpengine_dtmf_event_sock.len > 0) { + LM_DBG("Register RTPENGINE DTMF WORKER %d\n", mypid); + /* fork worker process */ +

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-13 Thread Joey Golan
@joeygo pushed 1 commit. 9d563b820b82bdda49e8c4ad5ef0e82e09d8d535 rtpengine: release json document object -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3473/files/3df99a84a33d1dcdb064f96e6edd36b75f9e7166..9d563b820b82bdda49e8c4ad5ef0e82e09d8d535 You are receiving this

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-13 Thread Joey Golan
@joeygo commented on this pull request. > + + fmsg = faked_msg_next(); + rtb = get_route_type(); + set_route_type(REQUEST_ROUTE); + init_run_actions_ctx(); + run_top_route(event_rt.rlist[dtmf_event_rt], fmsg, ); + set_route_type(rtb); + if(ctx.run_flags

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan
@joeygo pushed 1 commit. 3df99a84a33d1dcdb064f96e6edd36b75f9e7166 rtpengine: fix build failed on specific distribution -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3473/files/2ddab46263db2ae94038e672c79faaa769d9c306..3df99a84a33d1dcdb064f96e6edd36b75f9e7166 You are

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan
@joeygo pushed 1 commit. 2ddab46263db2ae94038e672c79faaa769d9c306 rtpengine: Fix rfuchs's PR comments -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3473/files/7c2d64ffa57bb8ebe6ce46311ca98a100b09a997..2ddab46263db2ae94038e672c79faaa769d9c306 You are receiving this because you

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan
@joeygo commented on this pull request. > + } + + if(rank == PROC_MAIN) { + if(rtpengine_dtmf_event_sock.len > 0) { + LM_DBG("Register RTPENGINE DTMF WORKER %d\n", mypid); + /* fork worker process */ +

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan
@joeygo commented on this pull request. > @@ -261,7 +262,7 @@ static int add_rtpp_node_info( void *ptrs, struct rtpp_node *crt_rtpp, struct rtpp_set *rtpp_list); static int rtpp_test_ping(struct rtpp_node *node); -static void rtpengine_dtmf_events_loop(int rank); +static

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan
@joeygo commented on this pull request. > + +end: + close(rtpengine_dtmf_event_fd); +} + +static int rtpengine_raise_dtmf_event(char *buffer, int len) { + srjson_doc_t jdoc; + srjson_t *it = NULL; + struct sip_msg *fmsg = NULL; + struct run_act_ctx ctx; +

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan
@joeygo commented on this pull request. > + } + + if (dtmf_event_rt == -1) { + LM_NOTICE("nothing to do - nobody is listening!\n"); + goto end; + } + + p = shm_malloc(ret + 1); + if

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan
@joeygo commented on this pull request. > + s_port.len = rtpengine_dtmf_event_sock.s + > rtpengine_dtmf_event_sock.len - s_port.s; + + if (s_port.len <= 0 || str2int(_port, ) < 0 || port > 65535) { + LM_ERR("failed to initialize dtmf event listener because port is

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan
@joeygo pushed 1 commit. 7c2d64ffa57bb8ebe6ce46311ca98a100b09a997 Register a new worker process for dtmf event listener -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3473/files/87253c36f1b42f5d707ac4d2aeeda2f842f4d46d..7c2d64ffa57bb8ebe6ce46311ca98a100b09a997 You are

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan
@joeygo commented on this pull request. > -static int fixup_set_id(void **param, int param_no) +static void rtpengine_dtmf_events_loop(int rank) You are right. I removed it. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan
@joeygo commented on this pull request. > @@ -2147,6 +2401,9 @@ static int child_init(int rank) /* probe rtpengines only in first worker */ if(build_rtpp_socks(0, 1)) return -1; + + if

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-09 Thread Joey Golan
Hi, Anything else is needed from my end or is it just waiting for spare time? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3473#issuecomment-1584543228 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3471)

2023-05-31 Thread Joey Golan
Done. Thank you, Joey. On 31 May 2023 at 9:03 +0300, Daniel-Constantin Mierla ***@***.***>, wrote: > You have to pull and rebase before making the pull request (or force push > again) because the PR has commits not related to the change of rtpengine. > — > Reply to this email directly, view it

[sr-dev] [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-05-31 Thread Joey Golan
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3471)

2023-05-31 Thread Joey Golan
Closed #3471. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3471#event-9390927195 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3471)

2023-05-31 Thread Joey Golan
@joeygo pushed 0 commits. -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3471/files/df3cce755c5538c9d60775716902720bcbabe2a7..bc544daea2ee4bb568cf0314f6d32b8aa0c81ecc You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3471)

2023-05-29 Thread Joey Golan
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3471 -- Commit Summary -- * imc: add support to modify member role * imc: call handle_modify * imc: db_mode support * Merge branch kamailio:master into master * imc: destroy db

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3470)

2023-05-29 Thread Joey Golan
Closed #3470. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3470#event-9366701378 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3470)

2023-05-29 Thread Joey Golan
@joeygo pushed 1 commit. df3cce755c5538c9d60775716902720bcbabe2a7 Pass 0 to pvar setf in case of an event raised -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3470/files/ecfec78bf38e17f96f6b01ec79bc89d7a63b797d..df3cce755c5538c9d60775716902720bcbabe2a7 You are receiving this

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3470)

2023-05-29 Thread Joey Golan
@joeygo pushed 1 commit. ecfec78bf38e17f96f6b01ec79bc89d7a63b797d Initialize uninitialized local variable -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3470/files/5bfc028bb1149eadd9b687ce400423ddff690c64..ecfec78bf38e17f96f6b01ec79bc89d7a63b797d You are receiving this

[sr-dev] [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3470)

2023-05-28 Thread Joey Golan
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] [kamailio/kamailio] imc module enhancements (PR #3291)

2022-12-02 Thread Joey Golan
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-09 Thread Joey Golan
Hi @grumvalski, I have tested the branch with your changes and it looks like it fixes the problem. Very well.. Thank you! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-09 Thread Joey Golan
Closed #2466. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2466#event-3744983161___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-08 Thread Joey Golan
Yes, tls module loaded first. I created a minimal config file that reproduces the problem. The crash is because of this line: modparam("http_async_client", "workers", 4) comment out this line makes the crash disappear. #!KAMAILIO ### Global Parameters # /* LOG Levels: 3=DBG, 2=INFO,

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-06 Thread Joey Golan
After some investigation I found out that the cause for the problem is modparam("http_async_client", "workers", **4**). Starting kamailio with modparam("http_async_client", "workers", **1**) works fine. I also tested it on v5.4.1 before @linuxmaniac reverts and it works fine with

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-03 Thread Joey Golan
Still crashes for me. I installed Kamailio v5.4.2 nightly build kamailio-dbg/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 [installed] kamailio-extra-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 [installed] kamailio-json-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64

[sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-02 Thread Joey Golan
### Description After upgrading Debian from stretch to buster, kamailio service keeps crashing on service stat. Same kamailio configuration file worked fine on Debian stretch. If I disable TLS the service starts successfully. ### Troubleshooting Looks like a TLS issue Reproduction

Re: [sr-dev] Kamailio jwt module or Lua script

2019-10-13 Thread Joey Golan
. From: Daniel-Constantin Mierla Sent: Monday, October 7, 2019 4:02 PM To: Joey Golan; Kamailio (SER) - Development Mailing List Subject: Re: [sr-dev] Kamailio jwt module or Lua script On 07.10.19 14:36, Joey Golan wrote: I’ve implemented the token verification in Lua script and I’m using

[sr-dev] Kamailio jwt module or Lua script

2019-10-05 Thread Joey Golan
Hi all, I would like to authenticate subscribers using JWT tokens and I wonder which approach is better: 1. Writhing a dedicated kamailio module. 2. Writing a Lua script. What would work better performance wise? Thanks, Joey. ___ Kamailio (SER) -