>From my point of view this PR can be squashed and merged.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3612#issuecomment-1777676433
You are receiving this because you are subscribed to this thread.
Message ID:
In the cdp_tls.c I would put the function before the first one that uses it,
possibly SSL *init_ssl_conn(int client_fd, SSL_CTX *ctx). In the cdp_tls.h,
maybe just under tls_parse_method(). Much appreciated.
--
Reply to this email directly or view it on GitHub:
Hello,
Thanks for the changes.
I did manage to get some extra information with this new function so the
addition is welcome.
Sorry to come just now with another suggestion: we can use cdp_tls.h/cdp_tls.c
to house the cdp_openssl_clear_errors() function. This would get rid of the
extra
@lbalaceanu commented on this pull request.
Hello @xkaraman ,
Thank you for your contribution. I will also test minimally the code and give
an input after that as well.
> +#include "../../core/dprint.h"
+#include "utils.h"
+
+/*
+ * Get any leftover errors from OpenSSL and print them.
+ *
Thank you all for your help.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3548#issuecomment-1723436966
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER)
Hello @oej @henningw @miconda do you think this commit can be merged?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3548#issuecomment-1723184408
You are receiving this because you are subscribed to this thread.
Message ID:
Hi. Hope I took care of the punctual requests made by @oej and @henningw.
Please comment. However, starting tomorrow I will not have access to my laptop
for a week. Have a nice day!
--
Reply to this email directly or view it on GitHub:
@lbalaceanu pushed 2 commits.
ff9adaf928a4932894f8e628a48bfb7fdac684db cdp: adding TLS capability to peer
connections
0a2a63a606a883ecc4720d90ca8745a3db50b0e1 cdp: documenting TLS capability
related parameters
--
View it on GitHub:
@lbalaceanu pushed 2 commits.
e3dea073f93bccdc9353d2f1ab9fa0a29fca0030 cdp: adding TLS capability to peer
connections
a1e6bed57a1e84b4837cfc9a6d961b3c262155ee cdp: documenting TLS capability
related parameters
--
View it on GitHub:
@lbalaceanu pushed 1 commit.
60af9df0a5683c57472244fcf666ea3f07d78c62 cdp: updating docu for TLSv1.3
configuration addition
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3548/files/085bf21505a67e1404118d79f7e3288bdd2e4e51..60af9df0a5683c57472244fcf666ea3f07d78c62
You are
@lbalaceanu pushed 1 commit.
085bf21505a67e1404118d79f7e3288bdd2e4e51 cdp: adding TLSv1.3 configuration
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3548/files/8ad748a420162625e653f5f7759a85f66174c083..085bf21505a67e1404118d79f7e3288bdd2e4e51
You are receiving this because
@lbalaceanu pushed 1 commit.
8ad748a420162625e653f5f7759a85f66174c083 cdp: adding more in-depth openssl
logging
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3548/files/35a08f96a3919a58d53ca5ce25d74134de978e8d..8ad748a420162625e653f5f7759a85f66174c083
You are receiving this
@lbalaceanu pushed 2 commits.
d0a81b44f6cc3a058fd5771d7080c4e5d052ac7d cdp: adding ca_list param
35a08f96a3919a58d53ca5ce25d74134de978e8d cdp: updated with ca_list param and
clarifications
--
View it on GitHub:
More changes to follow in subsequent commits. In the end I will squash commits
in the PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3548#issuecomment-1693514716
You are receiving this because you are subscribed to this thread.
Message ID:
@lbalaceanu pushed 2 commits.
9c3d2117168dc3c992df5d18ff18385508082f29 cdp: fixing formatting
9bdbe7250d892cb2d871f7e283217f0af2274ea9 cdp: logging reworking
--
View it on GitHub:
Thank you for the comments, I will make changes accordingly. Will look into the
multi-stack issue as well.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3548#issuecomment-1691175127
You are receiving this because you are subscribed to this
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
Thank you for the approval.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3325#issuecomment-1378970369
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER)
Merged #3325 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3325#event-8202929412
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) -
For me this looks ok.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3325#issuecomment-1375553408
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) -
@miconda, thank you for the comments/ commits, I am looking into them.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3247#issuecomment-1263385817
You are receiving this because you are subscribed to this thread.
Message ID:
The implementation looks ok to me since it is convenient for now to keep
changes to the regular cmd export functions low.
The force-pushed appeared because of reverting some merge commit and then
changing the commit message.
I think this is ok for a merge.
--
Reply to this email directly or
This being said, @kristina258, I would close the issue.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2653#issuecomment-811711289___
Module: kamailio
Branch: 5.3
Commit: 00b6341b361bdcd07b6fa901a652850e3dcd67be
URL:
https://github.com/kamailio/kamailio/commit/00b6341b361bdcd07b6fa901a652850e3dcd67be
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2021-03-30T12:07:54+03:00
carrierroute: replace faulty warning
Module: kamailio
Branch: 5.4
Commit: f08e58145e93e57f2654ffcb901d49f9e898bcab
URL:
https://github.com/kamailio/kamailio/commit/f08e58145e93e57f2654ffcb901d49f9e898bcab
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2021-03-30T12:06:26+03:00
carrierroute: replace faulty warning
Hi @kristina258,
I have also tried with kamailio 4.4 but unfortunately this time I get 1min7
secs for the approx 500k entries in carrierroute tables created with kamdbctl
tool. I don't know if I am doing something wrong as I don't have experience
with postgres, but for me kamailio dev vs
Hello @kristina258 ,
Unfortunately, I can't reproduce your issue.
I have built Postgres carrierroute tables using kamctlrc/kamdbctl and am
testing using main branch (including new commit).
**time ./utils/kamcmd/kamcmd cr.reload_routes
real0m52.270s**
ser=# select count(*) from
Hi @kristina258, I will try to reproduce with postgres and will come back to
you.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Hi @NiteCrwlr , just pushed commit 087c00a276623adad6b87242bc58f7c0b4d8ff33 as
a possible fix for this bug. For us it worked since we were able to reproduce
the situation by having a lot of entries in the carrierroute table with prob =
0.
--
You are receiving this because you are subscribed
Hello Daniel,
I see my recent commit
https://github.com/kamailio/kamailio/commit/087c00a276623adad6b87242bc58f7c0b4d8ff33
fails CI.
However, https://travis-ci.org/github/kamailio/kamailio/jobs/762621150 suggests
it is some Docker problem.
Do I need to take some action?
Thank you,
Module: kamailio
Branch: master
Commit: 087c00a276623adad6b87242bc58f7c0b4d8ff33
URL:
https://github.com/kamailio/kamailio/commit/087c00a276623adad6b87242bc58f7c0b4d8ff33
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2021-03-12T17:58:41+02:00
carrierroute: replace faulty warning
Merged #2544 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2544#event-3978848224___
Kamailio (SER) - Development Mailing
:) My bad
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2544#issuecomment-724694264___
Kamailio (SER) - Development Mailing List
Merged #2544 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2544#event-3978847246___
Kamailio (SER) - Development Mailing
Closed #2544.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2544#event-3978834797___
Kamailio (SER) - Development Mailing List
Thank you. Closing the PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2544#issuecomment-724692518___
Kamailio (SER) - Development
Module: kamailio
Branch: master
Commit: b1af4ec9f976febd2efb5e657938ff731d8151df
URL:
https://github.com/kamailio/kamailio/commit/b1af4ec9f976febd2efb5e657938ff731d8151df
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2020-11-09T13:42:44+02:00
kamctl: regenerated db schema
Module: kamailio
Branch: master
Commit: 719c2987fcd02186554ed880c75a8e229804c8f8
URL:
https://github.com/kamailio/kamailio/commit/719c2987fcd02186554ed880c75a8e229804c8f8
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2020-11-09T11:51:11+02:00
kamctl: rename userblacklist
Module: kamailio
Branch: master
Commit: 879ca70de76b5171706b38a65b49e1061af0e225
URL:
https://github.com/kamailio/kamailio/commit/879ca70de76b5171706b38a65b49e1061af0e225
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2020-11-06T19:09:25+02:00
src/lib/srdb1/schema: replacing
Module: kamailio
Branch: master
Commit: 15dd032c7cd4d3029aa9e0100a3d52e24ab9c2ae
URL:
https://github.com/kamailio/kamailio/commit/15dd032c7cd4d3029aa9e0100a3d52e24ab9c2ae
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2020-11-06T18:13:30+02:00
userblocklist: renaming userblacklist
Module: kamailio
Branch: master
Commit: 333922750e71af0af21db741de440a25443083e2
URL:
https://github.com/kamailio/kamailio/commit/333922750e71af0af21db741de440a25443083e2
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2020-11-06T19:04:54+02:00
src/lib/srdb1/schema: renaming
@lbalaceanu pushed 1 commit.
b1af4ec9f976febd2efb5e657938ff731d8151df kamctl: regenerated db schema for
userblocklist
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@lbalaceanu pushed 1 commit.
719c2987fcd02186554ed880c75a8e229804c8f8 kamctl: rename userblacklist to
userblocklist
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
Module: kamailio
Branch: master
Commit: 134bf80ba553f6855b39bdb957edfb489e4b1d39
URL:
https://github.com/kamailio/kamailio/commit/134bf80ba553f6855b39bdb957edfb489e4b1d39
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2020-10-16T12:48:25+03:00
carrierroute: terminology changes
Module: kamailio
Branch: 5.3
Commit: 9f8b564800aa029f1d374c502c8c96272e5ea68a
URL:
https://github.com/kamailio/kamailio/commit/9f8b564800aa029f1d374c502c8c96272e5ea68a
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2020-07-17T13:04:32+03:00
p_usrloc: reworking
Module: kamailio
Branch: 5.4
Commit: ffb0576bd7d93303fb1068a332d9477a4d04471b
URL:
https://github.com/kamailio/kamailio/commit/ffb0576bd7d93303fb1068a332d9477a4d04471b
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2020-07-17T13:02:16+03:00
p_usrloc: reworking
Thank you.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2399#issuecomment-659932871___
Kamailio (SER) - Development Mailing List
Merged #2399 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2399#event-3556814952___
Kamailio (SER) - Development Mailing
Module: kamailio
Branch: master
Commit: 5789c506d022dd5713072cd1fcc07a25f42e098c
URL:
https://github.com/kamailio/kamailio/commit/5789c506d022dd5713072cd1fcc07a25f42e098c
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2020-07-14T11:49:21+03:00
p_usrloc: reworking
Hi,
If there are no comments, I will later on merge the pull requests.
@miconda, should I also backport this to 5.3, 5.4 since this also fixes a
previously possible deadlock due to acquiring a lock twice?
Thank you,
Lucian
--
You are receiving this because you are subscribed to this thread.
- simplify general implementation
- avoid deadlock due to a process trying to acquire same lock twice
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull
Merged #2107 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2107#event-2806912669___
Kamailio (SER) - Development Mailing
Module: kamailio
Branch: master
Commit: e3fe8e7f88c53e8ce69d776e21b78531d604783d
URL:
https://github.com/kamailio/kamailio/commit/e3fe8e7f88c53e8ce69d776e21b78531d604783d
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2019-11-07T15:46:13+02:00
acc: adding CDR engine functionality
Module: kamailio
Branch: master
Commit: 09f1c59bfef99867e4a006ba882ba13951b01276
URL:
https://github.com/kamailio/kamailio/commit/09f1c59bfef99867e4a006ba882ba13951b01276
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2019-11-13T11:52:17+02:00
acc_json: adding CDR as JSON
Should we then merge and close the pull request?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2107#issuecomment-554919680___
Kamailio
Hi guys,
I modified the commits to contain the CDR writing to the message queue as well.
Please let me know what you think.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@lbalaceanu pushed 2 commits.
e3fe8e7f88c53e8ce69d776e21b78531d604783d acc: adding CDR engine functionality
09f1c59bfef99867e4a006ba882ba13951b01276 acc_json: adding CDR as JSON
functionality
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Hi,
Please allow one or two days before merging, so that I can also add the mqueue
thing.
Thank you
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
in order to attain this CDR as
JSON? Do you have any suggestions?
Thank you,
Lucian Balaceanu
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Closed #1985.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1985#event-2441499485___
Kamailio (SER) - Development Mailing List
Issue seems to appear only when mixing v0 server and v1 client. Closing bug as
your fixes are enough.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Hi @miconda ; Can you please give more info as to how the coredump was
obtained, I mean on the server side? I think that the only way one can get
there is mixing a version "0" utils/pdbt server with a version 1 kamailio pdb
client. Your fix should of course
--
You are receiving this because
Thank you, looking on this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1985#issuecomment-503515926___
Kamailio (SER) - Development
Merged #1693 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1693#event-1934367108___
Kamailio (SER) - Development Mailing
Module: kamailio
Branch: master
Commit: 783763e8accef47aa563cd17d1e170250268751c
URL:
https://github.com/kamailio/kamailio/commit/783763e8accef47aa563cd17d1e170250268751c
Author: Lucian Balaceanu
Committer: Lucian Balaceanu
Date: 2018-10-29T11:54:45+02:00
pdb: fix SIGABRT in case of too long
buf in pdb_msg_dbg should correctly accomodate for pdb_bdy size
pdb_hdr + pdb_bdy should add to pdb_hdr.length (max 255)
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs,
a
commit using shm_address_in(). That might be safe to be added in
reset_path_vector() as well, to avoid troubles if someone calls it for a
shm cloned shm structure.
Cheers,
Daniel
On 13.07.18 13:06, Lucian Balaceanu wrote:
Hi guys,
Seeing the https://github.com/kamailio/kamailio/pull/1144
Hi guys,
Seeing the https://github.com/kamailio/kamailio/pull/1144 about fixing a
memory leak in the tm module due to incorrectly using FL_SHM_CLONE when
freing path_vec memory, isn't there a case that a similar patch should
be applied to corex/corex_lib.c ?
Inside corex_append_branch(..)
Hi guys,
Seeing the https://github.com/kamailio/kamailio/pull/1144 about fixing a
memory leak in the tm module due to incorrectly using FL_SHM_CLONE when
freing path_vec memory, isn't there a case that a similar patch should
be applied to corex/corex_lib.c ?
Inside corex_append_branch(..)
Merged #1529.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1529#event-1641923369___
Kamailio (SER) - Development Mailing List
lbalaceanu commented on this pull request.
> @@ -149,6 +152,25 @@ void check_dbs(unsigned int ticks, void *param){
lock_release(list_lock);
}
+void check_master_db(int dbm_write_default) {
+ if(mdb_availability_control) {
+ if(mdb.write.dbh){
Is it necessary to
lbalaceanu commented on this pull request.
I will continue the review tomorrow.
> @@ -307,6 +309,13 @@ static int mod_init(void)
}
#endif
+ if((write_on_master_db_shared = shm_malloc(sizeof(dbm_write_t))) ==
NULL) {
Make sure to shm_free this allocated memory.
> @@ -123,5
Module: kamailio
Branch: 5.1
Commit: 6770fe866dc6ed301b536a6132dc50e9844e720e
URL:
https://github.com/kamailio/kamailio/commit/6770fe866dc6ed301b536a6132dc50e9844e720e
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
Date: 2
Closed #1492.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1492#event-1556172938___
Kamailio (SER) - Development Mailing List
I have pushed
https://github.com/kamailio/kamailio/commit/dc8faaf57a9c85b7133f112bdedd328a9520eb73
on the master branch. For me it solved the problem. Could you confirm that
this is also the case for you so that we can close the issue?
--
You are receiving this because you are subscribed to
Module: kamailio
Branch: master
Commit: dc8faaf57a9c85b7133f112bdedd328a9520eb73
URL:
https://github.com/kamailio/kamailio/commit/dc8faaf57a9c85b7133f112bdedd328a9520eb73
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
D
The problem is with the reset of a prefix options structure. This is due to a
recent change in the code. I will come up with a fix.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Module: kamailio
Branch: master
Commit: cb6df95387186fab8670d17cfd8040de1b7f641e
URL:
https://github.com/kamailio/kamailio/commit/cb6df95387186fab8670d17cfd8040de1b7f641e
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
D
Hello Daniel,
location.sql is the only changed file. I see in the
src/lib/srdb1/schema/location.sql that this is documented as belonging to
usrloc and that the columns are present there.
Should I create a similar xml for p_usrloc used tables?
Thank you
--
You are receiving this because you
Module: kamailio
Branch: master
Commit: b8d5c7fbe994bb581c1e78285f08ec1980f6b89f
URL:
https://github.com/kamailio/kamailio/commit/b8d5c7fbe994bb581c1e78285f08ec1980f6b89f
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
D
Hello,
p_usrloc has not been kept up to date with latest usrloc and as such for now I
cannot tell you if the seemingly superset of columns in the usrloc-create.sql
does it.
If we only had one sql, the patching would also have to be done in the unlikely
case that usrloc would delete fields in
Thank you for your fix.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1266#issuecomment-335145249___
Kamailio (SER) - Development
Closed #1265 via 9be2a96651f743af0a22d0534ee9fc90e857d484.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1265#event-1284021531___
Merged #1266.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1266#event-1284021462___
Kamailio (SER) - Development Mailing List
Merged #1233.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1233#event-1245345074___
Kamailio (SER) - Development Mailing List
lbalaceanu commented on this pull request.
> @@ -352,6 +353,7 @@ int load_route_data_db(struct route_data_t * rd) {
}
}
int n = 0;
+ boolean query_done = true;
Please change query_done to false here and adapt the code accordingly. The name
of the variable
Module: kamailio
Branch: master
Commit: 43a12b88aa7ae018d92815628debe4c924e2b58f
URL:
https://github.com/kamailio/kamailio/commit/43a12b88aa7ae018d92815628debe4c924e2b58f
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
D
Module: kamailio
Branch: master
Commit: fda5be331d24342beb5b50e7171b4a3be9c5b4fc
URL:
https://github.com/kamailio/kamailio/commit/fda5be331d24342beb5b50e7171b4a3be9c5b4fc
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
D
Module: kamailio
Branch: master
Commit: d58fdb7c4e2e96a1bb2c64a47cc2b17e4bd03b4e
URL:
https://github.com/kamailio/kamailio/commit/d58fdb7c4e2e96a1bb2c64a47cc2b17e4bd03b4e
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
D
Module: kamailio
Branch: master
Commit: f567695de9ecbb5a5bffe4e212a294df2753a519
URL:
https://github.com/kamailio/kamailio/commit/f567695de9ecbb5a5bffe4e212a294df2753a519
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
D
Module: kamailio
Branch: master
Commit: a72abf8b1db2ecd8fabfd3e051d1bd61fd205a07
URL:
https://github.com/kamailio/kamailio/commit/a72abf8b1db2ecd8fabfd3e051d1bd61fd205a07
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
D
I assigned myself on this issue on behalf of @ManuelBothner who is doing this
work while having apprenticeship at 1&1.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Module: kamailio
Branch: master
Commit: 653b7343ebcca5f53f56bace94772a982bf0f887
URL:
https://github.com/kamailio/kamailio/commit/653b7343ebcca5f53f56bace94772a982bf0f887
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
D
Hello Daniel, we actually found out we want to bring two other changes/ fixes
to the module and thought it would be better to bring them all at once. The
fixes here are valid though.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
be ensured.
I don't feel that this commit is fixing an existing issues, rather
making it more aesthetic in some cases.
If I got it wrong, please provide more details and if other developers
are fine with this backport, I won't be against it.
Cheers,
Daniel
On 24.04.17 16:36, Lucian Balaceanu wrote
Updated code in the merge branch. If this also looks good to you I will close
the merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
the patch as a diff from the commit with `git
diff-tree -p COMMITID` and apply it manually with 'patch'.
If there are better ways, I am keen to learn about as well.
Cheers,
Daniel
On 13.04.17 14:54, Lucian Balaceanu wrote:
Hi guys,
I would like to port my latest master commit to the 4.4 branch
Module: kamailio
Branch: master
Commit: 3cdcb8ae3783d7221d212df00769b495f88c740b
URL:
https://github.com/kamailio/kamailio/commit/3cdcb8ae3783d7221d212df00769b495f88c740b
Author: Lucian Balaceanu <lucian.balace...@1and1.ro>
Committer: Lucian Balaceanu <lucian.balace...@1and1.ro>
D
100 matches
Mail list logo
