Re: [sr-dev] [kamailio/kamailio] Module: rr adding is_direction to kemi (#1589)
please backport to 5.x.x stable branches. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1589#issuecomment-404229916___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Module: rr adding is_direction to kemi (#1589)
Closed #1589. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1589#event-1728338026___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Module: rr adding is_direction to kemi (#1589)
Thanks for the contribution, however I pushed a slightly different implementation, to optimize by checking first the length of the parameter -- the commit is referenced above. Also, the commit message of your PR didn't use the format suggested by CONTRIBUTING.md guide. The indentation was not using tabs like the rest of the file. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1589#issuecomment-404224524___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] [kamailio/kamailio] Module: rr adding is_direction to kemi (#1589)
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook
files
in `doc/` subfolder, the README file is autogenerated)
Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
Checklist:
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue # (replace with an open issue number)
Description
is_direction("string") method added to kemi.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1589
-- Commit Summary --
* adding is_direction to kemi
-- File Changes --
M src/modules/rr/rr_mod.c (27)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1589.patch
https://github.com/kamailio/kamailio/pull/1589.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1589
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
