I understand.
Best Regards,
Aleksandar Yosifov
On Wed, 5 Jun 2019 at 13:25, Daniel-Constantin Mierla <
notificati...@github.com> wrote:
> Pay attention next time because the README file was removed completely
> with this PR (I just added it back).
>
> The README file must stay in the git tree,
Pay attention next time because the README file was removed completely with
this PR (I just added it back).
The README file must stay in the git tree, just not edited directly, because it
is updated from kamailio.org to keep consistency in the format.
--
You are receiving this because you
Merged #1974 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974#event-2390261268___
Kamailio (SER) - Development Mailing
alexyosifov commented on this pull request.
> > > Great work, just a small notice, there is a committed Readme file.
> >
> >
> > Thanks,
> > The committed README file is regenerated, not manually changed.
>
> Yes, but please remove the changes to the README file from your pull request.
> :-)
@alexyosifov pushed 1 commit.
71e8bf1e99e830800f379ea8ceabbc37d048cdd6 Delete README
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
> > Great work, just a small notice, there is a committed Readme file.
>
> Thanks,
> The committed README file is regenerated, not manually changed.
Yes, but please remove the changes to the README file from your pull request.
:-) This is not needed, the README is autogenerated from a script in
tdimitrov commented on this pull request.
Great job!
Only one remark - could you please address my comment about the hardcoded
PROTO_UDP in ipsec_forward function? If it is not an error - I'll merge it.
> @@ -562,6 +560,24 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d)
struct
> Great work, just a small notice, there is a committed Readme file.
Thanks,
The committed README file is regenerated, not manually changed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Great work, just a small notice, there is a committed Readme file, please make
the changes to the readme in the xml files in the doc folder.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README
10 matches
Mail list logo
