Re: [sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[alexyosifov]

I understand.

Best Regards,
Aleksandar Yosifov

On Wed, 5 Jun 2019 at 13:25, Daniel-Constantin Mierla <
notificati...@github.com> wrote:

> Pay attention next time because the README file was removed completely
> with this PR (I just added it back).
>
> The README file must stay in the git tree, just not edited directly,
> because it is updated from kamailio.org to keep consistency in the format.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 
> .
>


-- 
Best Regards,
Aleksandar Yosifov


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974#issuecomment-499361909___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[Daniel-Constantin Mierla]

Pay attention next time because the README file was removed completely with 
this PR (I just added it back).

The README file must stay in the git tree, just not edited directly, because it 
is updated from kamailio.org to keep consistency in the format. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974#issuecomment-499027725___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[Tsvetomir Dimitrov]

Merged #1974 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974#event-2390261268___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[alexyosifov]

alexyosifov commented on this pull request.

> > > Great work, just a small notice, there is a committed Readme file.
> > 
> > 
> > Thanks,
> > The committed README file is regenerated, not manually changed.
> 
> Yes, but please remove the changes to the README file from your pull request. 
> :-) This is not needed, the README is autogenerated from a script in our 
> infrastructure after every change.

Done.

> @@ -562,6 +560,24 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d)
 struct pcontact_info ci;
 pcontact_t* pcontact = NULL;
 int ret = IPSEC_CMD_FAIL; // FAIL by default
+unsigned char dst_proto = PROTO_UDP;

It's not an error, just default value.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974#pullrequestreview-245826671___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[alexyosifov]

@alexyosifov pushed 1 commit.

71e8bf1e99e830800f379ea8ceabbc37d048cdd6  Delete README


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1974/files/80bea2509fb3b7f792e3d12cf309ee55cfcc72d7..71e8bf1e99e830800f379ea8ceabbc37d048cdd6
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[Henning Westerholt]

> > Great work, just a small notice, there is a committed Readme file.
> 
> Thanks,
> The committed README file is regenerated, not manually changed.

Yes, but please remove the changes to the README file from your pull request. 
:-) This is not needed, the README is autogenerated from a script in our 
infrastructure after every change.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974#issuecomment-498815185___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[Tsvetomir Dimitrov]

tdimitrov commented on this pull request.

Great job! 

Only one remark - could you please address my comment about the hardcoded 
PROTO_UDP in ipsec_forward function? If it is not an error - I'll merge it.

> @@ -562,6 +560,24 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d)
 struct pcontact_info ci;
 pcontact_t* pcontact = NULL;
 int ret = IPSEC_CMD_FAIL; // FAIL by default
+unsigned char dst_proto = PROTO_UDP;

Is this hardcoded to PROTO_UDP on purpose?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974#pullrequestreview-245615615___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[alexyosifov]

> Great work, just a small notice, there is a committed Readme file.

Thanks,
The committed README file is regenerated, not manually changed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974#issuecomment-498613437___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[Rick]

Great work, just a small notice, there is a committed Readme file, please make 
the changes to the readme in the xml files in the doc folder.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974#issuecomment-498610887___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] Ipsec tcp (#1974)

[alexyosifov]

 Pre-Submission Checklist



- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, 
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1974

-- Commit Summary --

  * ims_ipsec_pcscf: IPv6 support
  * ims_usrloc_pcscf: get_pcontact changes for IPv6

-- File Changes --

M src/modules/ims_ipsec_pcscf/README (80)
M src/modules/ims_ipsec_pcscf/cmd.c (207)
M src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml (21)
M src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c (93)
M src/modules/ims_ipsec_pcscf/ipsec.c (14)
M src/modules/ims_ipsec_pcscf/ipsec.h (2)
M src/modules/ims_usrloc_pcscf/udomain.c (128)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1974.patch
https://github.com/kamailio/kamailio/pull/1974.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1974
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev