Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread Daniel-Constantin Mierla
@hdikme - the comment of @lbalaceanu was on the code of the patch and github hides it, you need to press `Show outdated` in the right side of @lbalaceanu's comment above here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme
Closed #1232. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1232#event-1245286133___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme
Following the commit based on your comment, your comment "Please change query_done to false here and adapt the code accordingly. The name of the variable should reflect the value it holds." disappeared but i have done the requested changes. -- You are receiving this because you are

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme
@hdikme pushed 2 commits. 4aaa0af carrierroute: warning for the same carrier/domain having routes with only 0 probability c275210 Merge branch 'master' of https://github.com/hdikme/kamailio -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread Lucian Balaceanu
lbalaceanu commented on this pull request. > @@ -352,6 +353,7 @@ int load_route_data_db(struct route_data_t * rd) { } } int n = 0; + boolean query_done = true; Please change query_done to false here and adapt the code accordingly. The name of the variable

[sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README