Re: [sr-dev] [kamailio/kamailio] core: Added methods for ip conversation. (#1962)
Closed #1962. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1962#event-2358513654___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] core: Added methods for ip conversation. (#1962)
There are already functions to parse a string to ip struct for ipv4 and ipv4, see str2ip() and str2ip6() in `src/core/resolve.h `. In that struct you have the `af` field. In most of the code, the two functions were used one after the other to parse ip addresses, if str2ip() fails, then try str2ip6(). We can add a new function str2ipx() as a wrapper to this logic, but otherwise, I see no reason to add the new functions proposed by your pull request. Also, the one for trimming `[ ]` for ipv6 with copy over is not that useful in a global scope from my point of view. Moreover, there are no safety checks over the size of the target pointer, nor comments requesting a minimum value for that. This can be in the module that needs it. I am closing this PR without merge. If people want to discuss more, then keep adding comments and if it is decided, it can be reopened. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1962#issuecomment-494707973___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] [kamailio/kamailio] core: Added methods for ip conversation. (#1962)
- The new methods are used in usrloc pscscf module, but they are universal and can be used anywhere. core: Added debug messages in grep_sock_info. Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1962 -- Commit Summary -- * core: Added methods for ip conversation. -- File Changes -- M src/core/resolve.c (138) M src/core/resolve.h (3) M src/core/socket_info.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1962.patch https://github.com/kamailio/kamailio/pull/1962.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1962 ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
