Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
Merged, will also backport to stable branches. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#issuecomment-551172743___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
Merged #2114 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#event-2780132406___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
@miconda - I know. :-) But as @alexyosifov was working on the code right now, I wanted to ask him about his opinion. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#issuecomment-551172300___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
> @henningw, @alexyosifov - looking at the patch, the pull request here is not > adding any `return 0`, they existed. The patch is adding a couple of > `close_mnl_socket(sock)`. > > If the existing `return 0` in error cases are wrong, then they need to be > fixed of course. But it is not a strict relation with this PR. Hi, I'll fix the problem with the error codes in the next ipsec pull request from my side. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#issuecomment-551146675___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
@henningw, @alexyosifov - looking at the patch, the pull request here is not adding any `return 0`, they existed. The patch is adding a couple of `close_mnl_socket(sock)`. If the existing `return 0` in error cases are wrong, then they need to be fixed of course. But it is not a strict relation with this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#issuecomment-551141814___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
I looked into the existing code of the function create_ipsec_tunnel(..) Are you sure that the "return 0" in the error cases is correct? Should it not be -1, as in the one case in the bottom of the function? If yes - then it makes probably sense to combine them all into one "goto error" case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#issuecomment-548443605___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
- fix leak socket when error handling errors in creation or destruction ipsec tunnel !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with git cherry-pick -x ... - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -- Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description !-- Describe your changes in detail -- Fixed socket leak on error during ipsec tunnel creation or destruction. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2114 -- Commit Summary -- * ims_ipsec_pcscf: closing mnl_socket in some exceptional situations -- File Changes -- M src/modules/ims_ipsec_pcscf/cmd.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2114.patch https://github.com/kamailio/kamailio/pull/2114.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114 ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
