Merged #2731 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2731#event-4788688269___
Kamailio (SER) - Development Mailing
@henningw commented on this pull request.
> @@ -100,8 +100,15 @@ static void string_to_key(char* dst, const str
> key_string)
}
}
+static uint choose_nlmsg_seq (void)
Was resolved as per other discussions.
--
You are receiving this because you are subscribed to this thread.
Reply to
@miconda , No comments from my side.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2731#issuecomment-847306443___
Kamailio (SER) -
Thanks @miconda , I did the correction and pushed
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2731#issuecomment-844490224___
Kamailio
@riccardv pushed 2 commits.
8ef89c258fceb417621cee694a2871066e06dc04 Merge remote-tracking branch
'origin/master' into ipsec_improve
f792b215321314d552f7fa90f17ef25b91cc2c09 ims_ipsec_pcscf: use
ksr_clock_gettime()
--
You are receiving this because you are subscribed to this thread.
View
@riccardv - I added `ksr_clock_gettime()` in the `core/ut.h`, which is portable
version of `clock_gettime()` that works for MacOS as well. Push another commit
to this PR to use it.
Any other comments from devs for this PR?
--
You are receiving this because you are subscribed to this thread.
@riccardv commented on this pull request.
> -// for Reply and TCP sends from P-CSCF server port, for Reply and
> UDP sends from P-CSCF client port
-src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc;
+// Check send socket
+struct socket_info *
@alexyosifov commented on this pull request.
> +// cipher_null, des, des3_ede, aes
strcpy(l_enc_algo->alg_name,"cipher_null");
+if (strncasecmp(r_ealg.s,"aes-cbc",r_ealg.len) == 0) {
+LM_DBG("Creating security associations: AES\n");
+
@alexyosifov commented on this pull request.
> -// for Reply and TCP sends from P-CSCF server port, for Reply and
> UDP sends from P-CSCF client port
-src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc;
+// Check send socket
+struct socket_info *
@riccardv commented on this pull request.
> +// cipher_null, des, des3_ede, aes
strcpy(l_enc_algo->alg_name,"cipher_null");
+if (strncasecmp(r_ealg.s,"aes-cbc",r_ealg.len) == 0) {
+LM_DBG("Creating security associations: AES\n");
+
@riccardv commented on this pull request.
> -// for Reply and TCP sends from P-CSCF server port, for Reply and
> UDP sends from P-CSCF client port
-src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc;
+// Check send socket
+struct socket_info *
@riccardv commented on this pull request.
> @@ -100,8 +100,15 @@ static void string_to_key(char* dst, const str
> key_string)
}
}
+static uint choose_nlmsg_seq (void)
Hi @henningw ,
I choose the 1 micro seconds granulation due to the commit comment:
"improve nlmsg_seq choice for
@alexyosifov approved this pull request.
> -// for Reply and TCP sends from P-CSCF server port, for Reply and
> UDP sends from P-CSCF client port
-src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc;
+// Check send socket
+struct socket_info *
@alexyosifov approved this pull request.
Added some comments
> @@ -846,11 +846,20 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d, int
> _cflags)
// for Reply get the dest proto from the received request
dst_proto = req->rcv.proto;
-// for Reply and TCP sends
@henningw commented on this pull request.
Thanks for the pull request, i have added one comment regarding the time
handling. Are there module any documentation updates necessary as well?
> @@ -100,8 +100,15 @@ static void string_to_key(char* dst, const str
> key_string)
}
}
+static
@alexyosifov - given that you contributed recently to this module, do you have
any comment on this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
- add aes-cbc, des-ede3-cbc ipsec encryption algoriyhms
- improve nlmsg_seq choice for concurrent multi UEs Registrations at
same time
- before sending replies over IPsec check the existing
of opened TCP sockets
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed
17 matches
Mail list logo
