Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-21 Thread alexyosifov
@alexyosifov pushed 0 commits. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/2287/files/df7ee4df03767424256a31f9b9ffdbbfc0b52f4a..2161f0cc316af0e1153b01f327d0e7c50523060c

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-21 Thread alexyosifov
Closed #2287. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2287#event-3255670815___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-21 Thread alexyosifov
Hi, Could you please check it again. I did the recommended changes. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-21 Thread alexyosifov
@alexyosifov pushed 1 commit. df7ee4df03767424256a31f9b9ffdbbfc0b52f4a ims_registrar_scscf: fix aor generation in lookup() -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-17 Thread alexyosifov
> Thanks for this contribution! > > However, wouldn't it be better to use `parse_sip_msg_uri()` so `_m->new_uri` > or ` _m->first_line.u.request.uri` is parsed in the `_m->parsed_uri` field > and then just build the AoR using `_m->parsed_uri.user` and > `_m->parsed_uri.host`? Thanks for the

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-16 Thread Daniel-Constantin Mierla
Thanks for this contribution! However, wouldn't it be better to use `parse_sip_msg_uri()` so `_m->new_uri` or ` _m->first_line.u.request.uri` is parsed in the `_m->parsed_uri` field and then just build the AoR using `_m->parsed_uri.user` and `_m->parsed_uri.host`? -- You are receiving this

[sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-16 Thread alexyosifov
- If uri contains some parameters before @ as phone context, till now the function strips everything after that. With the fix all parameters before and after @ are stripped and the domain remaining. !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing